All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Steve Kenton <skenton@ou.edu>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/memtest86: pass TARGET_CC
Date: Fri, 8 Dec 2023 23:53:59 +0100	[thread overview]
Message-ID: <ZXOehwwVDyiGPpRf@landeda> (raw)
In-Reply-To: <20231207220930.1356097-1-fontaine.fabrice@gmail.com>

On 2023-12-07 23:09 +0100, Fabrice Fontaine spake thusly:
> Pass CC=$(TARGET_CC) to make to avoid the following build failure raised
> since bump to version 6.20 in commit
> a743087593a5fd5b33e2650591cada09929c27a6:
> 
> gcc -m32 -x assembler-with-cpp -c -I../boot -o boot/startup.o ../boot/startup32.S
> gcc: error: unrecognized command-line option '-m32'
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/15ece19703bb21c1326ff353aa79f3550a01f648
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/memtest86/memtest86.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/memtest86/memtest86.mk b/package/memtest86/memtest86.mk
> index c0f85755fe..51d5805e0a 100644
> --- a/package/memtest86/memtest86.mk
> +++ b/package/memtest86/memtest86.mk
> @@ -20,7 +20,8 @@ endif
>  endif
>  
>  define MEMTEST86_BUILD_CMDS
> -	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/$(MEMTEST86_BUILD_DIR)
> +	$(TARGET_CONFIGURE_OPTS) $(MAKE) CC=$(TARGET_CC) \

CC=$(TARGET_CC) is already present in TARGET_CONFIGURE_OPTS, so why is
it not accounted for?

Regards,
Yann E. MORIN.

> +		-C $(@D)/$(MEMTEST86_BUILD_DIR)
>  endef
>  
>  define MEMTEST86_INSTALL_IMAGES_CMDS
> -- 
> 2.42.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-12-08 22:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-07 22:09 [Buildroot] [PATCH 1/1] package/memtest86: pass TARGET_CC Fabrice Fontaine
2023-12-08 22:53 ` Yann E. MORIN [this message]
2023-12-08 23:04   ` Fabrice Fontaine
2023-12-08 23:12     ` Yann E. MORIN
2023-12-08 23:20       ` Fabrice Fontaine
2023-12-09  9:28         ` Yann E. MORIN
2023-12-23 20:10           ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZXOehwwVDyiGPpRf@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=skenton@ou.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.