From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DvSBzWei" Received: from mail-vk1-xa36.google.com (mail-vk1-xa36.google.com [IPv6:2607:f8b0:4864:20::a36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49EB6171E; Fri, 8 Dec 2023 15:38:14 -0800 (PST) Received: by mail-vk1-xa36.google.com with SMTP id 71dfb90a1353d-4b314f78326so748666e0c.3; Fri, 08 Dec 2023 15:38:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702078693; x=1702683493; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=aa6XX3Pqe4FOIY2+l8f727rXZuXDdaFGtGV099fvry8=; b=DvSBzWei1+woCDmO4i35JAxRnbVIIBCTQlB5fOohtwYpOQ+i2AuwMvujUcsDkGYqHk Jd7slqy8iymOclrjFcAswIq8wFBggNmlCFY3xQpxFMcR1vpT5D/mMnbcPmqdYTDwDdQa 6tYPWMwIairEPgNcF7e+VOKXbau9gqmKAT29pxFTvEya11DTliUFrafxOEYKg/uZ7Jhy Dtl16x80NIUfpXrOLqmKc1sZRtR2tnVD4PXQtHX9Hnet78iLULefVE1yY7qBR+o7llOS +d0Xp50nyJK+Qe0sYPOOinW14h8afpOqArNEytdTPDyjrzXNz3FVKLZQESrULgW3fTOz 9VCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702078693; x=1702683493; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aa6XX3Pqe4FOIY2+l8f727rXZuXDdaFGtGV099fvry8=; b=NFE5zeqDyLoJGIfACo302CejYradaSPDJOjIfdMsJE0ke7vhH6RKozUT9mKPHqVDto K8hjMfDXpNuwGE2nNyG1LNKGPtPJfjJYVKOX5prQAMR8X/er1kuT6PDCh01LnP7KlvJz iSIMN6CfMnrv8NiZ5/+bX4LvIA6m58LXfjHcqOTcPsCnFv4bXwO1g6ehVk7B7VhNcG2X ny/97PtRJAyzg9ZWt1zJeJc178JhyoGXBTM+pLIGVthfwpxjZURTPG8jihHMmJMhvEC6 dGn7veOexQC9mA6NZn5v6yiF5lt3aJi52DhO9AScxFP3NUAxgqjBs8gtXqblL1lQe61Q +7Eg== X-Gm-Message-State: AOJu0YxYdiEmPzkPo3u25Ij/YTBCDK7lQ5PYQ5wd/2uuiwj8mN2F44E4 m42kBsnoiPUCDQ/7vQwJhUg= X-Google-Smtp-Source: AGHT+IFkBIYirOVsuJZ+xKdfgU+tNmKrr/wwRQ+zfxVVmiBF4DC8/teo4dabz706/JZwpt6hg+Y2UQ== X-Received: by 2002:a05:6122:3a0a:b0:4b2:c555:15a0 with SMTP id fp10-20020a0561223a0a00b004b2c55515a0mr1079285vkb.27.1702078693275; Fri, 08 Dec 2023 15:38:13 -0800 (PST) Received: from google.com ([205.220.129.31]) by smtp.gmail.com with ESMTPSA id kh10-20020a056214514a00b0067a1c7d8e98sm1167263qvb.41.2023.12.08.15.37.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 15:38:12 -0800 (PST) Date: Fri, 8 Dec 2023 23:37:47 +0000 From: Dmitry Torokhov To: Linus Walleij Cc: Stefan Eichenberger , nick@shmanahar.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stefan Eichenberger Subject: Re: [PATCH v1 1/2] dt-bindings: input: atmel,maxtouch: add poweroff-in-suspend property Message-ID: References: <20231207111300.80581-1-eichest@gmail.com> <20231207111300.80581-2-eichest@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Linus, Krzysztof, On Fri, Dec 08, 2023 at 01:54:21PM +0100, Linus Walleij wrote: > On Thu, Dec 7, 2023 at 12:13 PM Stefan Eichenberger wrote: > > > From: Stefan Eichenberger > > > > Add a new property to indicate that the device should be powered off in > > suspend mode. > > > > Signed-off-by: Stefan Eichenberger > (...) > > + atmel,poweroff-in-suspend: > > + description: | > > + When this property is set, all supplies are turned off when the system is > > + going to suspend. > > + type: boolean > wakeup-source: > type: boolean > > As Krzysztof says it seems you are describing an operating system feature. It appears to be an OS feature, but I would argue that it is also a property of a board. It is tempting to say that if DTS defines supplies for the controller we should use them to power off the controller in suspend, otherwise we should use the deep sleep functionality of the controller. But a mere presence of regulators does not indicate if they can actually be powered off in suspend (i.e. if controllers shares power rails with another device that can be a wakeup source), so we need to have additional hints on how OS should behave on a given device. On top of that we have regulator framework supplying dummy regulators... Thanks. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05D21C4167B for ; Fri, 8 Dec 2023 23:38:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MQdqaRJJTNga+RnvJyvHq7ceu3SjzbeNWXVjiYNdqf0=; b=ysHqW5mjdABX/G Zn2C7yvUkJo7aqSEW3PpwXpARj6r1eBlM9feBIIZB8W7hc/QDJtxWWN7r/9IBwFAnJFtxU3jkp0nK j7bNC0FmiOERLLXp38FygW89AdZVwN+mzVLZmGahIgThTINd1iCEVRHyB3bjcDwbHgIsC7yHk9BZf Cy/ybk/3ZyBTC5O4uLTN8h9fckgfdZi50QmVyCLXri/V1vefFk+t070Y95B22bR61wrmmjEf+QcvH QEJkOMjk0AQOq8x5+V3yx73VsF+5OiSPXFrGKsHUF1OV8OEmR/lzobDsf6EkZ7Na5yI+JEEu2jSgC 3QrqEKP0OsZ1J+gl9jhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBkQG-00GmR3-0G; Fri, 08 Dec 2023 23:38:20 +0000 Received: from mail-vk1-xa29.google.com ([2607:f8b0:4864:20::a29]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBkQC-00GmQP-2D for linux-arm-kernel@lists.infradead.org; Fri, 08 Dec 2023 23:38:18 +0000 Received: by mail-vk1-xa29.google.com with SMTP id 71dfb90a1353d-4b314f78326so748665e0c.3 for ; Fri, 08 Dec 2023 15:38:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702078693; x=1702683493; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=aa6XX3Pqe4FOIY2+l8f727rXZuXDdaFGtGV099fvry8=; b=QXeHWR9Dq8YF3FkRHoLIs+6Ti6SXpJ3h09J3V2utvZLmDvHBvnwcDgm4TzNw1uqFsM 3VMgURRAYVHMEfSZeqgcHxD2U2frjJY1qfDb5hQ7CKfwXXWUxP8trcp6u2yc+8tPmKLY QHAyJByICAg+v6tBWpvObxoke/YQvpUdDqjpj1kDuW3Zq8V1juRhwSXlsyvldrcKKl7M 9R+wMYqqlekm/rGN2jXfLKLh7g+hFlH5JvSRQOsmBTTMWmZcDg9TgB8N/AIJ35Ms/xip yivxBcF3EUZgwE/7ZRHe74+OsxrdJJ66EE85CVnrOyh96IlAH1G0AB3PN2INTyhNFXeJ mjJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702078693; x=1702683493; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aa6XX3Pqe4FOIY2+l8f727rXZuXDdaFGtGV099fvry8=; b=t4dSj2NcHpf/vqbv2RlHVaFuqeNnn0MpuwxTUDrA/XlsxKNfa4IgpHtHhmOgubHTPF sYg0jxDi3L7cfryCSDps2Gmi70H/GMql39I3o/HpXyCBuFinOXWjtTXXR2I5hSc3Y8RW X5E6akWL8rUnJ2XgnVY/gd5iCbY+TxLKHLJpKaLv/9D0jC1D0gNvfDfDQSC6RRw69Ihb sz0HcD2rp7hnCmF/F2PBFWzRY0bIfY5BMZkRgzN6dek4jNyAB9qeKMRABN9ob+QtSZLV iPoBUnKAWeMNUHKHDxI9p0LGICgvkhk/RPSgMKtWMn8OOG1yfNbL1hrKKBVBHng6rlNQ DdEw== X-Gm-Message-State: AOJu0YzOVwlqmupfC3/9zq9AJuhK2436vrEHPhtVWU3qkWtXdXm/5Zly 8Byt/ZI0KwPLoWNVOKgBQb8= X-Google-Smtp-Source: AGHT+IFkBIYirOVsuJZ+xKdfgU+tNmKrr/wwRQ+zfxVVmiBF4DC8/teo4dabz706/JZwpt6hg+Y2UQ== X-Received: by 2002:a05:6122:3a0a:b0:4b2:c555:15a0 with SMTP id fp10-20020a0561223a0a00b004b2c55515a0mr1079285vkb.27.1702078693275; Fri, 08 Dec 2023 15:38:13 -0800 (PST) Received: from google.com ([205.220.129.31]) by smtp.gmail.com with ESMTPSA id kh10-20020a056214514a00b0067a1c7d8e98sm1167263qvb.41.2023.12.08.15.37.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 15:38:12 -0800 (PST) Date: Fri, 8 Dec 2023 23:37:47 +0000 From: Dmitry Torokhov To: Linus Walleij Subject: Re: [PATCH v1 1/2] dt-bindings: input: atmel,maxtouch: add poweroff-in-suspend property Message-ID: References: <20231207111300.80581-1-eichest@gmail.com> <20231207111300.80581-2-eichest@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231208_153816_763516_5D76B975 X-CRM114-Status: GOOD ( 19.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, Stefan Eichenberger , nick@shmanahar.org, linux-kernel@vger.kernel.org, claudiu.beznea@tuxon.dev, Stefan Eichenberger , robh+dt@kernel.org, alexandre.belloni@bootlin.com, krzysztof.kozlowski+dt@linaro.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTGludXMsIEtyenlzenRvZiwKCk9uIEZyaSwgRGVjIDA4LCAyMDIzIGF0IDAxOjU0OjIxUE0g KzAxMDAsIExpbnVzIFdhbGxlaWogd3JvdGU6Cj4gT24gVGh1LCBEZWMgNywgMjAyMyBhdCAxMjox M+KAr1BNIFN0ZWZhbiBFaWNoZW5iZXJnZXIgPGVpY2hlc3RAZ21haWwuY29tPiB3cm90ZToKPiAK PiA+IEZyb206IFN0ZWZhbiBFaWNoZW5iZXJnZXIgPHN0ZWZhbi5laWNoZW5iZXJnZXJAdG9yYWRl eC5jb20+Cj4gPgo+ID4gQWRkIGEgbmV3IHByb3BlcnR5IHRvIGluZGljYXRlIHRoYXQgdGhlIGRl dmljZSBzaG91bGQgYmUgcG93ZXJlZCBvZmYgaW4KPiA+IHN1c3BlbmQgbW9kZS4KPiA+Cj4gPiBT aWduZWQtb2ZmLWJ5OiBTdGVmYW4gRWljaGVuYmVyZ2VyIDxzdGVmYW4uZWljaGVuYmVyZ2VyQHRv cmFkZXguY29tPgo+ICguLi4pCj4gPiArICBhdG1lbCxwb3dlcm9mZi1pbi1zdXNwZW5kOgo+ID4g KyAgICBkZXNjcmlwdGlvbjogfAo+ID4gKyAgICAgIFdoZW4gdGhpcyBwcm9wZXJ0eSBpcyBzZXQs IGFsbCBzdXBwbGllcyBhcmUgdHVybmVkIG9mZiB3aGVuIHRoZSBzeXN0ZW0gaXMKPiA+ICsgICAg ICBnb2luZyB0byBzdXNwZW5kLgo+ID4gKyAgICB0eXBlOiBib29sZWFuCj4gICAgd2FrZXVwLXNv dXJjZToKPiAgICAgIHR5cGU6IGJvb2xlYW4KPiAKPiBBcyBLcnp5c3p0b2Ygc2F5cyBpdCBzZWVt cyB5b3UgYXJlIGRlc2NyaWJpbmcgYW4gb3BlcmF0aW5nIHN5c3RlbSBmZWF0dXJlLgoKSXQgYXBw ZWFycyB0byBiZSBhbiBPUyBmZWF0dXJlLCBidXQgSSB3b3VsZCBhcmd1ZSB0aGF0IGl0IGlzIGFs c28gYQpwcm9wZXJ0eSBvZiBhIGJvYXJkLiBJdCBpcyB0ZW1wdGluZyB0byBzYXkgdGhhdCBpZiBE VFMgZGVmaW5lcyBzdXBwbGllcwpmb3IgdGhlIGNvbnRyb2xsZXIgd2Ugc2hvdWxkIHVzZSB0aGVt IHRvIHBvd2VyIG9mZiB0aGUgY29udHJvbGxlciBpbgpzdXNwZW5kLCBvdGhlcndpc2Ugd2Ugc2hv dWxkIHVzZSB0aGUgZGVlcCBzbGVlcCBmdW5jdGlvbmFsaXR5IG9mIHRoZQpjb250cm9sbGVyLiBC dXQgYSBtZXJlIHByZXNlbmNlIG9mIHJlZ3VsYXRvcnMgZG9lcyBub3QgaW5kaWNhdGUgaWYgdGhl eQpjYW4gYWN0dWFsbHkgYmUgcG93ZXJlZCBvZmYgaW4gc3VzcGVuZCAoaS5lLiBpZiBjb250cm9s bGVycyBzaGFyZXMgcG93ZXIKcmFpbHMgd2l0aCBhbm90aGVyIGRldmljZSB0aGF0IGNhbiBiZSBh IHdha2V1cCBzb3VyY2UpLCBzbyB3ZSBuZWVkIHRvCmhhdmUgYWRkaXRpb25hbCBoaW50cyBvbiBo b3cgT1Mgc2hvdWxkIGJlaGF2ZSBvbiBhIGdpdmVuIGRldmljZS4KCk9uIHRvcCBvZiB0aGF0IHdl IGhhdmUgcmVndWxhdG9yIGZyYW1ld29yayBzdXBwbHlpbmcgZHVtbXkgcmVndWxhdG9ycy4uLgoK VGhhbmtzLgoKLS0gCkRtaXRyeQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=