From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: selftests: fix supported_flags for aarch64
Date: Fri, 8 Dec 2023 18:29:47 -0800 [thread overview]
Message-ID: <ZXPRGzgWFqFdI_ep@google.com> (raw)
In-Reply-To: <20231208184628.2297994-1-pbonzini@redhat.com>
On Fri, Dec 08, 2023, Paolo Bonzini wrote:
> KVM/Arm supports readonly memslots; fix the calculation of
> supported_flags in set_memory_region_test.c, otherwise the
> test fails.
You got beat by a few hours, and by a better solution ;-)
https://lore.kernel.org/all/20231208033505.2930064-1-shahuang@redhat.com
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tools/testing/selftests/kvm/set_memory_region_test.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kvm/set_memory_region_test.c b/tools/testing/selftests/kvm/set_memory_region_test.c
> index 6637a0845acf..dfd1d1e22da3 100644
> --- a/tools/testing/selftests/kvm/set_memory_region_test.c
> +++ b/tools/testing/selftests/kvm/set_memory_region_test.c
> @@ -333,9 +333,11 @@ static void test_invalid_memory_region_flags(void)
> struct kvm_vm *vm;
> int r, i;
>
> -#ifdef __x86_64__
> +#if defined __aarch64__ || defined __x86_64__
> supported_flags |= KVM_MEM_READONLY;
> +#endif
>
> +#ifdef __x86_64__
> if (kvm_check_cap(KVM_CAP_VM_TYPES) & BIT(KVM_X86_SW_PROTECTED_VM))
> vm = vm_create_barebones_protected_vm();
> else
> --
> 2.39.1
>
next prev parent reply other threads:[~2023-12-09 2:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 18:46 [PATCH] KVM: selftests: fix supported_flags for aarch64 Paolo Bonzini
2023-12-09 2:29 ` Sean Christopherson [this message]
2023-12-12 10:39 ` Paolo Bonzini
2023-12-13 17:21 ` Sean Christopherson
2023-12-13 17:39 ` Paolo Bonzini
2023-12-13 18:15 ` Sean Christopherson
2023-12-13 18:44 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXPRGzgWFqFdI_ep@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.