From: Dave Chinner <david@fromorbit.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Zorro Lang <zlang@redhat.com>,
linux-xfs@vger.kernel.org, linux-s390@vger.kernel.org,
fstests@vger.kernel.org, Pankaj Raghav <p.raghav@samsung.com>,
Daniel Gomez <da.gomez@samsung.com>
Subject: Re: [Bug report] More xfs courruption issue found on s390x
Date: Sat, 9 Dec 2023 15:53:55 +1100 [thread overview]
Message-ID: <ZXPy4+cXlIt0agNz@dread.disaster.area> (raw)
In-Reply-To: <ZXO7gd3Ft1di8Okm@bombadil.infradead.org>
On Fri, Dec 08, 2023 at 04:57:37PM -0800, Luis Chamberlain wrote:
> On Mon, Nov 06, 2023 at 05:26:14PM +1100, Dave Chinner wrote:
> > > XFS: Assertion failed: ip->i_nblocks == 0, file: fs/xfs/xfs_inode.c, line: 2359
> >
> > IOWs, all four of these issues are the same problem - journal
> > recovery is not resulting in a correct and consistent filesystem
> > after the journal has been flushed at runtime, so please discuss and
> > consolidate them all in the initial bug report thread....
>
> As recently reported, fortunately we now have reproducers for x86_64 too:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=218224
>
> This fails on the following test sections as defined by kdevops [1]:
>
> * xfs_nocrc_2k
> * xfs_reflink
> * xfs_reflink_1024
> * xfs_reflink_2k
> * xfs_reflink_4k
> * xfs_reflink_dir_bsize_8k
> * xfs_reflink_logdev
> * xfs_reflink_normapbt
> * xfs_reflink_nrext64
>
> [0] https://github.com/linux-kdevops/kdevops/blob/master/playbooks/roles/fstests/templates/xfs/xfs.config
>
> Example failures:
>
> * generic/475: https://gist.github.com/mcgrof/5d6f504f4695ba27cea7df5d63f35197
> * generic/388: https://gist.github.com/mcgrof/c1c8b1dc76fdc1032a5f0aab6c2a14bf
> * generic/648: https://gist.github.com/mcgrof/1e506ecbe898b45428d6e7febfc02db1
If this is the same problem, have you tested whether the fix for the
s390 issue makes all the problems you are seeing on x86-64 go away?
i.e. commit 7930d9e10370 ("xfs: recovery should not clear di_flushiter
unconditionally")
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2023-12-09 4:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 4:33 [Bug report] More xfs courruption issue found on s390x Zorro Lang
2023-11-06 6:26 ` Dave Chinner
2023-12-09 0:57 ` Luis Chamberlain
2023-12-09 4:53 ` Dave Chinner [this message]
2023-11-08 16:38 ` edward6
2023-11-09 1:50 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXPy4+cXlIt0agNz@dread.disaster.area \
--to=david@fromorbit.com \
--cc=da.gomez@samsung.com \
--cc=fstests@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.