From: Johan Hovold <johan@kernel.org>
To: Richard Acayan <mailingradian@gmail.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: qcom: sdm670: fix USB DP/DM HS PHY interrupts
Date: Mon, 18 Dec 2023 08:36:01 +0100 [thread overview]
Message-ID: <ZX_2YTxSKg4sE2js@hovoldconsulting.com> (raw)
In-Reply-To: <ZXzph8s_WF09VdtZ@radian>
On Fri, Dec 15, 2023 at 07:04:23PM -0500, Richard Acayan wrote:
> On Fri, Dec 15, 2023 at 08:34:39AM +0100, Johan Hovold wrote:
> > On Thu, Dec 14, 2023 at 08:46:27PM -0500, Richard Acayan wrote:
> > > Tested-by: Richard Acayan <mailingradian@gmail.com>
> > >
> > > On a Pixel 3a, plugging in a USB cable doesn't wake up the device
> > > (presumably because there is no wakeup-source property) but this gets
> > > USB working again on linux-next.
> >
> > Thanks for testing. And yes, the wakeup interrupts will indeed not be
> > enabled at system suspend unless the wakeup-source property is there.
> > Did you try adding it?
>
> Just tested today. Adding it does not cause the system to wake up when
> plugging in a laptop on the Pixel 3a, but that might just be because
> USB wakeups are disabled when the adapter is configured for peripheral
> mode.
Right, wake up is currently only implemented for host mode.
Johan
next prev parent reply other threads:[~2023-12-18 7:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 7:43 [PATCH 0/3] arm64: dts: qcom: fix USB wakeup interrupts again (pt 2) Johan Hovold
2023-12-14 7:43 ` [PATCH 1/3] arm64: dts: qcom: sdm670: fix USB DP/DM HS PHY interrupts Johan Hovold
2023-12-14 12:27 ` Konrad Dybcio
2023-12-15 1:46 ` Richard Acayan
2023-12-15 7:34 ` Johan Hovold
2023-12-16 0:04 ` Richard Acayan
2023-12-18 7:36 ` Johan Hovold [this message]
2023-12-16 2:34 ` Richard Acayan
2023-12-18 7:39 ` Johan Hovold
2023-12-14 7:43 ` [PATCH 2/3] arm64: dts: qcom: sdm670: fix USB SS wakeup Johan Hovold
2023-12-14 12:28 ` Konrad Dybcio
2023-12-15 1:46 ` Richard Acayan
2023-12-14 7:43 ` [PATCH 3/3] arm64: dts: qcom: sc8180x: " Johan Hovold
2023-12-14 12:28 ` Konrad Dybcio
2023-12-19 19:33 ` [PATCH 0/3] arm64: dts: qcom: fix USB wakeup interrupts again (pt 2) Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZX_2YTxSKg4sE2js@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=quic_kriskura@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.