All of lore.kernel.org
 help / color / mirror / Atom feed
From: swarup <swarupkotikalapudi@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH net-next v6] netlink: specs: devlink: add some(not all) missing attributes in devlink.yaml
Date: Mon, 11 Dec 2023 17:50:13 +0530	[thread overview]
Message-ID: <ZXb+fRawVUgU+lrX@swarup-virtual-machine> (raw)
In-Reply-To: <ZXbaauFOfttLCe78@nanopsycho>

esOn Mon, Dec 11, 2023 at 10:46:18AM +0100, Jiri Pirko wrote:
> Fri, Dec 08, 2023 at 07:25:15PM CET, swarupkotikalapudi@gmail.com wrote:
> >Add some missing(not all) attributes in devlink.yaml.
> >
> >Signed-off-by: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
> >Suggested-by: Jiri Pirko <jiri@resnulli.us>
> >---
> >V6:
> >  - Fix review comments
> 
> Would be nice to list what changes you actually did.
> 
> Nevertheless, patch looks fine to me.
> 
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>

Hi Jiri,

Do you mean in the commit message, i should have listed all the changes?
Please clarify, if required i update the commit message.

Thanks,
Swarup

  reply	other threads:[~2023-12-11 12:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-08 18:25 [PATCH net-next v6] netlink: specs: devlink: add some(not all) missing attributes in devlink.yaml Swarup Laxman Kotiaklapudi
2023-12-11  9:46 ` Jiri Pirko
2023-12-11 12:20   ` swarup [this message]
2023-12-11 12:35     ` Jiri Pirko
2023-12-12  3:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZXb+fRawVUgU+lrX@swarup-virtual-machine \
    --to=swarupkotikalapudi@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.