From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/xe: Use DRM_GPUVM_RESV_PROTECTED for gpuvm
Date: Mon, 11 Dec 2023 16:24:30 -0500 [thread overview]
Message-ID: <ZXd-Dg6Jux1a7dJY@intel.com> (raw)
In-Reply-To: <20231209144917.4459-3-thomas.hellstrom@linux.intel.com>
On Sat, Dec 09, 2023 at 03:49:17PM +0100, Thomas Hellström wrote:
> Use DRM_GPUVM_RESV_PROTECTED to use corse-grained locking for the
> evict and external object list.
> Since we are already holding the relevant RESV locks, for now at least,
> we don't need the fine-grained locking.
>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/xe/xe_vm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 2c35395ff5d4..c0fcb49e9137 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -1231,8 +1231,8 @@ struct xe_vm *xe_vm_create(struct xe_device *xe, u32 flags)
> goto err_no_resv;
> }
>
> - drm_gpuvm_init(&vm->gpuvm, "Xe VM", 0, &xe->drm, vm_resv_obj,
> - 0, vm->size, 0, 0, &gpuvm_ops);
> + drm_gpuvm_init(&vm->gpuvm, "Xe VM", DRM_GPUVM_RESV_PROTECTED, &xe->drm,
> + vm_resv_obj, 0, vm->size, 0, 0, &gpuvm_ops);
>
> drm_gem_object_put(vm_resv_obj);
>
> --
> 2.42.0
>
next prev parent reply other threads:[~2023-12-11 21:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 14:49 [PATCH 0/2] Use DRM_GPUVM helpers for the vm evict and exobj listss Thomas Hellström
2023-12-09 14:49 ` [PATCH 1/2] drm/xe: Use DRM GPUVM helpers for external- and evicted objects Thomas Hellström
2023-12-11 21:24 ` Rodrigo Vivi
2023-12-11 23:08 ` Matthew Brost
2023-12-12 8:29 ` Thomas Hellström
2023-12-09 14:49 ` [PATCH 2/2] drm/xe: Use DRM_GPUVM_RESV_PROTECTED for gpuvm Thomas Hellström
2023-12-11 21:24 ` Rodrigo Vivi [this message]
2023-12-09 14:51 ` ✓ CI.Patch_applied: success for Use DRM_GPUVM helpers for the vm evict and exobj listss Patchwork
2023-12-09 14:52 ` ✓ CI.checkpatch: " Patchwork
2023-12-09 14:53 ` ✓ CI.KUnit: " Patchwork
2023-12-09 15:00 ` ✓ CI.Build: " Patchwork
2023-12-09 15:00 ` ✓ CI.Hooks: " Patchwork
2023-12-09 15:02 ` ✓ CI.checksparse: " Patchwork
2023-12-09 15:39 ` ✗ CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXd-Dg6Jux1a7dJY@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.