From: Jiri Olsa <olsajiri@gmail.com>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Jiri Olsa <olsajiri@gmail.com>,
bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, martin.lau@linux.dev, song@kernel.org,
yonghong.song@linux.dev, dan.carpenter@linaro.org,
asavkov@redhat.com
Subject: Re: [PATCH bpf-next v7 1/4] bpf: Relax tracing prog recursive attach rules
Date: Tue, 12 Dec 2023 10:56:31 +0100 [thread overview]
Message-ID: <ZXguT7cQF7d8RuSk@krava> (raw)
In-Reply-To: <20231211184908.qhfdspfb77ttm2zw@erthalion.local>
On Mon, Dec 11, 2023 at 07:49:08PM +0100, Dmitry Dolgov wrote:
> > On Mon, Dec 11, 2023 at 01:30:24PM +0100, Jiri Olsa wrote:
> > > + /* Bookkeeping for managing the prog attachment chain */
> > > + if (tgt_prog &&
> > > + prog->type == BPF_PROG_TYPE_TRACING &&
> > > + tgt_prog->type == BPF_PROG_TYPE_TRACING)
> > > + prog->aux->attach_tracing_prog = true;
> >
> > wrong indentation in here, please check the if conditions around
>
> I'm a bit confused here, why is the indentation here wrong? IIUC "if"
> predicates have to be aligned on the same column, with padding where
> needed. Or is it always necessary to expand the last tab with spaces?
I meant it should have looked something like this:
if (tgt_prog &&
prog->type == BPF_PROG_TYPE_TRACING &&
tgt_prog->type == BPF_PROG_TYPE_TRACING)
prog->aux->attach_tracing_prog = true;
jirka
next prev parent reply other threads:[~2023-12-12 9:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 18:55 [PATCH bpf-next v7 0/4] Relax tracing prog recursive attach rules Dmitrii Dolgov
2023-12-08 18:55 ` [PATCH bpf-next v7 1/4] bpf: " Dmitrii Dolgov
2023-12-11 12:30 ` Jiri Olsa
2023-12-11 18:49 ` Dmitry Dolgov
2023-12-12 9:56 ` Jiri Olsa [this message]
2023-12-08 18:55 ` [PATCH bpf-next v7 2/4] selftests/bpf: Add test for recursive attachment of tracing progs Dmitrii Dolgov
2023-12-11 12:30 ` Jiri Olsa
2023-12-11 19:09 ` Dmitry Dolgov
2023-12-08 18:55 ` [PATCH bpf-next v7 3/4] bpf: Fix re-attachment branch in bpf_tracing_prog_attach Dmitrii Dolgov
2023-12-08 18:55 ` [PATCH bpf-next v7 4/4] selftests/bpf: Test re-attachment fix for bpf_tracing_prog_attach Dmitrii Dolgov
2023-12-11 12:30 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXguT7cQF7d8RuSk@krava \
--to=olsajiri@gmail.com \
--cc=9erthalion6@gmail.com \
--cc=andrii@kernel.org \
--cc=asavkov@redhat.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=daniel@iogearbox.net \
--cc=martin.lau@linux.dev \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.