From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Tue, 12 Dec 2023 07:28:54 -0800 Subject: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() In-Reply-To: References: <20220921003201.1441511-11-seanjc@google.com> <20231207010302.2240506-1-jmattson@google.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sun, Dec 10, 2023, Jim Mattson wrote: > On Thu, Dec 7, 2023 at 8:21?AM Sean Christopherson wrote: > > Doh. We got the less obvious cases and missed the obvious one. > > > > Ugh, and we also missed a related mess in kvm_guest_apic_has_interrupt(). That > > thing should really be folded into vmx_has_nested_events(). > > > > Good gravy. And vmx_interrupt_blocked() does the wrong thing because that > > specifically checks if L1 interrupts are blocked. > > > > Compile tested only, and definitely needs to be chunked into multiple patches, > > but I think something like this mess? > > The proposed patch does not fix the problem. In fact, it messes things > up so much that I don't get any test results back. Drat. > Google has an internal K-U-T test that demonstrates the problem. I > will post it soon. Received, I'll dig in soonish, though "soonish" might unfortunately might mean 2024. From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BkYDT2p7" Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A7741FC8 for ; Tue, 12 Dec 2023 07:28:57 -0800 (PST) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5e1ee53972dso8563027b3.1 for ; Tue, 12 Dec 2023 07:28:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702394936; x=1702999736; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=ESTPXNxaOVzfRXXRx0Fvol8yzry2uxBEEuLKqef2q4U=; b=BkYDT2p7AZjoPKT1n33qcBzraBObsSid1Kav0bwVkxm03TEVNC9zjkvdoIvsP0gO75 moN91EoItYKY7bE8DYrJiANZQGFCmkf5HIebed+p+oequNpXhL+YOR4EpL4dpgIKSQ5Q rdxafRPM1EMvN39DPwz196VoqroHUedjHpsNgY60Ny4L70huLqKg9p0/ZqM3NMyNGdm6 B2u/IQXRbgTONYPciifuv1nD9dRK0KUIoy1No1oaQwluBNg6Ll9BXgX2qVuEIV52N94P uqorvgEZE7Y9ffnxMRIbnnF1PGv2zPAMLd+YB1lWZuWINHkNV+Y+C0LRq892mFgzBrA5 /IwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702394936; x=1702999736; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ESTPXNxaOVzfRXXRx0Fvol8yzry2uxBEEuLKqef2q4U=; b=Yq0x+YeSu447Jv6MxFrwjABpe7STW0rqNuOgnf5gm2q+djMkJOSOetxKh6yIZb3Uxi RFYTL9jzZcWHHvk2FptkVORRKM7humEKC7EGW/YozkbpVprPDY0cQOgHE/au8CA9jk6O qqZ3q8Ifdp2KSW/+ZbJGY4FfBNx9VSh6cYG3ddet1d/CJQERBGUqn4SVfkCrPiqNLC7A EKOdEXXgdTxGdIzBt/xv6C7SJz3CyrOtnti3RfSaqIe7tra7Lk8Lad6Cr1YWG7y2bPeZ vpnkpPOOeunLq1RDHZ2RsDSKyVHjqUkUZmIwLwbjB1iDEyWAm9EjaSLt//dyNu5q+uqP MQTw== X-Gm-Message-State: AOJu0YwlJFF9aarNpeY/4VZcUE8h09YIsG+luckCy4GcBp7QzLzh1CLa lhtkqa66pAfOUO1q+iVC8PXMtjIM7q8= X-Google-Smtp-Source: AGHT+IHBX6jt6VDhWuABWGol0Nx+Ii84S8r8nT9g/gNamSIHnZwQhzhs+bFmpCR2BuKO/hKALNdpvESE74w= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:db94:0:b0:db4:7ac:fea6 with SMTP id g142-20020a25db94000000b00db407acfea6mr41805ybf.7.1702394935890; Tue, 12 Dec 2023 07:28:55 -0800 (PST) Date: Tue, 12 Dec 2023 07:28:54 -0800 In-Reply-To: Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20220921003201.1441511-11-seanjc@google.com> <20231207010302.2240506-1-jmattson@google.com> Message-ID: Subject: Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() From: Sean Christopherson To: Jim Mattson Cc: alexandru.elisei@arm.com, anup@brainfault.org, aou@eecs.berkeley.edu, atishp@atishpatra.org, borntraeger@linux.ibm.com, chenhuacai@kernel.org, david@redhat.com, frankja@linux.ibm.com, imbrenda@linux.ibm.com, james.morse@arm.com, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mlevitsk@redhat.com, oliver.upton@linux.dev, palmer@dabbelt.com, paul.walmsley@sifive.com, pbonzini@redhat.com, suzuki.poulose@arm.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Sun, Dec 10, 2023, Jim Mattson wrote: > On Thu, Dec 7, 2023 at 8:21=E2=80=AFAM Sean Christopherson wrote: > > Doh. We got the less obvious cases and missed the obvious one. > > > > Ugh, and we also missed a related mess in kvm_guest_apic_has_interrupt(= ). That > > thing should really be folded into vmx_has_nested_events(). > > > > Good gravy. And vmx_interrupt_blocked() does the wrong thing because t= hat > > specifically checks if L1 interrupts are blocked. > > > > Compile tested only, and definitely needs to be chunked into multiple p= atches, > > but I think something like this mess? >=20 > The proposed patch does not fix the problem. In fact, it messes things > up so much that I don't get any test results back. Drat. > Google has an internal K-U-T test that demonstrates the problem. I > will post it soon. Received, I'll dig in soonish, though "soonish" might unfortunately might m= ean 2024. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B285C4167B for ; Tue, 12 Dec 2023 15:29:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=hKL6HSunaCmdl292IAn5Owjk/kvRA/eRPgrBoXnw3IU=; b=Shpn0lUsD6LDNa5mStqUla2uww VTugPuKx8Qrle7M5j+zMis5zhiddF1zm4OkbXwr6bPOY5zmUdtpxAj16lCken8V27dvjOf6nXldb6 2r0ay2wYOZGUwcqySeZ1nSoJMqD1TPt31AxfIOfrg3fnrbIdH1t07S6vZDhts+69RiKzb6izDsBWq Z35Db2v6eh+fNPfOLlgs2joFcrMHWlftmTwD9sG9ODwoIEYaA+eLpneE6i9llBLlRkVvixN4BY0QN k5Rfizy7veOHAvc8h4q6udmLOXclby0V1PvA22U76qld7om19iSA/qVv8lXWm326NoTHv1kXAMLTf yy/VVtfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rD4gx-00C4T5-0M; Tue, 12 Dec 2023 15:29:03 +0000 Received: from mail-yb1-xb4a.google.com ([2607:f8b0:4864:20::b4a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rD4gt-00C4Pp-28 for linux-riscv@lists.infradead.org; Tue, 12 Dec 2023 15:29:01 +0000 Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-dbc68661060so3373181276.2 for ; Tue, 12 Dec 2023 07:28:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702394936; x=1702999736; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=ESTPXNxaOVzfRXXRx0Fvol8yzry2uxBEEuLKqef2q4U=; b=Dt/H0yK8unMdVoq1+x9uqmfU8kzDSf2AgFWvcmD/ixGhew/qy0qUsEDobO69gfj6w0 fSzTciy6btyV/No+myo8ggiA8liabWxeoIiLBHMpe0C9PLboil3uVBBBGts+60laPK7S TIlk7MExVsLTCZ5ONl6O9nnp+jmQf2o/UpnZK145WGTdm2ehsto1blSgwNml9qvAk2as VtxjOij0pvFTeKMb+6hKGhpK5Vxc1+HfH1/N3zCSjXcmaCqpd1auWx2bPI2WeqRhQdH/ j7sUZj4WUJkJglDMr5FRyTggZdP891uIc2Vj6B4Tu8nTwZTg8CgxLFI0Y3JU6MeNaGFJ M/Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702394936; x=1702999736; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ESTPXNxaOVzfRXXRx0Fvol8yzry2uxBEEuLKqef2q4U=; b=NGYf4lqvAdIhTa/HsI92fjdMQpTAbRlHNxjCkqogM1BquULjzdUIwwdfhUB/DnfSnW h/lS8T/4kR9eQrF822LnrCkG+dfPKj9m++nYGtodoaUvn0XDS4qOfnC+xBWtMC+gQVN1 u8Rpu1sPkB2aeJWsxIO+omxgNdACmNBlUKpqNtFQttMuw7jsf3Dr/vV6M8L6iUc+nQ40 lj78GZA+KFPnfE+jwtzHN4sA09RG/AMLdniq4cE8f6WflT7GJ7rfsx2/diUuQGcrvDxm qMnb5SEi2yEG21DZtrnqozhKNZLzET0CKrcC7MV+q4uyLwEjqyrwbBmfH+kSv30u1M+J ERiw== X-Gm-Message-State: AOJu0YxHlhofMi9VU8/J+G6UuRYg5JwEk/28/nEwyScTJ3hFImg1n3lb pdNOw4TLVaVdbGQIUcvw7o0oEsXzJiM= X-Google-Smtp-Source: AGHT+IHBX6jt6VDhWuABWGol0Nx+Ii84S8r8nT9g/gNamSIHnZwQhzhs+bFmpCR2BuKO/hKALNdpvESE74w= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:db94:0:b0:db4:7ac:fea6 with SMTP id g142-20020a25db94000000b00db407acfea6mr41805ybf.7.1702394935890; Tue, 12 Dec 2023 07:28:55 -0800 (PST) Date: Tue, 12 Dec 2023 07:28:54 -0800 In-Reply-To: Mime-Version: 1.0 References: <20220921003201.1441511-11-seanjc@google.com> <20231207010302.2240506-1-jmattson@google.com> Message-ID: Subject: Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() From: Sean Christopherson To: Jim Mattson Cc: alexandru.elisei@arm.com, anup@brainfault.org, aou@eecs.berkeley.edu, atishp@atishpatra.org, borntraeger@linux.ibm.com, chenhuacai@kernel.org, david@redhat.com, frankja@linux.ibm.com, imbrenda@linux.ibm.com, james.morse@arm.com, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mlevitsk@redhat.com, oliver.upton@linux.dev, palmer@dabbelt.com, paul.walmsley@sifive.com, pbonzini@redhat.com, suzuki.poulose@arm.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231212_072859_698619_BBEF9938 X-CRM114-Status: GOOD ( 14.20 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gU3VuLCBEZWMgMTAsIDIwMjMsIEppbSBNYXR0c29uIHdyb3RlOgo+IE9uIFRodSwgRGVjIDcs IDIwMjMgYXQgODoyMeKAr0FNIFNlYW4gQ2hyaXN0b3BoZXJzb24gPHNlYW5qY0Bnb29nbGUuY29t PiB3cm90ZToKPiA+IERvaC4gIFdlIGdvdCB0aGUgbGVzcyBvYnZpb3VzIGNhc2VzIGFuZCBtaXNz ZWQgdGhlIG9idmlvdXMgb25lLgo+ID4KPiA+IFVnaCwgYW5kIHdlIGFsc28gbWlzc2VkIGEgcmVs YXRlZCBtZXNzIGluIGt2bV9ndWVzdF9hcGljX2hhc19pbnRlcnJ1cHQoKS4gIFRoYXQKPiA+IHRo aW5nIHNob3VsZCByZWFsbHkgYmUgZm9sZGVkIGludG8gdm14X2hhc19uZXN0ZWRfZXZlbnRzKCku Cj4gPgo+ID4gR29vZCBncmF2eS4gIEFuZCB2bXhfaW50ZXJydXB0X2Jsb2NrZWQoKSBkb2VzIHRo ZSB3cm9uZyB0aGluZyBiZWNhdXNlIHRoYXQKPiA+IHNwZWNpZmljYWxseSBjaGVja3MgaWYgTDEg aW50ZXJydXB0cyBhcmUgYmxvY2tlZC4KPiA+Cj4gPiBDb21waWxlIHRlc3RlZCBvbmx5LCBhbmQg ZGVmaW5pdGVseSBuZWVkcyB0byBiZSBjaHVua2VkIGludG8gbXVsdGlwbGUgcGF0Y2hlcywKPiA+ IGJ1dCBJIHRoaW5rIHNvbWV0aGluZyBsaWtlIHRoaXMgbWVzcz8KPiAKPiBUaGUgcHJvcG9zZWQg cGF0Y2ggZG9lcyBub3QgZml4IHRoZSBwcm9ibGVtLiBJbiBmYWN0LCBpdCBtZXNzZXMgdGhpbmdz Cj4gdXAgc28gbXVjaCB0aGF0IEkgZG9uJ3QgZ2V0IGFueSB0ZXN0IHJlc3VsdHMgYmFjay4KCkRy YXQuCgo+IEdvb2dsZSBoYXMgYW4gaW50ZXJuYWwgSy1VLVQgdGVzdCB0aGF0IGRlbW9uc3RyYXRl cyB0aGUgcHJvYmxlbS4gSQo+IHdpbGwgcG9zdCBpdCBzb29uLgoKUmVjZWl2ZWQsIEknbGwgZGln IGluIHNvb25pc2gsIHRob3VnaCAic29vbmlzaCIgbWlnaHQgdW5mb3J0dW5hdGVseSBtaWdodCBt ZWFuCjIwMjQuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2 Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27432C4332F for ; Tue, 12 Dec 2023 15:29:51 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=K/YBQJSN; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4SqMx946khz3c1w for ; Wed, 13 Dec 2023 02:29:49 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=K/YBQJSN; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com (client-ip=2607:f8b0:4864:20::1149; helo=mail-yw1-x1149.google.com; envelope-from=3n3x4zqykdeqykgtpimuumrk.iusrot03vvi-jk1royzy.u5rghy.uxm@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4SqMwH0Blfz2ytm for ; Wed, 13 Dec 2023 02:29:01 +1100 (AEDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5e1b9b10dc0so13156837b3.2 for ; Tue, 12 Dec 2023 07:29:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702394936; x=1702999736; darn=lists.ozlabs.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=ESTPXNxaOVzfRXXRx0Fvol8yzry2uxBEEuLKqef2q4U=; b=K/YBQJSNUdoEScEmzo3yOC+8yzKhthy590tOqmKlo/4C/5LuRJZ95FFux5GjOuPWTS afszLfW1i6JlhbwT8yGHftc8guETFXYLrEyxLtAsvEJ+24x7X8lpQg7FElwKGrtpyPvY E7GLdsYHP0EyXVDpV4CPtvYWm75NgNiN0s7VUVcW+Eh8MtPKjrmyALh7qYzNCFWpnxIJ 8JGQ9aasswqwCtSv7d0KFoktlDao1xheq1JnfsGBCkY5pR0tfb96b49TmoHG/lxP/sex 62myLqfrAenzxymR0VRd2GLFsu5lxV1r5R17hBwGk15xs1t/DR37hi3axgjQGc0Dfsm3 cOtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702394936; x=1702999736; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ESTPXNxaOVzfRXXRx0Fvol8yzry2uxBEEuLKqef2q4U=; b=nVZLfrbv9Tg9hqXG/N73mWYw1jb5mznpfoUFEkyjo1GQ0rSWYBSSMlaGvkSjwIiBeJ QJuGwL7/deKCzbpfWU01OcFKU9OTbzAa0gfi8D8GcYHn6vJbCb0oAHV/vaArjLl2hqck LRwznIVF9jqNmi3oDQw4AMGRASeo7CMtyYORz/NhNFJJw1tK5E4MAzjQIW93Yo5bkD6x KTl2UADOXwCnvI0Hw9Q0m1+/eFcQbVQr5vYfXe4sY1dGimQ71HjpeiOPTf9p3j3RQUiy U1d4ZCAAWFbvIKNAy9DTF7pHmAzZS+HXuA4rGZpoyBlGOKldAeo/fONmdSFdKVdSwzMr b4bg== X-Gm-Message-State: AOJu0YyaofFvCcGQkpkk/AzQDZZaAkuxbzxJmZgtqJ+owWdHQk80t5E7 vbqEnXBu1/mo7Av4uydOOQikd0Sy/Qo= X-Google-Smtp-Source: AGHT+IHBX6jt6VDhWuABWGol0Nx+Ii84S8r8nT9g/gNamSIHnZwQhzhs+bFmpCR2BuKO/hKALNdpvESE74w= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:db94:0:b0:db4:7ac:fea6 with SMTP id g142-20020a25db94000000b00db407acfea6mr41805ybf.7.1702394935890; Tue, 12 Dec 2023 07:28:55 -0800 (PST) Date: Tue, 12 Dec 2023 07:28:54 -0800 In-Reply-To: Mime-Version: 1.0 References: <20220921003201.1441511-11-seanjc@google.com> <20231207010302.2240506-1-jmattson@google.com> Message-ID: Subject: Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() From: Sean Christopherson To: Jim Mattson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, david@redhat.com, atishp@atishpatra.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, imbrenda@linux.ibm.com, frankja@linux.ibm.com, maz@kernel.org, chenhuacai@kernel.org, mlevitsk@redhat.com, palmer@dabbelt.com, borntraeger@linux.ibm.com, aou@eecs.berkeley.edu, suzuki.poulose@arm.com, paul.walmsley@sifive.com, alexandru.elisei@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, oliver.upton@linux.dev, james.morse@arm.com, kvm-riscv@lists.infradead.org, anup@brainfault.org, pbonzini@redhat.com, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sun, Dec 10, 2023, Jim Mattson wrote: > On Thu, Dec 7, 2023 at 8:21=E2=80=AFAM Sean Christopherson wrote: > > Doh. We got the less obvious cases and missed the obvious one. > > > > Ugh, and we also missed a related mess in kvm_guest_apic_has_interrupt(= ). That > > thing should really be folded into vmx_has_nested_events(). > > > > Good gravy. And vmx_interrupt_blocked() does the wrong thing because t= hat > > specifically checks if L1 interrupts are blocked. > > > > Compile tested only, and definitely needs to be chunked into multiple p= atches, > > but I think something like this mess? >=20 > The proposed patch does not fix the problem. In fact, it messes things > up so much that I don't get any test results back. Drat. > Google has an internal K-U-T test that demonstrates the problem. I > will post it soon. Received, I'll dig in soonish, though "soonish" might unfortunately might m= ean 2024. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AACBC4167D for ; Tue, 12 Dec 2023 15:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=qOT/eyswbmQPXIN3JhbeXUwEeqN+8Qs04df6HTQcX54=; b=0FomtjW0FV377SvfKy34O7z327 mTuZl/qnAXtp1yqtYWKoySBzsvFqaW8ngG/7cpSe8HWEhuKnN2h0wQGB0m20w1US6p/+jZQ3dPQhq JttK7WfbWBifcsf1MwECv25S07gpjpgOlRRuGJ+FkC/+BlDiTg+RCFaIEiW/X3n3bNGTyc4eL21F9 AU5F4R3vmVo3rHw5FBjaY/xHFhhIdTDA1Hte2DOXQhnuhxrzMU5HtFIOvxJYiyopZhKRAdUT+edEU 1XvbS/dl8PFMYLpWFa/e1iK/l12vMGvOcdhhGTOIeei/fMfFLGUUfKvCeBs7QWeRLAmVQwUWaY6Mp DdQ93t6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rD4gz-00C4Ty-0w; Tue, 12 Dec 2023 15:29:05 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rD4gu-00C4Pq-1v for linux-arm-kernel@lists.infradead.org; Tue, 12 Dec 2023 15:29:02 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5e03f0ede64so29461397b3.0 for ; Tue, 12 Dec 2023 07:28:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702394936; x=1702999736; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=ESTPXNxaOVzfRXXRx0Fvol8yzry2uxBEEuLKqef2q4U=; b=Dt/H0yK8unMdVoq1+x9uqmfU8kzDSf2AgFWvcmD/ixGhew/qy0qUsEDobO69gfj6w0 fSzTciy6btyV/No+myo8ggiA8liabWxeoIiLBHMpe0C9PLboil3uVBBBGts+60laPK7S TIlk7MExVsLTCZ5ONl6O9nnp+jmQf2o/UpnZK145WGTdm2ehsto1blSgwNml9qvAk2as VtxjOij0pvFTeKMb+6hKGhpK5Vxc1+HfH1/N3zCSjXcmaCqpd1auWx2bPI2WeqRhQdH/ j7sUZj4WUJkJglDMr5FRyTggZdP891uIc2Vj6B4Tu8nTwZTg8CgxLFI0Y3JU6MeNaGFJ M/Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702394936; x=1702999736; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ESTPXNxaOVzfRXXRx0Fvol8yzry2uxBEEuLKqef2q4U=; b=W0wgE7sUHAG5PN9UUmtae3O4F7/HNLhxIe0I8rZLddNYFQFUL/9I+4jXW5OKVhY/Jd Az8L8F2603v8BolnO9Gmeoadj6Ga2VR3MzvoE1TXGtJKQWVF0Zgk8aRLrWYLxoGD5Cab xXpdMpSu9bcemw2zN4TFSjbOVN/36WG1S1/cODpUmgo+8tWbiLAVbzfNio45ERXvCzS/ GVwjVxT9C/285pt2A+7vGMywMPFzweLZ/7CGzdmUtE9U1lCoRxQlovedCtPOcLyF8m2G a0HKw4oQr9ABY637NvrAz8EW0baX8uSRf9sHb8MaFj0v+w7lHGbch0DLFWbDSEl8Yxsg HDpA== X-Gm-Message-State: AOJu0YwwS8/izctpE1WyZkCQUuk5OJ7O0H9H+ZhHQDqXxhVoft+42+xc jLxAdNrbVF2KcltYXe3+7YJAmYtMbiY= X-Google-Smtp-Source: AGHT+IHBX6jt6VDhWuABWGol0Nx+Ii84S8r8nT9g/gNamSIHnZwQhzhs+bFmpCR2BuKO/hKALNdpvESE74w= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:db94:0:b0:db4:7ac:fea6 with SMTP id g142-20020a25db94000000b00db407acfea6mr41805ybf.7.1702394935890; Tue, 12 Dec 2023 07:28:55 -0800 (PST) Date: Tue, 12 Dec 2023 07:28:54 -0800 In-Reply-To: Mime-Version: 1.0 References: <20220921003201.1441511-11-seanjc@google.com> <20231207010302.2240506-1-jmattson@google.com> Message-ID: Subject: Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() From: Sean Christopherson To: Jim Mattson Cc: alexandru.elisei@arm.com, anup@brainfault.org, aou@eecs.berkeley.edu, atishp@atishpatra.org, borntraeger@linux.ibm.com, chenhuacai@kernel.org, david@redhat.com, frankja@linux.ibm.com, imbrenda@linux.ibm.com, james.morse@arm.com, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mlevitsk@redhat.com, oliver.upton@linux.dev, palmer@dabbelt.com, paul.walmsley@sifive.com, pbonzini@redhat.com, suzuki.poulose@arm.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231212_072900_929131_56D58E10 X-CRM114-Status: GOOD ( 16.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCBEZWMgMTAsIDIwMjMsIEppbSBNYXR0c29uIHdyb3RlOgo+IE9uIFRodSwgRGVjIDcs IDIwMjMgYXQgODoyMeKAr0FNIFNlYW4gQ2hyaXN0b3BoZXJzb24gPHNlYW5qY0Bnb29nbGUuY29t PiB3cm90ZToKPiA+IERvaC4gIFdlIGdvdCB0aGUgbGVzcyBvYnZpb3VzIGNhc2VzIGFuZCBtaXNz ZWQgdGhlIG9idmlvdXMgb25lLgo+ID4KPiA+IFVnaCwgYW5kIHdlIGFsc28gbWlzc2VkIGEgcmVs YXRlZCBtZXNzIGluIGt2bV9ndWVzdF9hcGljX2hhc19pbnRlcnJ1cHQoKS4gIFRoYXQKPiA+IHRo aW5nIHNob3VsZCByZWFsbHkgYmUgZm9sZGVkIGludG8gdm14X2hhc19uZXN0ZWRfZXZlbnRzKCku Cj4gPgo+ID4gR29vZCBncmF2eS4gIEFuZCB2bXhfaW50ZXJydXB0X2Jsb2NrZWQoKSBkb2VzIHRo ZSB3cm9uZyB0aGluZyBiZWNhdXNlIHRoYXQKPiA+IHNwZWNpZmljYWxseSBjaGVja3MgaWYgTDEg aW50ZXJydXB0cyBhcmUgYmxvY2tlZC4KPiA+Cj4gPiBDb21waWxlIHRlc3RlZCBvbmx5LCBhbmQg ZGVmaW5pdGVseSBuZWVkcyB0byBiZSBjaHVua2VkIGludG8gbXVsdGlwbGUgcGF0Y2hlcywKPiA+ IGJ1dCBJIHRoaW5rIHNvbWV0aGluZyBsaWtlIHRoaXMgbWVzcz8KPiAKPiBUaGUgcHJvcG9zZWQg cGF0Y2ggZG9lcyBub3QgZml4IHRoZSBwcm9ibGVtLiBJbiBmYWN0LCBpdCBtZXNzZXMgdGhpbmdz Cj4gdXAgc28gbXVjaCB0aGF0IEkgZG9uJ3QgZ2V0IGFueSB0ZXN0IHJlc3VsdHMgYmFjay4KCkRy YXQuCgo+IEdvb2dsZSBoYXMgYW4gaW50ZXJuYWwgSy1VLVQgdGVzdCB0aGF0IGRlbW9uc3RyYXRl cyB0aGUgcHJvYmxlbS4gSQo+IHdpbGwgcG9zdCBpdCBzb29uLgoKUmVjZWl2ZWQsIEknbGwgZGln IGluIHNvb25pc2gsIHRob3VnaCAic29vbmlzaCIgbWlnaHQgdW5mb3J0dW5hdGVseSBtaWdodCBt ZWFuCjIwMjQuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg==