From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Michael Riesch <michael.riesch@wolfvision.net>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Gerald Loacker <gerald.loacker@wolfvision.net>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 2/3] media: i2c: imx415: Add more clock configurations
Date: Tue, 12 Dec 2023 11:37:37 +0000 [thread overview]
Message-ID: <ZXhGAR2fhEOjHXcJ@kekkonen.localdomain> (raw)
In-Reply-To: <20231205090557.298680-3-alexander.stein@ew.tq-group.com>
Hi Alexander,
On Tue, Dec 05, 2023 at 10:05:56AM +0100, Alexander Stein wrote:
> Complete the list from "INCK Setting" section in IMX415-AAQR-C
> (Rev. E19504, 2019/05/21)
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Could you address these smatch warnings, and run
./scripts/checkpatch.pl --strict --max-line-length=80
on the patches?
drivers/media/i2c/imx415.c:402:30: warning: decimal constant 2376000000 is
between LONG_MAX and ULONG_MAX. For C99 that means long long, C90 compilers are
very likely to produce unsigned long (and a
warning) here
drivers/media/i2c/imx415.c:417:30: warning: decimal constant 2376000000 is
between LONG_MAX and ULONG_MAX. For C99 that means long long, C90 compilers are
very likely to produce unsigned long (and a
warning) here
drivers/media/i2c/imx415.c:432:30: warning: decimal constant 2376000000 is
between LONG_MAX and ULONG_MAX. For C99 that means long long, C90 compilers are
very likely to produce unsigned long (and a
warning) here
--
Sakari Ailus
next prev parent reply other threads:[~2023-12-12 11:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 9:05 [PATCH 0/3] media: imx415: Add more modes Alexander Stein
2023-12-05 9:05 ` [PATCH 1/3] media: i2c: imx415: Convert to new CCI register access helpers Alexander Stein
2023-12-05 19:24 ` kernel test robot
2023-12-07 19:30 ` kernel test robot
2023-12-07 21:02 ` Sakari Ailus
2023-12-05 9:05 ` [PATCH 2/3] media: i2c: imx415: Add more clock configurations Alexander Stein
2023-12-12 11:37 ` Sakari Ailus [this message]
2023-12-12 12:18 ` Alexander Stein
2023-12-12 12:45 ` Sakari Ailus
2023-12-05 9:05 ` [PATCH 3/3] media: i2c: imx415: Add more supported modes Alexander Stein
2023-12-05 10:45 ` Laurent Pinchart
2023-12-05 11:12 ` Alexander Stein
2023-12-05 14:47 ` Gerald Loacker
2023-12-05 14:54 ` Laurent Pinchart
2023-12-06 7:38 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXhGAR2fhEOjHXcJ@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=gerald.loacker@wolfvision.net \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=michael.riesch@wolfvision.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.