From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 01/12] drm/i915: Use struct resource for memory region IO as well
Date: Wed, 13 Dec 2023 02:59:07 +0200 [thread overview]
Message-ID: <ZXkB23jcF-ejG7sx@intel.com> (raw)
In-Reply-To: <20231213004237.20375-2-ville.syrjala@linux.intel.com>
On Wed, Dec 13, 2023 at 02:42:26AM +0200, Ville Syrjala wrote:
> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev_fb.c b/drivers/gpu/drm/i915/display/intel_fbdev_fb.c
> index 717c3a3237c4..1ac05d90b2e8 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbdev_fb.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbdev_fb.c
> @@ -78,7 +78,7 @@ int intel_fbdev_fb_fill_info(struct drm_i915_private *i915, struct fb_info *info
>
> /* Use fbdev's framebuffer from lmem for discrete */
> info->fix.smem_start =
> - (unsigned long)(mem->io_start +
> + (unsigned long)(mem->io.start +
> i915_gem_object_get_dma_address(obj, 0));
Hmm. That looks wrong for MTL actually since dma address is relative
to the start of LMEMBAR but stolen io.start will be LMEMBAR+8MiB (or
just DSMBASE which points to the same place, with the w/a in place).
So we need to subtract mem->region.start from this to get the correct
value.
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2023-12-13 0:59 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 0:42 [PATCH 00/12] drm/i915: (stolen) memory region related fixes Ville Syrjala
2023-12-13 0:42 ` [PATCH 01/12] drm/i915: Use struct resource for memory region IO as well Ville Syrjala
2023-12-13 0:59 ` Ville Syrjälä [this message]
2023-12-13 17:01 ` Ville Syrjälä
2023-12-13 15:52 ` Andrzej Hajda
2023-12-13 16:08 ` Ville Syrjälä
2023-12-13 0:42 ` [PATCH 02/12] drm/i915: Print memory region info during probe Ville Syrjala
2023-12-13 16:05 ` Andrzej Hajda
2023-12-13 16:26 ` Ville Syrjälä
2023-12-13 16:49 ` Ville Syrjälä
2023-12-13 0:42 ` [PATCH 03/12] drm/i915: Remove ad-hoc lmem/stolen debugs Ville Syrjala
2023-12-13 16:06 ` Andrzej Hajda
2023-12-13 0:42 ` [PATCH 04/12] drm/i915: Bypass LMEMBAR/GTTMMADR for MTL stolen memory access Ville Syrjala
2023-12-13 9:09 ` Joonas Lahtinen
2023-12-13 9:30 ` Ville Syrjälä
2023-12-13 20:18 ` Sripada, Radhakrishna
2023-12-14 2:03 ` Ville Syrjälä
2023-12-14 21:06 ` Sripada, Radhakrishna
2023-12-15 10:23 ` Ville Syrjälä
2023-12-13 0:42 ` [PATCH 05/12] drm/i915: Disable the "binder" Ville Syrjala
2023-12-13 0:42 ` [PATCH 06/12] drm/i915: Rename the DSM/GSM registers Ville Syrjala
2023-12-13 0:42 ` [PATCH 07/12] drm/i915: Fix PTE decode during initial plane readout Ville Syrjala
2023-12-13 0:42 ` [PATCH 08/12] drm/i915: Fix region start " Ville Syrjala
2023-12-13 0:42 ` [PATCH 09/12] drm/i915: Fix MTL " Ville Syrjala
2023-12-13 0:42 ` [PATCH 10/12] drm/i915: s/phys_base/dma_addr/ Ville Syrjala
2023-12-13 0:42 ` [PATCH 11/12] drm/i915: Split the smem and lmem plane readout apart Ville Syrjala
2023-12-13 0:42 ` [PATCH 12/12] drm/i915: Simplify intel_initial_plane_config() calling convention Ville Syrjala
2023-12-13 1:22 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: (stolen) memory region related fixes Patchwork
2023-12-13 1:22 ` ✗ Fi.CI.SPARSE: " Patchwork
2023-12-13 1:37 ` ✗ Fi.CI.BAT: failure " Patchwork
2023-12-13 16:13 ` â " Andrzej Hajda
2023-12-13 17:24 ` Tvrtko Ursulin
2023-12-13 17:28 ` Tvrtko Ursulin
2023-12-14 11:06 ` â " Andrzej Hajda
2023-12-14 23:01 ` Ville Syrjälä
2023-12-15 8:23 ` Ville Syrjälä
2023-12-13 4:31 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: (stolen) memory region related fixes (rev2) Patchwork
2023-12-13 4:31 ` ✗ Fi.CI.SPARSE: " Patchwork
2023-12-13 4:49 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXkB23jcF-ejG7sx@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.