From: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
To: Haritha D <Harithamma.D@ibm.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Propose a change in open for passing in the file type.
Date: Wed, 13 Dec 2023 11:17:17 +0700 [thread overview]
Message-ID: <ZXkwTYD9nmPYn9UW@danh.dev> (raw)
In-Reply-To: <E1D54D98-3836-41CA-84B5-32AEAF7642D8@ibm.com>
On 2023-12-12 14:46:04+0000, Haritha D <Harithamma.D@ibm.com> wrote:
> Hi Everyone,
>
> Am working on porting git to z/OS. For reference, the pull request am working on https://github.com/git/git/pull/1537.
>
> On z/OS there is a notion of file tag attributes. Files can be
> tagged as binary, ASCII, UTF8, EBCDIC, etc. z/OS uses these
> attributes to determine if auto-conversion is necessary. It was
> recommended in PR that we add logic directly to xopen . In order for
> me to do this in xopen , I have to pass an extra parameter to xopen
> that specifies the file type.
>
> Ex:
> xopen(output_file, O_CREAT | O_WRONLY | O_TRUNC, 0666);
>
> To :
> xopen(output_file, O_CREAT | O_WRONLY | O_TRUNC, 0666, BINARY);
>
> BINARY: would be an enum value.
Would it work if you always open the file as BINARY? And let's all the
conversion done by git via some configs (core.encoding?)?
--
Danh
next prev parent reply other threads:[~2023-12-13 4:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 14:46 Propose a change in open for passing in the file type Haritha D
2023-12-12 17:29 ` Torsten Bögershausen
2023-12-13 4:17 ` Đoàn Trần Công Danh [this message]
2023-12-16 13:28 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXkwTYD9nmPYn9UW@danh.dev \
--to=congdanhqx@gmail.com \
--cc=Harithamma.D@ibm.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.