From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cHLgaY2e" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D85A12E; Wed, 13 Dec 2023 10:16:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702491393; x=1734027393; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HHpVgwc81Z6qFsooEeCAHjTWxZ9ctdHQjE1DZWDlYOg=; b=cHLgaY2eaUJkt7x2V2pq7Eal+6mdyr79iSNa1A+V6wdbivYreR2ClWyh q3Dhw053/nPs0l/OfYp/lIhtlnu/G7VnrQiVwI/USjlpXV1eLIB40PIvt vhxju7kDATibBogVSb2WkUIVbdL/F3YdpGGHtErDoBXZ/sS1+2CMMp67+ sRWkqUugiz+pD9klZ7Cif1McY8QJLoTYmvtOqICSBSkKJR3A61MoChweV PqABeTu/3aH+F9VYUNQV8SP455/Q3I97Jpv7RPIAe0+PkS2JJ9qevs6HT rpRs4rbyTnBzae4BVtOtjpNmbRy1rPeTLu/7cFtm660brxyLVUuOu3h1O A==; X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="16556040" X-IronPort-AV: E=Sophos;i="6.04,273,1695711600"; d="scan'208";a="16556040" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2023 10:16:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="1105393970" X-IronPort-AV: E=Sophos;i="6.04,273,1695711600"; d="scan'208";a="1105393970" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2023 10:16:30 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rDTmU-00000005bdu-1rty; Wed, 13 Dec 2023 20:16:26 +0200 Date: Wed, 13 Dec 2023 20:16:26 +0200 From: Andy Shevchenko To: Nikita Shubin Cc: Hartley Sweeten , Alexander Sverdlin , Russell King , Sergey Shtylyov , Damien Le Moal , Linus Walleij , Dmitry Torokhov , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH v6 36/40] ata: pata_ep93xx: remove legacy pinctrl use Message-ID: References: <20231212-ep93xx-v6-0-c307b8ac9aa8@maquefel.me> <20231212-ep93xx-v6-36-c307b8ac9aa8@maquefel.me> Precedence: bulk X-Mailing-List: linux-ide@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231212-ep93xx-v6-36-c307b8ac9aa8@maquefel.me> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Dec 12, 2023 at 11:20:53AM +0300, Nikita Shubin wrote: > Drop legacy acquire/release since we are using pinctrl for this now. ... > - if (IS_ERR(drv_data->dma_rx_channel)) { > + if (PTR_ERR_OR_ZERO(drv_data->dma_rx_channel)) { This seems incorrect. > ret = PTR_ERR(drv_data->dma_rx_channel); > return dev_err_probe(dev, ret, "rx DMA setup failed"); return dev_err_probe(...); > } I think you wanted ret = PTR_ERR_OR_ZERO(drv_data->dma_rx_channel); if (ret) return dev_err_probe(dev, ret, "rx DMA setup failed"); ... > drv_data->dma_tx_channel = dma_request_chan(&pdev->dev, "tx"); > - if (IS_ERR(drv_data->dma_tx_channel)) { > + if (PTR_ERR_OR_ZERO(drv_data->dma_tx_channel)) { > ret = PTR_ERR(drv_data->dma_tx_channel); > dev_err_probe(dev, ret, "tx DMA setup failed"); > goto fail_release_rx; Ditto. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 545CBC4332F for ; Wed, 13 Dec 2023 18:17:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Rpd4hpfp+P+51xvg96IlCEsmu3A8Z+0pCvEhcsR5Eew=; b=sc2CYGHpQhCWO0 QuM+zdJq1Y+Q3mzFvC5MDThPuCpb7LXgMt/OmKe0r4ZSXFOX/nwCqO4G2IfFmF/gDwJBS/hUTxs0e e2JAYjuJ0PxXTF/fe89zK3z+xxYTw6+QvcRIZ2zzGaEiBE76b68C/tsooxPXbDFSaEZRGV5lDDYLb UB2L+RuMK+kbPV5w/iOOao+HafV6yUC12zOIzr79aZ+eOkP+4+XIhvsxVtAoTQ1sIY3XFWpxDkz+1 yFRiNSgflSCuTZYyZV1OhfdbgAXOeYa03AmXQRTWdUZLeJOUh2X8kVcW8OYPiyq0NNLiYw/kPwOyB OTEtgpmLEO+9sQQYe2aQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDTmi-00FhUV-0M; Wed, 13 Dec 2023 18:16:40 +0000 Received: from mgamail.intel.com ([192.198.163.7]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDTmf-00FhTq-0x for linux-arm-kernel@lists.infradead.org; Wed, 13 Dec 2023 18:16:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702491397; x=1734027397; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HHpVgwc81Z6qFsooEeCAHjTWxZ9ctdHQjE1DZWDlYOg=; b=aQPA8AIqk1CocO3RUoBRYr1iwoKRiddxonBBCELS7Brpl0ad8Kyl7LoO 9XrTq0u+D/iXL2wSZ3ZtrxJ1SWoRYlHeudxqmHkTQwTVB1QEP8yUBi0/R aJQ+Tvp/9EBPe5Z8+uw3LDngk2muur5VKyHXOzHu+F5HtWqGqFXZy0bnF e1hni/nd34fyDkrubs9c+yYaPqf3OJTlud4RgTs5J7unS9ZcQgQ4wszKk k3fWtq5Vcm6Vm0JbisvPhthZIvomOhe5SxwrjF8btJBRSgsAzeiSFd1x1 WUtvtVBUc+oBIQNxhGZFCcHwcoCjR0xwhClVhwd1VYfMQO7NejzoUiVVu A==; X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="16556038" X-IronPort-AV: E=Sophos;i="6.04,273,1695711600"; d="scan'208";a="16556038" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2023 10:16:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="1105393970" X-IronPort-AV: E=Sophos;i="6.04,273,1695711600"; d="scan'208";a="1105393970" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2023 10:16:30 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rDTmU-00000005bdu-1rty; Wed, 13 Dec 2023 20:16:26 +0200 Date: Wed, 13 Dec 2023 20:16:26 +0200 From: Andy Shevchenko To: Nikita Shubin Cc: Hartley Sweeten , Alexander Sverdlin , Russell King , Sergey Shtylyov , Damien Le Moal , Linus Walleij , Dmitry Torokhov , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH v6 36/40] ata: pata_ep93xx: remove legacy pinctrl use Message-ID: References: <20231212-ep93xx-v6-0-c307b8ac9aa8@maquefel.me> <20231212-ep93xx-v6-36-c307b8ac9aa8@maquefel.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231212-ep93xx-v6-36-c307b8ac9aa8@maquefel.me> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231213_101637_344175_DF90CD2C X-CRM114-Status: GOOD ( 10.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 12, 2023 at 11:20:53AM +0300, Nikita Shubin wrote: > Drop legacy acquire/release since we are using pinctrl for this now. ... > - if (IS_ERR(drv_data->dma_rx_channel)) { > + if (PTR_ERR_OR_ZERO(drv_data->dma_rx_channel)) { This seems incorrect. > ret = PTR_ERR(drv_data->dma_rx_channel); > return dev_err_probe(dev, ret, "rx DMA setup failed"); return dev_err_probe(...); > } I think you wanted ret = PTR_ERR_OR_ZERO(drv_data->dma_rx_channel); if (ret) return dev_err_probe(dev, ret, "rx DMA setup failed"); ... > drv_data->dma_tx_channel = dma_request_chan(&pdev->dev, "tx"); > - if (IS_ERR(drv_data->dma_tx_channel)) { > + if (PTR_ERR_OR_ZERO(drv_data->dma_tx_channel)) { > ret = PTR_ERR(drv_data->dma_tx_channel); > dev_err_probe(dev, ret, "tx DMA setup failed"); > goto fail_release_rx; Ditto. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel