From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="EZywXAp4" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51A6D184; Wed, 13 Dec 2023 10:41:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702492917; x=1734028917; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YngtccBgY9Zef0aGOZCL52WGR+Vqvpk1pqOsy5KFJjs=; b=EZywXAp476EljwD1Gt4rF6bA60kBWvdJNjqknpNqLsrOe639JJ/5OtmP RWqaBjLpc+4m/Pb/Mkrv5tK93H/K1br0B9WVf+gH4q5qvJln8O9rdwyt0 AjdLq7PvsIyhBdnlHph3rIRr1qHzPRLFf/6xWWQaO1NZiaK7rPajdhaf1 vARi+ZcBxR9qDYensg1jvB8g76VasvQESU3sntPWSS/LZYOIM3aNbBsgq ALWqW8Q8odCzYypgPh9m+62kWKqwArO2t8T17Fnjlo/8nFLwR3Nl7gKW1 VhzOUxUZVjqQidfkOZuO83R5F6p6dCRXxOWyATq9CEnnOgB1r7yb3K0aA g==; X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="1824973" X-IronPort-AV: E=Sophos;i="6.04,273,1695711600"; d="scan'208";a="1824973" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2023 10:41:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="897427472" X-IronPort-AV: E=Sophos;i="6.04,273,1695711600"; d="scan'208";a="897427472" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2023 10:41:53 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rDUB3-00000005bxZ-1waF; Wed, 13 Dec 2023 20:41:49 +0200 Date: Wed, 13 Dec 2023 20:41:49 +0200 From: Andy Shevchenko To: Nikita Shubin Cc: Hartley Sweeten , Alexander Sverdlin , Russell King , Dmitry Torokhov , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Linus Walleij , Damien Le Moal , Sergey Shtylyov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH v6 24/40] input: keypad: ep93xx: add DT support for Cirrus EP93xx Message-ID: References: <20231212-ep93xx-v6-0-c307b8ac9aa8@maquefel.me> <20231212-ep93xx-v6-24-c307b8ac9aa8@maquefel.me> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231212-ep93xx-v6-24-c307b8ac9aa8@maquefel.me> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Dec 12, 2023 at 11:20:41AM +0300, Nikita Shubin wrote: > - drop flags, they were not used anyway > - add OF ID match table > - process "autorepeat", "debounce-delay-ms", prescale from device tree > - drop platform data usage and it's header > - keymap goes from device tree now on ... > static void ep93xx_keypad_config(struct ep93xx_keypad *keypad) > { > unsigned int val = 0; > > + val |= ((keypad->debounce << KEY_INIT_DBNC_SHIFT) & KEY_INIT_DBNC_MASK); Since you are touching these lines (see below) you can drop unneeded outer parentheses. > > + val |= ((keypad->prescale << KEY_INIT_PRSCL_SHIFT) & KEY_INIT_PRSCL_MASK); See above. > __raw_writel(val, keypad->mmio_base + KEY_INIT); > } -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53F95C4332F for ; Wed, 13 Dec 2023 18:42:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DTfS7yjxHT9VlCWtRyMEbfgEJXmjZIKoXzC1PvAn0w4=; b=wAlcTOn8/1dqw+ cFgn0s+j7sFRMs9j13jgPxBRYqOku+WFPxWsTbyt8TWumBSb4PYSArQv2v7i1HNJZcYEirqw7sOe3 DieoYpVZ15E1+5NYtEZsM0bHReWtwJTVq6dQDPflphNc56gMLLYhZVuDKCndvlZUz8aTeBA86ZRli bZQek4SHkPNno2vzbwtgPSlJFaMPe72af+NBmrBzzV+Mqh7F/ue5ukj4ZURpIfu7C5gMRLfyanqEA riRlVFXvW94c+YBirWTTldhfTdYe4FvbIth4WN/wDIsW/flsMp4exF+2fELFe6EgiIIgJxc1tqHh5 hYtd4qRIVRtoDNdK+dsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDUBF-00FkVb-0u; Wed, 13 Dec 2023 18:42:01 +0000 Received: from mgamail.intel.com ([192.198.163.11]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDUBC-00FkUw-0c for linux-arm-kernel@lists.infradead.org; Wed, 13 Dec 2023 18:41:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702492918; x=1734028918; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YngtccBgY9Zef0aGOZCL52WGR+Vqvpk1pqOsy5KFJjs=; b=RDhFizs7PL23d5hBeOOsKv5cc5oSkmScInzbVTqk2YvI2zQe220TmhxH kV6iHGFrkkQgmbEnyf2Zq+KVvDmQLHuaT6aiNPrNSTLbb//dSuTw+hk4u O608V9Knw7NKNERf+BoXaZgaxmlLh3B0c1BZnn2kXa3kQlKJ0Z6zCN4JT qU0LvYxDkTFk8sFYQAkinN6qm4dOV/xnHg9iqAhubM0HUT4tfEsHoSB/p I/GDLy2T2H70kRL5K2uM7b5zPOmYXxRJN+eRFFXajhIHdPReXtOl3u7MP iykK6IeyWwEU0Kt7BN5TMuQyjsvw9n7Ui3kdOOKn+zbTCyDNOzE6Yq/BF g==; X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="1824966" X-IronPort-AV: E=Sophos;i="6.04,273,1695711600"; d="scan'208";a="1824966" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2023 10:41:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="897427472" X-IronPort-AV: E=Sophos;i="6.04,273,1695711600"; d="scan'208";a="897427472" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2023 10:41:53 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rDUB3-00000005bxZ-1waF; Wed, 13 Dec 2023 20:41:49 +0200 Date: Wed, 13 Dec 2023 20:41:49 +0200 From: Andy Shevchenko To: Nikita Shubin Cc: Hartley Sweeten , Alexander Sverdlin , Russell King , Dmitry Torokhov , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Linus Walleij , Damien Le Moal , Sergey Shtylyov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH v6 24/40] input: keypad: ep93xx: add DT support for Cirrus EP93xx Message-ID: References: <20231212-ep93xx-v6-0-c307b8ac9aa8@maquefel.me> <20231212-ep93xx-v6-24-c307b8ac9aa8@maquefel.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231212-ep93xx-v6-24-c307b8ac9aa8@maquefel.me> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231213_104158_282701_F9C8548F X-CRM114-Status: GOOD ( 11.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 12, 2023 at 11:20:41AM +0300, Nikita Shubin wrote: > - drop flags, they were not used anyway > - add OF ID match table > - process "autorepeat", "debounce-delay-ms", prescale from device tree > - drop platform data usage and it's header > - keymap goes from device tree now on ... > static void ep93xx_keypad_config(struct ep93xx_keypad *keypad) > { > unsigned int val = 0; > > + val |= ((keypad->debounce << KEY_INIT_DBNC_SHIFT) & KEY_INIT_DBNC_MASK); Since you are touching these lines (see below) you can drop unneeded outer parentheses. > > + val |= ((keypad->prescale << KEY_INIT_PRSCL_SHIFT) & KEY_INIT_PRSCL_MASK); See above. > __raw_writel(val, keypad->mmio_base + KEY_INIT); > } -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel