From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 195242EAF0 for ; Wed, 13 Dec 2023 14:51:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 65AAEC15; Wed, 13 Dec 2023 06:52:09 -0800 (PST) Received: from raptor (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5CAFA3F738; Wed, 13 Dec 2023 06:51:18 -0800 (PST) Date: Wed, 13 Dec 2023 14:51:11 +0000 From: Alexandru Elisei To: Rob Herring Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC v2 11/27] arm64: mte: Reserve tag storage memory Message-ID: References: <20231119165721.9849-1-alexandru.elisei@arm.com> <20231119165721.9849-12-alexandru.elisei@arm.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi, On Wed, Dec 13, 2023 at 08:06:44AM -0600, Rob Herring wrote: > On Wed, Dec 13, 2023 at 7:05 AM Alexandru Elisei > wrote: > > > > Hi Rob, > > > > On Tue, Dec 12, 2023 at 12:44:06PM -0600, Rob Herring wrote: > > > On Tue, Dec 12, 2023 at 10:38 AM Alexandru Elisei > > > wrote: > > > > > > > > Hi Rob, > > > > > > > > Thank you so much for the feedback, I'm not very familiar with device tree, > > > > and any comments are very useful. > > > > > > > > On Mon, Dec 11, 2023 at 11:29:40AM -0600, Rob Herring wrote: > > > > > On Sun, Nov 19, 2023 at 10:59 AM Alexandru Elisei > > > > > wrote: > > > > > > > > > > > > Allow the kernel to get the size and location of the MTE tag storage > > > > > > regions from the DTB. This memory is marked as reserved for now. > > > > > > > > > > > > The DTB node for the tag storage region is defined as: > > > > > > > > > > > > tags0: tag-storage@8f8000000 { > > > > > > compatible = "arm,mte-tag-storage"; > > > > > > reg = <0x08 0xf8000000 0x00 0x4000000>; > > > > > > block-size = <0x1000>; > > > > > > memory = <&memory0>; // Associated tagged memory node > > > > > > }; > > > > > > > > > > I skimmed thru the discussion some. If this memory range is within > > > > > main RAM, then it definitely belongs in /reserved-memory. > > > > > > > > Ok, will do that. > > > > > > > > If you don't mind, why do you say that it definitely belongs in > > > > reserved-memory? I'm not trying to argue otherwise, I'm curious about the > > > > motivation. > > > > > > Simply so that /memory nodes describe all possible memory and > > > /reserved-memory is just adding restrictions. It's also because > > > /reserved-memory is what gets handled early, and we don't need > > > multiple things to handle early. > > > > > > > Tag storage is not DMA and can live anywhere in memory. > > > > > > Then why put it in DT at all? The only reason CMA is there is to set > > > the size. It's not even clear to me we need CMA in DT either. The > > > reasoning long ago was the kernel didn't do a good job of moving and > > > reclaiming contiguous space, but that's supposed to be better now (and > > > most h/w figured out they need IOMMUs). > > > > > > But for tag storage you know the size as it is a function of the > > > memory size, right? After all, you are validating the size is correct. > > > I guess there is still the aspect of whether you want enable MTE or > > > not which could be done in a variety of ways. > > > > Oh, sorry, my bad, I should have been clearer about this. I don't want to > > put it in the DT as a "linux,cma" node. But I want it to be managed by CMA. > > Yes, I understand, but my point remains. Why do you need this in DT? > If the location doesn't matter and you can calculate the size from the > memory size, what else is there to add to the DT? I am afraid there has been a misunderstanding. What do you mean by "location doesn't matter"? At the very least, Linux needs to know the address and size of a memory region to use it. The series is about using the tag storage memory for data. Tag storage cannot be described as a regular memory node because it cannot be tagged (and normal memory can). Then there's the matter of the tag storage block size (explained in this commit message), and also knowing the memory range for which a tag storage region stores the tags. This is explained in the cover letter. Is there something that you feel that is not clear enough? I am more than happy to go into details. Thanks, Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23856C4332F for ; Wed, 13 Dec 2023 14:51:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PkCMqs1FBrb5AxVub+Lte/RIIKM+afyMmYetEuBGK7k=; b=CdJCgDPm4IWDn2 ny8zu45yGEhwDELqVT+nX+Qdo4YzAKzMY0rMj+qKKGKLEGxcX1yjCwPiTFNzkKLFy18II0IrgIgxY yfVL6LeBlSoqFyIQk0U0gowOlM3rpEgrF55EAE/RuqkMx9ry8BZIyjffKk0OvkoPAmakrMzwp3zYB ef19Op+YWr/rr158SEAJsFN2IK9930sUv7avnHCusXZB1acoz1HrRFcVXmUoOu8HWxY16zNwM8LxS 6eSPZOiQblWXYGTz2qDD1UQNrA9VL/yIEsGm/nM0yV7y38yQN76G62rGc/kiXhX2V/hUB4thK0Q6H iJz+8g9W+iAxU46BpgQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDQa7-00F68l-2p; Wed, 13 Dec 2023 14:51:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDQa5-00F67W-1G for linux-arm-kernel@lists.infradead.org; Wed, 13 Dec 2023 14:51:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 65AAEC15; Wed, 13 Dec 2023 06:52:09 -0800 (PST) Received: from raptor (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5CAFA3F738; Wed, 13 Dec 2023 06:51:18 -0800 (PST) Date: Wed, 13 Dec 2023 14:51:11 +0000 From: Alexandru Elisei To: Rob Herring Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC v2 11/27] arm64: mte: Reserve tag storage memory Message-ID: References: <20231119165721.9849-1-alexandru.elisei@arm.com> <20231119165721.9849-12-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231213_065125_541839_7EDF446E X-CRM114-Status: GOOD ( 38.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpPbiBXZWQsIERlYyAxMywgMjAyMyBhdCAwODowNjo0NEFNIC0wNjAwLCBSb2IgSGVycmlu ZyB3cm90ZToKPiBPbiBXZWQsIERlYyAxMywgMjAyMyBhdCA3OjA14oCvQU0gQWxleGFuZHJ1IEVs aXNlaQo+IDxhbGV4YW5kcnUuZWxpc2VpQGFybS5jb20+IHdyb3RlOgo+ID4KPiA+IEhpIFJvYiwK PiA+Cj4gPiBPbiBUdWUsIERlYyAxMiwgMjAyMyBhdCAxMjo0NDowNlBNIC0wNjAwLCBSb2IgSGVy cmluZyB3cm90ZToKPiA+ID4gT24gVHVlLCBEZWMgMTIsIDIwMjMgYXQgMTA6MzjigK9BTSBBbGV4 YW5kcnUgRWxpc2VpCj4gPiA+IDxhbGV4YW5kcnUuZWxpc2VpQGFybS5jb20+IHdyb3RlOgo+ID4g PiA+Cj4gPiA+ID4gSGkgUm9iLAo+ID4gPiA+Cj4gPiA+ID4gVGhhbmsgeW91IHNvIG11Y2ggZm9y IHRoZSBmZWVkYmFjaywgSSdtIG5vdCB2ZXJ5IGZhbWlsaWFyIHdpdGggZGV2aWNlIHRyZWUsCj4g PiA+ID4gYW5kIGFueSBjb21tZW50cyBhcmUgdmVyeSB1c2VmdWwuCj4gPiA+ID4KPiA+ID4gPiBP biBNb24sIERlYyAxMSwgMjAyMyBhdCAxMToyOTo0MEFNIC0wNjAwLCBSb2IgSGVycmluZyB3cm90 ZToKPiA+ID4gPiA+IE9uIFN1biwgTm92IDE5LCAyMDIzIGF0IDEwOjU54oCvQU0gQWxleGFuZHJ1 IEVsaXNlaQo+ID4gPiA+ID4gPGFsZXhhbmRydS5lbGlzZWlAYXJtLmNvbT4gd3JvdGU6Cj4gPiA+ ID4gPiA+Cj4gPiA+ID4gPiA+IEFsbG93IHRoZSBrZXJuZWwgdG8gZ2V0IHRoZSBzaXplIGFuZCBs b2NhdGlvbiBvZiB0aGUgTVRFIHRhZyBzdG9yYWdlCj4gPiA+ID4gPiA+IHJlZ2lvbnMgZnJvbSB0 aGUgRFRCLiBUaGlzIG1lbW9yeSBpcyBtYXJrZWQgYXMgcmVzZXJ2ZWQgZm9yIG5vdy4KPiA+ID4g PiA+ID4KPiA+ID4gPiA+ID4gVGhlIERUQiBub2RlIGZvciB0aGUgdGFnIHN0b3JhZ2UgcmVnaW9u IGlzIGRlZmluZWQgYXM6Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ICAgICAgICAgdGFnczA6IHRh Zy1zdG9yYWdlQDhmODAwMDAwMCB7Cj4gPiA+ID4gPiA+ICAgICAgICAgICAgICAgICBjb21wYXRp YmxlID0gImFybSxtdGUtdGFnLXN0b3JhZ2UiOwo+ID4gPiA+ID4gPiAgICAgICAgICAgICAgICAg cmVnID0gPDB4MDggMHhmODAwMDAwMCAweDAwIDB4NDAwMDAwMD47Cj4gPiA+ID4gPiA+ICAgICAg ICAgICAgICAgICBibG9jay1zaXplID0gPDB4MTAwMD47Cj4gPiA+ID4gPiA+ICAgICAgICAgICAg ICAgICBtZW1vcnkgPSA8Jm1lbW9yeTA+OyAgICAvLyBBc3NvY2lhdGVkIHRhZ2dlZCBtZW1vcnkg bm9kZQo+ID4gPiA+ID4gPiAgICAgICAgIH07Cj4gPiA+ID4gPgo+ID4gPiA+ID4gSSBza2ltbWVk IHRocnUgdGhlIGRpc2N1c3Npb24gc29tZS4gSWYgdGhpcyBtZW1vcnkgcmFuZ2UgaXMgd2l0aGlu Cj4gPiA+ID4gPiBtYWluIFJBTSwgdGhlbiBpdCBkZWZpbml0ZWx5IGJlbG9uZ3MgaW4gL3Jlc2Vy dmVkLW1lbW9yeS4KPiA+ID4gPgo+ID4gPiA+IE9rLCB3aWxsIGRvIHRoYXQuCj4gPiA+ID4KPiA+ ID4gPiBJZiB5b3UgZG9uJ3QgbWluZCwgd2h5IGRvIHlvdSBzYXkgdGhhdCBpdCBkZWZpbml0ZWx5 IGJlbG9uZ3MgaW4KPiA+ID4gPiByZXNlcnZlZC1tZW1vcnk/IEknbSBub3QgdHJ5aW5nIHRvIGFy Z3VlIG90aGVyd2lzZSwgSSdtIGN1cmlvdXMgYWJvdXQgdGhlCj4gPiA+ID4gbW90aXZhdGlvbi4K PiA+ID4KPiA+ID4gU2ltcGx5IHNvIHRoYXQgL21lbW9yeSBub2RlcyBkZXNjcmliZSBhbGwgcG9z c2libGUgbWVtb3J5IGFuZAo+ID4gPiAvcmVzZXJ2ZWQtbWVtb3J5IGlzIGp1c3QgYWRkaW5nIHJl c3RyaWN0aW9ucy4gSXQncyBhbHNvIGJlY2F1c2UKPiA+ID4gL3Jlc2VydmVkLW1lbW9yeSBpcyB3 aGF0IGdldHMgaGFuZGxlZCBlYXJseSwgYW5kIHdlIGRvbid0IG5lZWQKPiA+ID4gbXVsdGlwbGUg dGhpbmdzIHRvIGhhbmRsZSBlYXJseS4KPiA+ID4KPiA+ID4gPiBUYWcgc3RvcmFnZSBpcyBub3Qg RE1BIGFuZCBjYW4gbGl2ZSBhbnl3aGVyZSBpbiBtZW1vcnkuCj4gPiA+Cj4gPiA+IFRoZW4gd2h5 IHB1dCBpdCBpbiBEVCBhdCBhbGw/IFRoZSBvbmx5IHJlYXNvbiBDTUEgaXMgdGhlcmUgaXMgdG8g c2V0Cj4gPiA+IHRoZSBzaXplLiBJdCdzIG5vdCBldmVuIGNsZWFyIHRvIG1lIHdlIG5lZWQgQ01B IGluIERUIGVpdGhlci4gVGhlCj4gPiA+IHJlYXNvbmluZyBsb25nIGFnbyB3YXMgdGhlIGtlcm5l bCBkaWRuJ3QgZG8gYSBnb29kIGpvYiBvZiBtb3ZpbmcgYW5kCj4gPiA+IHJlY2xhaW1pbmcgY29u dGlndW91cyBzcGFjZSwgYnV0IHRoYXQncyBzdXBwb3NlZCB0byBiZSBiZXR0ZXIgbm93IChhbmQK PiA+ID4gbW9zdCBoL3cgZmlndXJlZCBvdXQgdGhleSBuZWVkIElPTU1VcykuCj4gPiA+Cj4gPiA+ IEJ1dCBmb3IgdGFnIHN0b3JhZ2UgeW91IGtub3cgdGhlIHNpemUgYXMgaXQgaXMgYSBmdW5jdGlv biBvZiB0aGUKPiA+ID4gbWVtb3J5IHNpemUsIHJpZ2h0PyBBZnRlciBhbGwsIHlvdSBhcmUgdmFs aWRhdGluZyB0aGUgc2l6ZSBpcyBjb3JyZWN0Lgo+ID4gPiBJIGd1ZXNzIHRoZXJlIGlzIHN0aWxs IHRoZSBhc3BlY3Qgb2Ygd2hldGhlciB5b3Ugd2FudCBlbmFibGUgTVRFIG9yCj4gPiA+IG5vdCB3 aGljaCBjb3VsZCBiZSBkb25lIGluIGEgdmFyaWV0eSBvZiB3YXlzLgo+ID4KPiA+IE9oLCBzb3Jy eSwgbXkgYmFkLCBJIHNob3VsZCBoYXZlIGJlZW4gY2xlYXJlciBhYm91dCB0aGlzLiBJIGRvbid0 IHdhbnQgdG8KPiA+IHB1dCBpdCBpbiB0aGUgRFQgYXMgYSAibGludXgsY21hIiBub2RlLiBCdXQg SSB3YW50IGl0IHRvIGJlIG1hbmFnZWQgYnkgQ01BLgo+IAo+IFllcywgSSB1bmRlcnN0YW5kLCBi dXQgbXkgcG9pbnQgcmVtYWlucy4gV2h5IGRvIHlvdSBuZWVkIHRoaXMgaW4gRFQ/Cj4gSWYgdGhl IGxvY2F0aW9uIGRvZXNuJ3QgbWF0dGVyIGFuZCB5b3UgY2FuIGNhbGN1bGF0ZSB0aGUgc2l6ZSBm cm9tIHRoZQo+IG1lbW9yeSBzaXplLCB3aGF0IGVsc2UgaXMgdGhlcmUgdG8gYWRkIHRvIHRoZSBE VD8KCkkgYW0gYWZyYWlkIHRoZXJlIGhhcyBiZWVuIGEgbWlzdW5kZXJzdGFuZGluZy4gV2hhdCBk byB5b3UgbWVhbiBieQoibG9jYXRpb24gZG9lc24ndCBtYXR0ZXIiPwoKQXQgdGhlIHZlcnkgbGVh c3QsIExpbnV4IG5lZWRzIHRvIGtub3cgdGhlIGFkZHJlc3MgYW5kIHNpemUgb2YgYSBtZW1vcnkK cmVnaW9uIHRvIHVzZSBpdC4gVGhlIHNlcmllcyBpcyBhYm91dCB1c2luZyB0aGUgdGFnIHN0b3Jh Z2UgbWVtb3J5IGZvcgpkYXRhLiBUYWcgc3RvcmFnZSBjYW5ub3QgYmUgZGVzY3JpYmVkIGFzIGEg cmVndWxhciBtZW1vcnkgbm9kZSBiZWNhdXNlIGl0CmNhbm5vdCBiZSB0YWdnZWQgKGFuZCBub3Jt YWwgbWVtb3J5IGNhbikuCgpUaGVuIHRoZXJlJ3MgdGhlIG1hdHRlciBvZiB0aGUgdGFnIHN0b3Jh Z2UgYmxvY2sgc2l6ZSAoZXhwbGFpbmVkIGluIHRoaXMKY29tbWl0IG1lc3NhZ2UpLCBhbmQgYWxz byBrbm93aW5nIHRoZSBtZW1vcnkgcmFuZ2UgZm9yIHdoaWNoIGEgdGFnIHN0b3JhZ2UKcmVnaW9u IHN0b3JlcyB0aGUgdGFncy4gVGhpcyBpcyBleHBsYWluZWQgaW4gdGhlIGNvdmVyIGxldHRlci4K CklzIHRoZXJlIHNvbWV0aGluZyB0aGF0IHlvdSBmZWVsIHRoYXQgaXMgbm90IGNsZWFyIGVub3Vn aD8gSSBhbSBtb3JlIHRoYW4KaGFwcHkgdG8gZ28gaW50byBkZXRhaWxzLgoKVGhhbmtzLApBbGV4 CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg==