From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="UrJ4npHw" Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3751CF4 for ; Wed, 13 Dec 2023 18:16:06 -0800 (PST) Received: by mail-ot1-x332.google.com with SMTP id 46e09a7af769-6d9d84019c5so5786297a34.3 for ; Wed, 13 Dec 2023 18:16:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1702520165; x=1703124965; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bKy6ddO4gp01JzNWFRSzHBN4v96Bqr/tTFeo7yrpzxk=; b=UrJ4npHwWRlC610HPjAmSCPszbaCncbJXSma8gln3xbQGnEAgDr/p3bg4m5qe/yviY Z0OXZzzIB9wKjYuHJ2xUONKz+QSdS0gAOHCMucko6k7oG18S3n5SvNNy7+hEBGsjRUva EUUca/7NFxSZ+koeP50MFZOd/Myzo7FtKUb3U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702520165; x=1703124965; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bKy6ddO4gp01JzNWFRSzHBN4v96Bqr/tTFeo7yrpzxk=; b=fgBocaf+LYOSbW6vWuxXWkwVPOVWGB9Tvp4nSRxs42MBzJ17RTh2Ucj4poH5iQOWt/ J64iS4lBnsgH78d271dmb/SctqYM6KWVTDF6J3m1XZdtw/TPiH8vjScn4hNOgV3cIWOJ NP/bM6RwBH43no1/q5xvFUX4Vj4P0yO5zZi2uu2w2vlBiT7Wo+kN87Wc0hsFNDWrUkf+ dOclpsWvizWy5+2pu5ormd2K9o677sMwbIU/9j4urhl5CxHEOV0sbnw21SDMmClewlWj StJDxLTbkhS3q2kgHFB7+YIohR5kmOrkwvNIcJOYyr7JHMiy6INHwmyCLlxUfO8flTSW OS2A== X-Gm-Message-State: AOJu0YxcUByhhA1MD2Nx7Q/pVVAFvNAkuSHYaNLGW7GcqdSUe1AvVc+O GKUUJ8TMRGu2pUa7iji9Pe1WZQ== X-Google-Smtp-Source: AGHT+IE20mauZNNkNMzNEKcWHs0secflReTu1AcUqWIB9Y68lbxPSRlPLpUckUArm98zZ6LW+CAc7A== X-Received: by 2002:a05:6830:2b23:b0:6da:314c:475c with SMTP id l35-20020a0568302b2300b006da314c475cmr3485807otv.12.1702520165579; Wed, 13 Dec 2023 18:16:05 -0800 (PST) Received: from localhost ([2620:15c:9d:2:17f:673b:ab18:3603]) by smtp.gmail.com with UTF8SMTPSA id x7-20020a056a00188700b006cdda10bdafsm10645660pfh.183.2023.12.13.18.16.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Dec 2023 18:16:04 -0800 (PST) Date: Wed, 13 Dec 2023 18:16:03 -0800 From: Brian Norris To: David Lin Cc: Francesco Dolcini , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kvalo@kernel.org" , Pete Hsieh Subject: Re: [EXT] Re: [PATCH v7 04/12] wifi: mwifiex: fixed missing WMM IE for assoc req. Message-ID: References: <20231128083115.613235-1-yu-hao.lin@nxp.com> <20231128083115.613235-5-yu-hao.lin@nxp.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Dec 01, 2023 at 10:47:41PM +0000, David Lin wrote: > > From: Francesco Dolcini > > Sent: Friday, December 1, 2023 6:19 PM > > On Tue, Nov 28, 2023 at 04:31:07PM +0800, David Lin wrote: > > > Remain on channel must be removed after authentication is done. > > > Otherwise WMM setting for assoiation request will be removed. > > > > Same comment as patch 2, this seems a fixup of commit 1, you should fix > > that patch, not add a followup fixup commit. > > So you think patch 1 to 4 should be merged as a single patch? In fact, > patch 2 to 4 is issues reported by our QA for patch 1. If you insisted > merge all of them, I can do this for patch v8. In case you didn't get a sufficient answer elsewhere: yes, probably? We don't care to see: patch 1: introduce feature patch 2: fix bug in patch 1 patch 3: fix bug in patch 1 and 2 patch 4: ... Just ... actually fix patch 1, and send 1 patch. (Or more, if you have several logical changes. Be sure to read [1].) In case you're used to GitHub: we don't work like GitHub, where people tend to stack a bunch of incremental changes during review, and then the changes get squashed together before committing. We expect each patch to be a good commit, and that it will get committed as-is. If we're interested in the history and evolution of your changes, we can look at the mailing list archives. Brian [1] https://docs.kernel.org/process/submitting-patches.html#separate-your-changes