All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Rob Clark <robdclark@gmail.com>
Cc: linux-arm-msm@vger.kernel.org, Rob Clark <robdclark@chromium.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] soc: qcom: pmic_glink: Fix boot when QRTR=m
Date: Thu, 14 Dec 2023 17:08:44 +0100	[thread overview]
Message-ID: <ZXsojADuspUVLbIn@hovoldconsulting.com> (raw)
In-Reply-To: <ZXshe83quTE0jO_Z@hovoldconsulting.com>

On Thu, Dec 14, 2023 at 04:38:35PM +0100, Johan Hovold wrote:

> I took a closer look at this and indeed we do have code that triggers a
> reprobe of a device in case there was a successful probe while the
> device was probing.
> 
> This was introduced by commit 58b116bce136 ("drivercore: deferral race
> condition fix") and the workaround for the reprobe-loop bug that hack
> led to is to not return -EPROBE_DEFER after registering child devices as
> no one managed to come up with a proper fix. This was documented here:
> 
> 	fbc35b45f9f6 ("Add documentation on meaning of -EPROBE_DEFER")
> 
> But please spell this out in some more detail in the commit message, and
> add a Fixes and CC stable tag.

And please update the commit summary as I've been booting with QRTR=m
all along just fine. I guess the issue is if you have pmic_glink
built-in or in the initramfs but forgot to include qrtr or similar?

Johan

  reply	other threads:[~2023-12-14 16:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-13 21:06 [PATCH] soc: qcom: pmic_glink: Fix boot when QRTR=m Rob Clark
2023-12-14  7:16 ` Johan Hovold
2023-12-14 11:04   ` Dmitry Baryshkov
2023-12-14 14:01     ` Johan Hovold
2023-12-14 14:04       ` Dmitry Baryshkov
2023-12-14 14:09         ` Johan Hovold
2023-12-14 15:38           ` Johan Hovold
2023-12-14 16:08             ` Johan Hovold [this message]
2023-12-14 20:44               ` Rob Clark
2023-12-15  7:50                 ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZXsojADuspUVLbIn@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@chromium.org \
    --cc=robdclark@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.