From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Vladimir Oltean <olteanv@gmail.com>,
David Epping <david.epping@missinglinkelectronics.com>,
Harini Katakam <harini.katakam@amd.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH v7 1/4] net: phy: make addr type u8 in phy_package_shared struct
Date: Thu, 14 Dec 2023 16:56:47 +0000 [thread overview]
Message-ID: <ZXszz/U/jOAL5MLe@shell.armlinux.org.uk> (raw)
In-Reply-To: <20231214121026.4340-2-ansuelsmth@gmail.com>
On Thu, Dec 14, 2023 at 01:10:23PM +0100, Christian Marangi wrote:
> Switch addr type in phy_package_shared struct to u8.
>
> The value is already checked to be non negative and to be less than
> PHY_MAX_ADDR, hence u8 is better suited than using int.
>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-12-14 16:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 12:10 [net-next PATCH v7 0/4] net: phy: add PHY package base addr + mmd APIs Christian Marangi
2023-12-14 12:10 ` [net-next PATCH v7 1/4] net: phy: make addr type u8 in phy_package_shared struct Christian Marangi
2023-12-14 16:56 ` Russell King (Oracle) [this message]
2023-12-14 12:10 ` [net-next PATCH v7 2/4] net: phy: extend PHY package API to support multiple global address Christian Marangi
2023-12-14 17:05 ` Russell King (Oracle)
2023-12-14 16:54 ` Christian Marangi
2023-12-14 23:54 ` Russell King (Oracle)
2023-12-14 17:29 ` Christian Marangi
2023-12-15 9:16 ` Russell King (Oracle)
2023-12-14 12:10 ` [net-next PATCH v7 3/4] net: phy: restructure __phy_write/read_mmd to helper and phydev user Christian Marangi
2023-12-14 12:10 ` [net-next PATCH v7 4/4] net: phy: add support for PHY package MMD read/write Christian Marangi
2023-12-14 17:06 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXszz/U/jOAL5MLe@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=david.epping@missinglinkelectronics.com \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=harini.katakam@amd.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.