All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: linux-renesas-soc@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] i2c: rcar: add FastMode+ support for Gen4
Date: Fri, 15 Dec 2023 03:10:28 +0100	[thread overview]
Message-ID: <ZXu1lMgg8dc40PVC@shikoro> (raw)
In-Reply-To: <20231214205449.x7bbu7i7m52ihibz@zenone.zhora.eu>

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

Hi Andi,

> as we were here we could have written the register values as
> 0x%x, but it's also OK to keep the change with a minimal impact.

I think it is OK like it is because the datasheet also uses decimal
values in the formulas.

> Reviewed-by: Andi Shyti <andi.shyti@kernel.org>

Thanks!

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2023-12-15  2:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-14  7:43 [PATCH v2 0/2] i2c: rcar: add support for Gen4 devices Wolfram Sang
2023-12-14  7:43 ` [PATCH v2 1/2] i2c: rcar: introduce " Wolfram Sang
2023-12-14  8:03   ` Geert Uytterhoeven
2023-12-14 20:47   ` Andi Shyti
2023-12-14  7:43 ` [PATCH v2 2/2] i2c: rcar: add FastMode+ support for Gen4 Wolfram Sang
2023-12-14  8:19   ` Geert Uytterhoeven
2023-12-14 20:54   ` Andi Shyti
2023-12-15  2:10     ` Wolfram Sang [this message]
2023-12-19 12:42 ` [PATCH v2 0/2] i2c: rcar: add support for Gen4 devices Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZXu1lMgg8dc40PVC@shikoro \
    --to=wsa+renesas@sang-engineering.com \
    --cc=andi.shyti@kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.