Re: [PATCH 4/4] target: Restrict 'sysemu/reset.h' to system emulation

[Zhao Liu <zhao1.liu@intel.com>]

On Tue, Dec 12, 2023 at 12:36:40PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Tue, 12 Dec 2023 12:36:40 +0100
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> Subject: [PATCH 4/4] target: Restrict 'sysemu/reset.h' to system emulation
> X-Mailer: git-send-email 2.41.0
> 
> vCPU "reset" is only possible with system emulation.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Warner Losh <imp@bsdimp.com>
> Reviewed-by: Song Gao <gaosong@loongson.cn>
> ---

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

>  target/i386/cpu.c      | 2 +-
>  target/loongarch/cpu.c | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index dfb96217ad..17b6962d43 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -24,7 +24,6 @@
>  #include "qemu/hw-version.h"
>  #include "cpu.h"
>  #include "tcg/helper-tcg.h"
> -#include "sysemu/reset.h"
>  #include "sysemu/hvf.h"
>  #include "hvf/hvf-i386.h"
>  #include "kvm/kvm_i386.h"
> @@ -37,6 +36,7 @@
>  #include "hw/qdev-properties.h"
>  #include "hw/i386/topology.h"
>  #ifndef CONFIG_USER_ONLY
> +#include "sysemu/reset.h"
>  #include "qapi/qapi-commands-machine-target.h"
>  #include "exec/address-spaces.h"
>  #include "hw/boards.h"
> diff --git a/target/loongarch/cpu.c b/target/loongarch/cpu.c
> index fc075952e6..b26187dfde 100644
> --- a/target/loongarch/cpu.c
> +++ b/target/loongarch/cpu.c
> @@ -17,7 +17,9 @@
>  #include "internals.h"
>  #include "fpu/softfloat-helpers.h"
>  #include "cpu-csr.h"
> +#ifndef CONFIG_USER_ONLY
>  #include "sysemu/reset.h"
> +#endif
>  #include "tcg/tcg.h"
>  #include "vec.h"
>  
> -- 
> 2.41.0
> 
>