From: Andy Shevchenko <andy@kernel.org>
To: tanzirh@google.com
Cc: Kees Cook <keescook@chromium.org>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
Nick DeSaulniers <nnn@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
llvm@lists.linux.dev, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v2 1/2] sh: Added kernel.h to word-at-a-time
Date: Fri, 15 Dec 2023 18:04:31 +0200 [thread overview]
Message-ID: <ZXx5DyidpHFhRevy@smile.fi.intel.com> (raw)
In-Reply-To: <20231214-libstringheader-v2-1-0f195dcff204@google.com>
On Thu, Dec 14, 2023 at 09:06:12PM +0000, tanzirh@google.com wrote:
> This patch includes linux/kernel.h in asm/word-at-a-time.h for the
> sh architecture. WORD_AT_A_TIME_CONSTANTS depends on kernel.h.
> Making this implicit dependancy explicit allows for later improvements
> in the lib/string.c inclusion list.
>
> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
You forgot your SoB, but...
...
> #ifdef CONFIG_CPU_BIG_ENDIAN
> # include <asm-generic/word-at-a-time.h>
> #else
> +#include <linux/kernel.h>
I highly discourage from doing that. Instead, split what is needed to
the separate (new) header and include that one.
> /*
> * Little-endian version cribbed from x86.
> */
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-15 16:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 21:06 [PATCH v2 0/2] shrink lib/string.i via IWYU tanzirh
2023-12-14 21:06 ` [PATCH v2 1/2] sh: Added kernel.h to word-at-a-time tanzirh
2023-12-14 21:37 ` Kees Cook
2023-12-14 21:51 ` Nick Desaulniers
2023-12-15 16:04 ` Andy Shevchenko [this message]
[not found] ` <CAE-cH4p5VJ_A91BAkURBN67ACA0_u7T8UhApUYLQDWeeRY6FWA@mail.gmail.com>
2023-12-15 19:09 ` Andy Shevchenko
2023-12-18 16:57 ` Nick Desaulniers
2023-12-18 17:05 ` Tanzir Hasan
2023-12-18 17:25 ` Andy Shevchenko
2023-12-18 17:23 ` Andy Shevchenko
2023-12-14 21:06 ` [PATCH v2 2/2] lib/string: shrink lib/string.i via IWYU tanzirh
2023-12-14 21:39 ` Kees Cook
2023-12-15 16:08 ` Andy Shevchenko
2024-01-09 21:49 ` Justin Stitt
2024-01-11 0:07 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXx5DyidpHFhRevy@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nnn@google.com \
--cc=tanzirh@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.