From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68610C46CA2 for ; Fri, 15 Dec 2023 12:30:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id E66E681B48; Fri, 15 Dec 2023 12:30:39 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org E66E681B48 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1702643439; bh=OmhxCHCOjZpewjboOI3Jy98iQdI9gp1AzO0zc9odrQ8=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=MPnFKdQhp/ATJJ2kBB6/lM0uvyjswS3ZyAifg6pIMUnh6bVyFIxJRHypP0OVuLYQc uTTDHGIYCrKqeyETFPJUPRbmAjI06p378G/VktygPR/6VC7rUOUuL4uc7b9/c4Ru9U nhCgn5XWJVP0I4FEVTNQb5BYoGtGbl3wU3SqxvnAe7gaZwI4IedP/F9mJirOKNJfxC N3BKzlaa19xf5h0jfeWmavN92X0Y9j+kRyjaHEp9KlwehZ7xS6l+BFv9CqxEEvsjuX X+U/GTTIkRQIan2+qPoTEa1BGXSrf3yRe7LG43/YuMqBUeBViAYcguwnIp6zzB8YZ6 fekc/aBmhcqYQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id co4-ytfihJhB; Fri, 15 Dec 2023 12:30:39 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id E0DE1818D0; Fri, 15 Dec 2023 12:30:38 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org E0DE1818D0 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 179411BF338 for ; Fri, 15 Dec 2023 12:30:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id F0D5A81846 for ; Fri, 15 Dec 2023 12:30:37 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org F0D5A81846 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fLRkg_4aNB0L for ; Fri, 15 Dec 2023 12:30:37 +0000 (UTC) Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by smtp1.osuosl.org (Postfix) with ESMTPS id C95948177A for ; Fri, 15 Dec 2023 12:30:36 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C95948177A Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-336445a2749so419131f8f.0 for ; Fri, 15 Dec 2023 04:30:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702643435; x=1703248235; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qS1FGYqQUVgg6kmNF1jX+vnsM7iLoRSHDDPBhaHTk2c=; b=RgF+Y1Thfe1xiVPwrjK3r1HRE+viwsuMeO+EftePnNmwMwfM9l2HVPMtfyEw6xm0F2 QFr/5824a6LqgZaUv8oTRgfPILPv68UsKT5q/3VHo1tlKSHSdfl/+eVHQ8XYmEzQVzEg Z2+xSZVEUaibhlKnt6qjFo7E9PqQ76xEZyDaF/iZVbMwMosrWZiEr4/4GGX1qr65XcmN ii726RfLQiEalEn4OR/1kyzK4P46z0GW4pTTTVZCr2GtpwwfvZefj22VBX/J5X9rQrKP Z5ZQqfEz7YfG4tNmO78SNqCTXSbc5ZnBFW7ZQ6Gk/bUSgCC+r0UTKTjFU7tR/MFwND6d HYFQ== X-Gm-Message-State: AOJu0Yy4Bglp7HVocpKViDdKqysNk6v1H0zlqAJhZufLXrRKSjCYEf/P a+YdCaSP8bg7ZBxChzhkK9qhEw== X-Google-Smtp-Source: AGHT+IFlj4q60v6pJqLAyyHxPTjQFrEhx3e7Vy7nAJ7PJz1rp7p1y8vJEgxT2DqM6935BHDDhsMGTA== X-Received: by 2002:a5d:5309:0:b0:336:3ac4:b8ba with SMTP id e9-20020a5d5309000000b003363ac4b8bamr2290149wrv.60.1702643434740; Fri, 15 Dec 2023 04:30:34 -0800 (PST) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id s15-20020a5d69cf000000b0033641783aeesm6487430wrw.7.2023.12.15.04.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 04:30:34 -0800 (PST) Date: Fri, 15 Dec 2023 13:30:32 +0100 From: Jiri Pirko To: Paolo Abeni Message-ID: References: <5aed9b87-28f8-f0b0-67c4-346e1d8f762c@intel.com> <20231118084843.70c344d9@kernel.org> <3d60fabf-7edf-47a2-9b95-29b0d9b9e236@intel.com> <20231122192201.245a0797@kernel.org> <20231127174329.6dffea07@kernel.org> <55e51b97c29894ebe61184ab94f7e3d8486e083a.camel@redhat.com> <20231214174604.1ca4c30d@kernel.org> <7b0c2e0132b71b131fc9a5407abd27bc0be700ee.camel@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7b0c2e0132b71b131fc9a5407abd27bc0be700ee.camel@redhat.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1702643435; x=1703248235; darn=lists.osuosl.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=qS1FGYqQUVgg6kmNF1jX+vnsM7iLoRSHDDPBhaHTk2c=; b=XG+IjmzG+sRUQctHym0rqoxhOTjeb7Rxmte2sHdLhgSIiRKgqyKsPsx7rQOtG6vMpD C0G7eDM4um74oE07hPIWjCYkzQTOEhVIlUz65O2Q/PkUg/6NXMDRWyuV+FnVuFrC4tD8 IdJKj9sYuIXqlnnj6NlJoRwagjo2aJJVq1uKzeRYeTNSyt51doNAa169iSxBBh1dPQph 52ZAXQnwnHFs95WtQzsDAmkYGoAdkK7Zu0tlnBbSaRYt3Z0SwD7q99PpdkwRsg9JFYu8 0/hS3ioG4FHHaUSy3RjSGS/yg9XYQ9KlDG2iGuj94htSkFawiIcKw6jdkRwBAcLuwKjj dXog== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=XG+IjmzG Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 0/5] iavf: Add devlink and devlink rate support' X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Samudrala, Sridhar" , netdev@vger.kernel.org, maxtram95@gmail.com, Simon Horman , anthony.l.nguyen@intel.com, "Chittim, Madhu" , intel-wired-lan@lists.osuosl.org, qi.z.zhang@intel.com, Jakub Kicinski , Wenjun Wu Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" RnJpLCBEZWMgMTUsIDIwMjMgYXQgMTI6MDY6NTJQTSBDRVQsIHBhYmVuaUByZWRoYXQuY29tIHdy b3RlOgo+T24gVGh1LCAyMDIzLTEyLTE0IGF0IDE3OjQ2IC0wODAwLCBKYWt1YiBLaWNpbnNraSB3 cm90ZToKPj4gT24gVGh1LCAxNCBEZWMgMjAyMyAyMToyOTo1MSArMDEwMCBQYW9sbyBBYmVuaSB3 cm90ZToKPj4gPiBUb2dldGhlciB3aXRoIFNpbW9uLCBJIHNwZW50IHNvbWUgdGltZSBvbiB0aGUg YWJvdmUuIFdlIHRoaW5rIHRoZQo+PiA+IG5kb19zZXR1cF90YyhUQ19TRVRVUF9RRElTQ19UQkYp IGhvb2sgY291bGQgYmUgdXNlZCBhcyBjb21tb24gYmFzaXMgZm9yCj4+ID4gdGhpcyBvZmZsb2Fk cywgd2l0aCBzb21lIHNtYWxsIGV4dGVuc2lvbnMgKGFkZGluZyBhICdtYXhfcmF0ZScgcGFyYW0s Cj4+ID4gdG9vKS4KPj4gCj4+IHVBUEkgYXNpZGUsIHdoeSB3b3VsZCB3ZSB1c2UgbmRvX3NldHVw X3RjKFRDX1NFVFVQX1FESVNDX1RCRikKPj4gdG8gaW1wbGVtZW50IGNvbW1vbiBiYXNpcz8KPj4g Cj4+IElzIGl0IG5vdCBjbGVhbmVyIHRvIGhhdmUgYSBzZXBhcmF0ZSBkcml2ZXIgQVBJLCB3aXRo IGl0cyBvcHMKPj4gYW5kIGNhcGFiaWxpdGllcz8KPgo+V2UgdW5kZXJzdGFuZCBvbmUgb2YgdGhl IGVuZCBnb2FsIGlzIGNvbnNvbGlkYXRpbmcgdGhlIGV4aXN0aW5nIHJhdGUtCj5yZWxhdGVkIGlu IGtlcm5lbCBpbnRlcmZhY2VzLiAgQWRkaW5nIGEgbmV3IG9uZSBkb2VzIG5vdCBmZWVsIGEgZ29v ZAo+c3RhcnRpbmcgdG8gcmVhY2ggdGhhdCBnb2FsLCBzZWUgWzFdICYgWzJdIDspLiBuZG9fc2V0 dXBfdGMoKSBmZWVscwo+bGlrZSB0aGUgbmF0dXJhbCBjaG9pY2UgZm9yIEgvVyBvZmZsb2FkIGFu ZCBUQkYgaXMgdGhlIGV4aXN0aW5nCj5pbnRlcmZhY2UgSU1ITyBuZWFyZXN0IHRvIHRoZSByZXF1 aXJlbWVudHMgaGVyZS4KPgo+VGhlIGRldmxpbmsgcmF0ZSBBUEkgY291bGQgYmUgYSBwb3NzaWJs ZSBhbHRlcm5hdGl2ZS4uLgoKQWdhaW4sIGRldmxpbmsgcmF0ZSB3YXMgaW50cm9kdWNlZCBmb3Ig dGhlIHJhdGUgY29uZmlndXJhdGlvbiBvZiB0aGUKZW50aXR5IHRoYXQgaXMgbm90IHByZXNlbnQg KGJ5IG5ldGRldiBmb3IgZXhhbXBsZSkgb24gYSBob3N0LgpJZiB3ZSBoYXZlIG5ldGRldiwgbGV0 J3MgdXNlIGl0LgoKCj4KPj4gPiBUaGUgaWRlYSB3b3VsZCBiZToKPj4gPiAtICdmaXhpbmcnIHNj aF9idGYgc28gdGhhdCB0aGUgcy93IHBhdGggYmVjYW1lIGEgbm8tb3Agd2hlbiBoL3cgb2ZmbG9h ZAo+PiA+IGlzIGVuYWJsZWQKPj4gPiAtIGV4dGVuZCBzY2hfYnRmIHRvIHN1cHBvcnQgbWF4IHJh dGUKPj4gPiAtIGRvIHRoZSByZWxldmFudCBpY2UgaW1wbGVtZW50YXRpb24KPj4gPiAtIG5kb19z ZXRfdHhfbWF4cmF0ZSBjb3VsZCBiZSByZXBsYWNlZCB3aXRoIHRoZSBtZW50aW9uZWQgbmRvIGNh bGwgKHRoZQo+PiA+IGxhdHRlciBpbnRlcmZhY2UgaXMgYSBzdHJpY3Qgc3VwZXItc2V0IG9mIGZv cm1lcikKPj4gPiAtIG5kb19zZXRfdmZfcmF0ZSBjb3VsZCBhbHNvIGJlIHJlcGxhY2VkIHdpdGgg dGhlIG1lbnRpb25lZCBuZG8gY2FsbAo+PiA+ICh3aXRoIGFub3RoZXIgc21hbGwgZXh0ZW5zaW9u IHRvIHRoZSBvZmZsb2FkIGRhdGEpCj4+ID4gCj4+ID4gSSB0aGluayBtcXByaW8gZGVzZXJ2ZXMg aXQncyBvd24gc2VwYXJhdGUgb2ZmbG9hZCBpbnRlcmZhY2UsIGFzIGl0Cj4+ID4gY292ZXJzIG11 bHRpcGxlIHRhc2tzIG90aGVyIHRoYW4gc2hhcGluZyAoZ3JvdXBpbmcgcXVldWVzIGFuZCBtYXBw aW5nCj4+ID4gcHJpb3JpdHkgdG8gY2xhc3NlcykKPj4gPiAKPj4gPiBJbiB0aGUgbG9uZyBydW4g d2UgY291bGQgaGF2ZSBhIGdlbmVyaWMgaW1wbGVtZW50YXRpb24gb2YgdGhlCj4+ID4gbmRvX3Nl dHVwX3RjKFRDX1NFVFVQX1FESVNDX1RCRikgaW4gdGVybSBvZiBkZXZsaW5rIHJhdGUgYWRkaW5n IGEKPj4gPiBnZW5lcmljIHdheSB0byBmZXRjaCB0aGUgZGV2bGlua19wb3J0IGluc3RhbmNlIGNv cnJlc3BvbmRpbmcgdG8gdGhlCj4+ID4gZ2l2ZW4gbmV0ZGV2IGFuZCBtYXBwaW5nIHRoZSBUQkYg ZmVhdHVyZXMgdG8gdGhlIGRldmxpbmtfcmF0ZSBBUEkuCj4+ID4gCj4+ID4gTm90IHN0YXJ0aW5n IHRoaXMgZHVlIHRvIHdoYXQgSmlyaSBtZW50aW9uZWQgWzFdLgo+PiAKPj4gSmlyaSwgQUZBSVUs IGlzIGFnYWluc3QgdXNpbmcgZGV2bGluayByYXRlICp1QVBJKiB0byBjb25maWd1cmUgbmV0d29y awo+PiByYXRlIGxpbWl0aW5nLiBUaGF0J3Mgc2VwYXJhdGUgZnJvbSB0aGUgaW50ZXJuYWwgcmVw cmVzZW50YXRpb24uCj4KPi4uLiB3aXRoIGEgY291cGxlcyBvZiBjYXZlYXRzOgo+Cj4xKSBBRkFJ Q1MgZGV2bGluayAoYW5kL29yIGRldmxpbmtfcG9ydCkgZG9lcyBub3QgaGF2ZSBmaW5lIGdyYWlu ZWQsIHBlcgo+cXVldWUgcmVwcmVzZW50YXRpb24gYW5kIGludGVsIHdhbnQgdG8gYmUgYWJsZSB0 byBjb25maWd1cmUgc2hhcGluZyBvbgo+cGVyIHF1ZXVlIGJhc2lzLiBJIHRoaW5rL2hvcGUgd2Ug ZG9uJ3Qgd2FudCB0byBicmluZyB0aGUgZGlzY3Vzc2lvbiB0bwo+ZXh0ZW5kaW5nIHRoZSBkZXZs aW5rIGludGVyZmFjZSB3aXRoIHF1ZXVlIHN1cHBvcnQsIEkgZmVhciB0aGF0IHdpbGwKPmJsb2Nr IHVzIGZvciBhIGxvbmcgdGltZS4gUGVyaGFwcyBJ4oCZbSBtaXNzaW5nIG9yIG1pc3VuZGVyc3Rh bmRpbmcKPnNvbWV0aGluZyBoZXJlLiBPdGhlcndpc2UgaW4gcmV0cm9zcGVjdCB0aGlzIGxvb2tz IGxpa2UgYSByZWFzb25hYmxlCj5wb2ludCB0byBjb21wbGV0ZWx5IGF2b2lkIGRldmxpbmsgaGVy ZS4KPgo+MikgTXkgdW5kZXJzdGFuZGluZyBvZiBKaXJpIHN0YXRlbWVudCB3YXMgbW9yZSByZXN0 cmljdGl2ZS4gQEppcmkgaXQKPndvdWxkIGdyZWF0IGlmIGNvdWxkIHNoYXJlIHlvdXIgZ2VudWlu ZSBpbnRlcnByZXRhdGlvbjogYXJlIHlvdSBvayB3aXRoCj51c2luZyB0aGUgZGV2bGlua19wb3J0 IHJhdGUgQVBJIGFzIGEgYmFzaXMgdG8gcmVwbGFjZQo+bmRvX3NldF90eF9tYXhyYXRlKCkgKHZp YSBkZXYtPmRldmxpbmtfcG9ydC0+ZGV2bGluay0+KSBhbmQgcG9zc2libHkKCkRvZXMgbm90IG1h a2UgYW55IHNlbnNlIHRvIG1lLgoKCj5uZG9fc2V0X3ZmX3JhdGUoKS4gTm90ZSB0aGUgZ2l2ZW4g dGhlIHByZXZpb3VzIHBvaW50LCB0aGlzIG9wdGlvbiB3b3VsZAoKbmRvX3NldF92Zl9yYXRlKCkg KGFuZCB0aGUgcmVzdCBvZiBuZG9fW2dzXWV0X3ZmXyooKSBuZG8pIGlzIHRoZQpsZWdhY3kgd2F5 LiBEZXZsaW5rIHJhdGUgcmVwbGFjZWQgdGhhdCB3aGVuIHN3aXRjaGRldiBlc3dpY2ggbW9kZSBp cwpjb25maWd1cmVkIGJ5OgokIHN1ZG8gZGV2bGluayBkZXYgZXN3aXRjaCBzZXQgcGNpLzAwMDA6 MDg6MDAuMSBtb2RlIHN3aXRjaGRldgoKSW4gZHJpdmVycywgbmRvX3NldF92Zl9yYXRlKCkgYW5k IGRldmxpbmsgcmF0ZSBhcmUgaW1wbGVtZW50ZWQgaW4gdGhlCnNhbWUgd2F5LiBTZWUgbWx4NSBm b3IgZXhhbXBsZToKbWx4NV9lc3dfcW9zX3NldF92cG9ydF9yYXRlKCkKbWx4NV9lc3dfZGV2bGlu a19yYXRlX2xlYWZfdHhfc2hhcmVfc2V0KCkKCgoKPnN0aWxsIGZlZWwgcHJvYmxlbWF0aWMuCj4K PkNoZWVycywKPgo+UGFvbG8KPgo+WzFdIGh0dHBzOi8veGtjZC5jb20vOTI3Lwo+WzJdIGh0dHBz Oi8vd3d3LnlvdXR1YmUuY29tL3dhdGNoP3Y9ZjhrT19MLXBEd28KPgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC13aXJlZC1sYW4gbWFpbGluZyBs aXN0CkludGVsLXdpcmVkLWxhbkBvc3Vvc2wub3JnCmh0dHBzOi8vbGlzdHMub3N1b3NsLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLXdpcmVkLWxhbgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9EC138F for ; Fri, 15 Dec 2023 12:30:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="K3mtzr3Z" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-336445a2749so419132f8f.0 for ; Fri, 15 Dec 2023 04:30:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1702643435; x=1703248235; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=qS1FGYqQUVgg6kmNF1jX+vnsM7iLoRSHDDPBhaHTk2c=; b=K3mtzr3ZnMrsi8h+uzxXkHgfzsqoaLtvSYkKD4yrLvV5L7Wkav1EEXK9lrq5eUYagS BaP5HaKVHPnd7sd8VMzMEpD4u5EL/q3lMNRFRnlwXBuTmkkqzlhDQWos02dXsrMT/xeh zCooiJYiR3UgkmZp23olyzchzlyXiSKvvIWOzxejUPlNU0KSU9aUawtZ3fYQrtCF1ZA1 quwl1Y/TMlYoT7l5M5eWu4CVZ3uSC1U28L2G5gKCLkw85me0vs1O03IBnh8Y0htyxhB3 upW3WjhUZUPDdRgK9bV+OmzXTGj9RBOc572CdFrhJBd53gybjm66+o8vFXBOnDwrjYME LODA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702643435; x=1703248235; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qS1FGYqQUVgg6kmNF1jX+vnsM7iLoRSHDDPBhaHTk2c=; b=qLASyvg2p2bDDp5PgFDPDluNMxQ61QFhE/tMikoftzXTA93U3FmnmP1jFM210kNmVU Ffnb+RfmbhI++hWuOCnkIatPI3KvfC1NjtGo8+4nLUMcl3oYLfP5u5gH93emo8KqBMPN eqnkwmrbhOj7dGGKM1oe03oYgfZh7cTtCfrEw/c6iYuHOLe6/ZmDk4BXo7ZL332POnz6 DpT8FsjXpO8trsN3wAenCGkfsblejsSh2C0AF9iwjOmFIiWVKgzlrGHFTVLatZ4RL+dg yMaB4Tv+hQeS075ccO1wioKQXdkcwn62uiLTXECxaH5wcIPAJyfAi3wXZTgb9AUvLXOr 8CVA== X-Gm-Message-State: AOJu0YwFqjDrZnZmtc32UHjozojJmVvfAZ+/l/wuT6bA2NWmMoKB3RME mW71x1WDAeIBQxHkdcEAeN855IiZsAplKGLjwKw= X-Google-Smtp-Source: AGHT+IFlj4q60v6pJqLAyyHxPTjQFrEhx3e7Vy7nAJ7PJz1rp7p1y8vJEgxT2DqM6935BHDDhsMGTA== X-Received: by 2002:a5d:5309:0:b0:336:3ac4:b8ba with SMTP id e9-20020a5d5309000000b003363ac4b8bamr2290149wrv.60.1702643434740; Fri, 15 Dec 2023 04:30:34 -0800 (PST) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id s15-20020a5d69cf000000b0033641783aeesm6487430wrw.7.2023.12.15.04.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 04:30:34 -0800 (PST) Date: Fri, 15 Dec 2023 13:30:32 +0100 From: Jiri Pirko To: Paolo Abeni Cc: Jakub Kicinski , netdev@vger.kernel.org, anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org, qi.z.zhang@intel.com, Wenjun Wu , maxtram95@gmail.com, "Chittim, Madhu" , "Samudrala, Sridhar" , Simon Horman Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 0/5] iavf: Add devlink and devlink rate support' Message-ID: References: <5aed9b87-28f8-f0b0-67c4-346e1d8f762c@intel.com> <20231118084843.70c344d9@kernel.org> <3d60fabf-7edf-47a2-9b95-29b0d9b9e236@intel.com> <20231122192201.245a0797@kernel.org> <20231127174329.6dffea07@kernel.org> <55e51b97c29894ebe61184ab94f7e3d8486e083a.camel@redhat.com> <20231214174604.1ca4c30d@kernel.org> <7b0c2e0132b71b131fc9a5407abd27bc0be700ee.camel@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7b0c2e0132b71b131fc9a5407abd27bc0be700ee.camel@redhat.com> Fri, Dec 15, 2023 at 12:06:52PM CET, pabeni@redhat.com wrote: >On Thu, 2023-12-14 at 17:46 -0800, Jakub Kicinski wrote: >> On Thu, 14 Dec 2023 21:29:51 +0100 Paolo Abeni wrote: >> > Together with Simon, I spent some time on the above. We think the >> > ndo_setup_tc(TC_SETUP_QDISC_TBF) hook could be used as common basis for >> > this offloads, with some small extensions (adding a 'max_rate' param, >> > too). >> >> uAPI aside, why would we use ndo_setup_tc(TC_SETUP_QDISC_TBF) >> to implement common basis? >> >> Is it not cleaner to have a separate driver API, with its ops >> and capabilities? > >We understand one of the end goal is consolidating the existing rate- >related in kernel interfaces. Adding a new one does not feel a good >starting to reach that goal, see [1] & [2] ;). ndo_setup_tc() feels >like the natural choice for H/W offload and TBF is the existing >interface IMHO nearest to the requirements here. > >The devlink rate API could be a possible alternative... Again, devlink rate was introduced for the rate configuration of the entity that is not present (by netdev for example) on a host. If we have netdev, let's use it. > >> > The idea would be: >> > - 'fixing' sch_btf so that the s/w path became a no-op when h/w offload >> > is enabled >> > - extend sch_btf to support max rate >> > - do the relevant ice implementation >> > - ndo_set_tx_maxrate could be replaced with the mentioned ndo call (the >> > latter interface is a strict super-set of former) >> > - ndo_set_vf_rate could also be replaced with the mentioned ndo call >> > (with another small extension to the offload data) >> > >> > I think mqprio deserves it's own separate offload interface, as it >> > covers multiple tasks other than shaping (grouping queues and mapping >> > priority to classes) >> > >> > In the long run we could have a generic implementation of the >> > ndo_setup_tc(TC_SETUP_QDISC_TBF) in term of devlink rate adding a >> > generic way to fetch the devlink_port instance corresponding to the >> > given netdev and mapping the TBF features to the devlink_rate API. >> > >> > Not starting this due to what Jiri mentioned [1]. >> >> Jiri, AFAIU, is against using devlink rate *uAPI* to configure network >> rate limiting. That's separate from the internal representation. > >... with a couples of caveats: > >1) AFAICS devlink (and/or devlink_port) does not have fine grained, per >queue representation and intel want to be able to configure shaping on >per queue basis. I think/hope we don't want to bring the discussion to >extending the devlink interface with queue support, I fear that will >block us for a long time. Perhaps I’m missing or misunderstanding >something here. Otherwise in retrospect this looks like a reasonable >point to completely avoid devlink here. > >2) My understanding of Jiri statement was more restrictive. @Jiri it >would great if could share your genuine interpretation: are you ok with >using the devlink_port rate API as a basis to replace >ndo_set_tx_maxrate() (via dev->devlink_port->devlink->) and possibly Does not make any sense to me. >ndo_set_vf_rate(). Note the given the previous point, this option would ndo_set_vf_rate() (and the rest of ndo_[gs]et_vf_*() ndo) is the legacy way. Devlink rate replaced that when switchdev eswich mode is configured by: $ sudo devlink dev eswitch set pci/0000:08:00.1 mode switchdev In drivers, ndo_set_vf_rate() and devlink rate are implemented in the same way. See mlx5 for example: mlx5_esw_qos_set_vport_rate() mlx5_esw_devlink_rate_leaf_tx_share_set() >still feel problematic. > >Cheers, > >Paolo > >[1] https://xkcd.com/927/ >[2] https://www.youtube.com/watch?v=f8kO_L-pDwo >