Re: [PATCH] tests/qtest/npcm7xx_pwm-test: Only do full testing in slow mode

["Daniel P. Berrangé" <berrange@redhat.com>]

On Fri, Dec 15, 2023 at 03:35:24PM +0100, Thomas Huth wrote:
> The npcm7xx_pwm-test can take quite a while when running with
> --enable-debug on a loaded system. The tests here are quite
> repetitive - by default it should be fine if we only execute
> some of them and only execute all when running in slow testing mode.

Yep, I think this change is not altering the code coverage
in any noticable way.

> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/qtest/npcm7xx_pwm-test.c | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


> 
> diff --git a/tests/qtest/npcm7xx_pwm-test.c b/tests/qtest/npcm7xx_pwm-test.c
> index ea4ca1d106..b53a43c417 100644
> --- a/tests/qtest/npcm7xx_pwm-test.c
> +++ b/tests/qtest/npcm7xx_pwm-test.c
> @@ -606,6 +606,7 @@ static void test_toggle(gconstpointer test_data)
>      uint32_t ppr, csr, pcr, cnr, cmr;
>      int i, j, k, l;
>      uint64_t expected_freq, expected_duty;
> +    int cnr_step = g_test_quick() ? 2 : 1;
>  
>      mft_init(qts, td);
>  
> @@ -618,7 +619,7 @@ static void test_toggle(gconstpointer test_data)
>              csr = csr_list[j];
>              pwm_write_csr(qts, td, csr);
>  
> -            for (k = 0; k < ARRAY_SIZE(cnr_list); ++k) {
> +            for (k = 0; k < ARRAY_SIZE(cnr_list); k += cnr_step) {
>                  cnr = cnr_list[k];
>                  pwm_write_cnr(qts, td, cnr);
>  
> @@ -678,6 +679,7 @@ static void pwm_add_test(const char *name, const TestData* td,
>  int main(int argc, char **argv)
>  {
>      TestData test_data_list[ARRAY_SIZE(pwm_module_list) * ARRAY_SIZE(pwm_list)];
> +    int pwm_module_list_cnt = 1, pwm_list_cnt = 1;
>  
>      char *v_env = getenv("V");
>  
> @@ -687,8 +689,13 @@ int main(int argc, char **argv)
>  
>      g_test_init(&argc, &argv, NULL);
>  
> -    for (int i = 0; i < ARRAY_SIZE(pwm_module_list); ++i) {
> -        for (int j = 0; j < ARRAY_SIZE(pwm_list); ++j) {
> +    if (!g_test_quick()) {
> +        pwm_module_list_cnt = ARRAY_SIZE(pwm_module_list);
> +        pwm_list_cnt = ARRAY_SIZE(pwm_list);
> +    }
> +
> +    for (int i = 0; i < pwm_module_list_cnt; ++i) {
> +        for (int j = 0; j < pwm_list_cnt; ++j) {
>              TestData *td = &test_data_list[i * ARRAY_SIZE(pwm_list) + j];
>  
>              td->module = &pwm_module_list[i];
> -- 
> 2.43.0
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|