From: Jiri Olsa <olsajiri@gmail.com>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Jiri Olsa <olsajiri@gmail.com>,
bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, martin.lau@linux.dev, song@kernel.org,
yonghong.song@linux.dev, dan.carpenter@linaro.org,
asavkov@redhat.com
Subject: Re: [PATCH bpf-next v8 1/4] bpf: Relax tracing prog recursive attach rules
Date: Fri, 15 Dec 2023 22:25:44 +0100 [thread overview]
Message-ID: <ZXzEWIDDKPmYRz06@krava> (raw)
In-Reply-To: <20231215163621.np4kmz324opmopb6@erthalion.local>
On Fri, Dec 15, 2023 at 05:36:21PM +0100, Dmitry Dolgov wrote:
> > On Fri, Dec 15, 2023 at 03:48:15PM +0100, Jiri Olsa wrote:
> > > + /* Bookkeeping for managing the prog attachment chain */
> > > + if (tgt_prog &&
> > > + prog->type == BPF_PROG_TYPE_TRACING &&
> > > + tgt_prog->type == BPF_PROG_TYPE_TRACING)
> > > + prog->aux->attach_tracing_prog = true;
> >
> > hi,
> > this still looks bad, I think it should be:
> >
> > + if (tgt_prog &&
> > + prog->type == BPF_PROG_TYPE_TRACING &&
> > + tgt_prog->type == BPF_PROG_TYPE_TRACING)
> > + prog->aux->attach_tracing_prog = true;
> >
> > other than that the patchset looks good to me
>
> Never thought I would have so many troubles with code formatting :) To
> make sure I got it right this time, this is how it should be (with
> explicit vim-style tabs and spaces, last tab for "if" predicates is
> expanded with spaces), right?
right
>
> +^Iif (tgt_prog &&
> +^I prog->type == BPF_PROG_TYPE_TRACING &&
> +^I tgt_prog->type == BPF_PROG_TYPE_TRACING)
> +^I^Iprog->aux->attach_tracing_prog = true;
yep ;-)
>
> Thanks for the review and patience.
thanks,
jirka
next prev parent reply other threads:[~2023-12-15 21:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 19:54 [PATCH bpf-next v8 0/4] Relax tracing prog recursive attach rules Dmitrii Dolgov
2023-12-12 19:54 ` [PATCH bpf-next v8 1/4] bpf: " Dmitrii Dolgov
2023-12-15 14:48 ` Jiri Olsa
2023-12-15 16:36 ` Dmitry Dolgov
2023-12-15 21:25 ` Jiri Olsa [this message]
2023-12-12 19:54 ` [PATCH bpf-next v8 2/4] selftests/bpf: Add test for recursive attachment of tracing progs Dmitrii Dolgov
2023-12-12 19:54 ` [PATCH bpf-next v8 3/4] bpf: Fix re-attachment branch in bpf_tracing_prog_attach Dmitrii Dolgov
2023-12-12 19:54 ` [PATCH bpf-next v8 4/4] selftests/bpf: Test re-attachment fix for bpf_tracing_prog_attach Dmitrii Dolgov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXzEWIDDKPmYRz06@krava \
--to=olsajiri@gmail.com \
--cc=9erthalion6@gmail.com \
--cc=andrii@kernel.org \
--cc=asavkov@redhat.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=daniel@iogearbox.net \
--cc=martin.lau@linux.dev \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.