From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gofer.mess.org (gofer.mess.org [88.97.38.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E5D31171A; Mon, 18 Dec 2023 09:02:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mess.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mess.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mess.org header.i=@mess.org header.b="mMVeDO8/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mess.org; s=2020; t=1702890149; bh=nXLNUybO72z9kq/7hDhdxKrWpyLZXnqSO0bXUnPnp04=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mMVeDO8/ys3Pr00NuGUnefiQQlpH4nhRpLWV1lUyi4n186pegseN3QF7u1MEMhnYQ QVpZrv4Ns+K1NGtGKoyZPfDGZ6rQYXMFzENJrXKuoSvnXJJ18FHhoElrweuO2tiwLh ttc2m0Lrem/Dev610bsLgYubo8CKch3zSEH5+9CRxVGIZRbbzqpeFUD2VgCgBhNXyo 9Z5WTXpBQqgvc4T2uPEQ3z0C+SO4q0k1InOods7AyKgDruW1eId6SP8cMwbItTTmSw omzurgBEcDgiAzwASroncI0iN5dWGwsFq4oPG8xWyIv7D1fzT6kf12kIcxDQzn/ca9 aR7mDXAKMTAkw== Received: by gofer.mess.org (Postfix, from userid 1000) id A890910029E; Mon, 18 Dec 2023 09:02:29 +0000 (GMT) Date: Mon, 18 Dec 2023 09:02:29 +0000 From: Sean Young To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-media@vger.kernel.org, linux-pwm@vger.kernel.org, Ivaylo Dimitrov , Thierry Reding , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 5/6] pwm: bcm2835: Allow PWM driver to be used in atomic context Message-ID: References: <20231212160838.k4z4csy455a7qnje@pengutronix.de> Precedence: bulk X-Mailing-List: linux-pwm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231212160838.k4z4csy455a7qnje@pengutronix.de> On Tue, Dec 12, 2023 at 05:08:38PM +0100, Uwe Kleine-König wrote: > Hello Sean, > > On Tue, Dec 12, 2023 at 08:34:04AM +0000, Sean Young wrote: > > @@ -169,6 +179,7 @@ static int bcm2835_pwm_suspend(struct device *dev) > > { > > struct bcm2835_pwm *pc = dev_get_drvdata(dev); > > > > + clk_rate_exclusive_put(pc->clk); > > clk_disable_unprepare(pc->clk); > > I thought this was the remove function, but that's suspend. Adding > clk_rate_exclusive_put() there is wrong. Nice catch - fixed in v9. Sean From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EC48C35274 for ; Mon, 18 Dec 2023 09:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ft21KADltuBV03NS8cPJLqG8erRYZHJ5+TjRJ103a9Y=; b=uZZYRpQT3k3rbz VysuGEelS14V+9aDIkTkDUNRuUtsRTZR9+nJEjhgJ2ZWMH4sQC896MgX+R7RxK4Kj6bzQ3jfNuTsg 2pIX8lE/YksAw34gVLlDJBkNoDxRurO84xE7M/tsj606M2A+0nTVrbybn0EBGEmbPg1x1P2LfFanD knJwQET5DksPVUxS1wTo3n0ePjeuCrRGcVizCThDSepprQILayyIPoCEI+rWGnqRM2BI8//l07ZRg bZ28SjvglsTk6rPzrXqcyMOkyw/hQw3xlvVu5WEOSdMFhh1zvBEcATBKyuK8Rh+K7w7YSF8B9DuH3 ia8EXjn/fnbNUjg+sFkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rF9WH-009Zcf-0D; Mon, 18 Dec 2023 09:02:37 +0000 Received: from gofer.mess.org ([2a02:8011:d000:212::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rF9WB-009ZZd-38; Mon, 18 Dec 2023 09:02:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mess.org; s=2020; t=1702890149; bh=nXLNUybO72z9kq/7hDhdxKrWpyLZXnqSO0bXUnPnp04=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mMVeDO8/ys3Pr00NuGUnefiQQlpH4nhRpLWV1lUyi4n186pegseN3QF7u1MEMhnYQ QVpZrv4Ns+K1NGtGKoyZPfDGZ6rQYXMFzENJrXKuoSvnXJJ18FHhoElrweuO2tiwLh ttc2m0Lrem/Dev610bsLgYubo8CKch3zSEH5+9CRxVGIZRbbzqpeFUD2VgCgBhNXyo 9Z5WTXpBQqgvc4T2uPEQ3z0C+SO4q0k1InOods7AyKgDruW1eId6SP8cMwbItTTmSw omzurgBEcDgiAzwASroncI0iN5dWGwsFq4oPG8xWyIv7D1fzT6kf12kIcxDQzn/ca9 aR7mDXAKMTAkw== Received: by gofer.mess.org (Postfix, from userid 1000) id A890910029E; Mon, 18 Dec 2023 09:02:29 +0000 (GMT) Date: Mon, 18 Dec 2023 09:02:29 +0000 From: Sean Young To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-media@vger.kernel.org, linux-pwm@vger.kernel.org, Ivaylo Dimitrov , Thierry Reding , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 5/6] pwm: bcm2835: Allow PWM driver to be used in atomic context Message-ID: References: <20231212160838.k4z4csy455a7qnje@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231212160838.k4z4csy455a7qnje@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_010232_144201_BCDD5088 X-CRM114-Status: GOOD ( 10.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 12, 2023 at 05:08:38PM +0100, Uwe Kleine-K=F6nig wrote: > Hello Sean, > = > On Tue, Dec 12, 2023 at 08:34:04AM +0000, Sean Young wrote: > > @@ -169,6 +179,7 @@ static int bcm2835_pwm_suspend(struct device *dev) > > { > > struct bcm2835_pwm *pc =3D dev_get_drvdata(dev); > > = > > + clk_rate_exclusive_put(pc->clk); > > clk_disable_unprepare(pc->clk); > = > I thought this was the remove function, but that's suspend. Adding > clk_rate_exclusive_put() there is wrong. Nice catch - fixed in v9. Sean _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel