From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C06A9C35274 for ; Mon, 18 Dec 2023 10:24:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nLxtRcMSfpme4DtsXPgxiQWIwDZd2CPsfeWByk+cpUU=; b=IOkPHDxmnvRf75 xS4k5yjF+qtwc6sEyz9B9FO4U7Xk2Vxr73UjvEFY3teIvKxtnRm60f0xPv73Yw0bYM//865+rIY/N tZhRAG04a+Sw3Uh5XnYx9BEJv1e9cpfTNm839OoesD/FXKiuxTt13w5AKLUfcu23WcAQPr7F3Aawj hIuezSUd1H/iyYQ3V4ub+hoOcxSvdrA4KNgDwdkSuvfON9rzv3Vhv5qRqL5eXohPYOB7Te/84P+UF QZwtZ1pOaCQslOBhuf5YsxNHOaDhKKgbgdB4gJELXIDHeJD+Si67wROPu0QBlik+2v78AkgBp4EYg KfMgiml9Uuzi1hGHtRRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFAmq-009oPd-2a; Mon, 18 Dec 2023 10:23:48 +0000 Received: from mgamail.intel.com ([198.175.65.12]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFAmo-009oPF-1K for linux-arm-kernel@lists.infradead.org; Mon, 18 Dec 2023 10:23:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702895027; x=1734431027; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=OR8ENRQEVanZisncmHUkNCSziQATmbvmhDTN5mpUyIE=; b=id5Yf+gqlPQLFjg7HxShCwvUyWZZzqNQj8ApgG5y8stYFBtp1vpDHkDG rD2WUrYbF0rMbTlP1At4m8pJBgk+Rx4avq19RrpUQRPTQz7zEQI/O68W5 fsbVkAeMhhIxu6nXGKOrWYbPLIac+1kcSHqiKDRmSDORfoKvYgD+B2FZD 3FgdPHj7NXm6bFRE/SJucBNZtS0Lb2DZF5PKNv9ANNEx6ahdSskw8VKLK /JvgAo1OG7RJheAyFHeTsxxklFmCisBQdoeh8bnbg99J2frio3cyGUmqv MApWaIUClXzjVHu6rmtNXSs56eJ4FzyLjvTYZKmAmk2dW3BQtMehgevwD w==; X-IronPort-AV: E=McAfee;i="6600,9927,10927"; a="2692358" X-IronPort-AV: E=Sophos;i="6.04,285,1695711600"; d="scan'208";a="2692358" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2023 02:23:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10927"; a="809764965" X-IronPort-AV: E=Sophos;i="6.04,285,1695711600"; d="scan'208";a="809764965" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2023 02:23:37 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rFAmb-00000006tHO-0x88; Mon, 18 Dec 2023 12:23:33 +0200 Date: Mon, 18 Dec 2023 12:23:32 +0200 From: Andy Shevchenko To: Peter Hilber Cc: linux-kernel@vger.kernel.org, "D, Lakshmi Sowjanya" , Thomas Gleixner , jstultz@google.com, giometti@enneenne.com, corbet@lwn.net, "Dong, Eddie" , "Hall, Christopher S" , Marc Zyngier , linux-arm-kernel@lists.infradead.org, Sean Christopherson , Paolo Bonzini , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Wanpeng Li , Vitaly Kuznetsov , Mark Rutland , Daniel Lezcano , Richard Cochran , kvm@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [RFC PATCH v2 3/7] x86/kvm, ptp/kvm: Add clocksource ID, set system_counterval_t.cs_id Message-ID: References: <20231215220612.173603-1-peter.hilber@opensynergy.com> <20231215220612.173603-4-peter.hilber@opensynergy.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231215220612.173603-4-peter.hilber@opensynergy.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_022346_525038_367D7460 X-CRM114-Status: GOOD ( 16.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 15, 2023 at 11:06:08PM +0100, Peter Hilber wrote: > Add a clocksource ID for the x86 kvmclock. > > Also, for ptp_kvm, set the recently added struct system_counterval_t member > cs_id to the clocksource ID (x86 kvmclock or Arm Generic Timer). In the > future, this will keep get_device_system_crosststamp() working, when it > will compare the clocksource id in struct system_counterval_t, rather than > the clocksource. > > For now, to avoid touching too many subsystems at once, extract the > clocksource ID from the clocksource. The clocksource dereference will be > removed in the following. ... > #include > +#include It's the second file that includes both. I'm just wondering if it makes sense to always (?) include the latter into the former. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5558313AC2; Mon, 18 Dec 2023 10:23:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GIwHuhOy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702895025; x=1734431025; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=OR8ENRQEVanZisncmHUkNCSziQATmbvmhDTN5mpUyIE=; b=GIwHuhOybTOdTaDw5shnbLYkoOmyuhL4Rq9vErQUh9aBKsfYgdkQ/ZGp 7nlVdifKjn/9FNYuEeK2L+wfCtcvI9QxDyvZllP2/+M7WqBoAuw8zOS4n BQiF0xYpiH8/PhsDJvb8D07OP4GNoG5Yh/OGEQuvGfSD4mjJbY76vNoF9 lRWcI7Zsi/McMgnEB0JaWm89x50U5PKj1TUPmjaLNlxM3l/zo4dlIOZbi 6nNsHOW2gBpR2n4sMZrXmPcmFwFgEf39WWQlq9hBYefqjd6MXk7Z+N1pc hmQ3o4vl+QuVzsI0Tvk/qHDZPJUV9jE7iVgBT5hMC5e/ogvwKj0uP+pGv w==; X-IronPort-AV: E=McAfee;i="6600,9927,10927"; a="2692351" X-IronPort-AV: E=Sophos;i="6.04,285,1695711600"; d="scan'208";a="2692351" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2023 02:23:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10927"; a="809764965" X-IronPort-AV: E=Sophos;i="6.04,285,1695711600"; d="scan'208";a="809764965" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2023 02:23:37 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rFAmb-00000006tHO-0x88; Mon, 18 Dec 2023 12:23:33 +0200 Date: Mon, 18 Dec 2023 12:23:32 +0200 From: Andy Shevchenko To: Peter Hilber Cc: linux-kernel@vger.kernel.org, "D, Lakshmi Sowjanya" , Thomas Gleixner , jstultz@google.com, giometti@enneenne.com, corbet@lwn.net, "Dong, Eddie" , "Hall, Christopher S" , Marc Zyngier , linux-arm-kernel@lists.infradead.org, Sean Christopherson , Paolo Bonzini , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Wanpeng Li , Vitaly Kuznetsov , Mark Rutland , Daniel Lezcano , Richard Cochran , kvm@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [RFC PATCH v2 3/7] x86/kvm, ptp/kvm: Add clocksource ID, set system_counterval_t.cs_id Message-ID: References: <20231215220612.173603-1-peter.hilber@opensynergy.com> <20231215220612.173603-4-peter.hilber@opensynergy.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231215220612.173603-4-peter.hilber@opensynergy.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Dec 15, 2023 at 11:06:08PM +0100, Peter Hilber wrote: > Add a clocksource ID for the x86 kvmclock. > > Also, for ptp_kvm, set the recently added struct system_counterval_t member > cs_id to the clocksource ID (x86 kvmclock or Arm Generic Timer). In the > future, this will keep get_device_system_crosststamp() working, when it > will compare the clocksource id in struct system_counterval_t, rather than > the clocksource. > > For now, to avoid touching too many subsystems at once, extract the > clocksource ID from the clocksource. The clocksource dereference will be > removed in the following. ... > #include > +#include It's the second file that includes both. I'm just wondering if it makes sense to always (?) include the latter into the former. -- With Best Regards, Andy Shevchenko