From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8175FC35274 for ; Mon, 18 Dec 2023 18:28:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 05D4A10E212; Mon, 18 Dec 2023 18:28:26 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id B40B410E1D8; Mon, 18 Dec 2023 18:26:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702924011; x=1734460011; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=TzdFWiBNAuwVCR3VsBKJShUDeiTYi+ArmIN4iuzwbj4=; b=F67g2NXVphs6HXUI1yVO/PQYR/T4Zo97yvQHmeLFrcaU7WSacbbE6cyN 1Y9D5N53/iDVz1OzMtkdzGyxI6TVEjMJKYe/tPon8lj9/PxlTvEFjROji JpVGcg7EtgL+sQ5J/cVOJ+bNV9TJMBXuuzreDZJg49uexmcrrRORKajQx s8eDQm1I55qargTVYwgZtqngMt8JweMKQlYKyLghjUGeaW3TMC37khNth Bo8dS3vUtNvw9pyzVOaN1bbPi9dOXLWQwIMroGYDDpUxjxKXt5Qw8oDmv APhe3j87Kw/bsZSHXN1VkbeaCR/8K1uvuNIiCkevOvlOm85Tgf1A96Csg g==; X-IronPort-AV: E=McAfee;i="6600,9927,10927"; a="395234540" X-IronPort-AV: E=Sophos;i="6.04,285,1695711600"; d="scan'208";a="395234540" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2023 04:56:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10927"; a="768832440" X-IronPort-AV: E=Sophos;i="6.04,285,1695711600"; d="scan'208";a="768832440" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by orsmga007.jf.intel.com with SMTP; 18 Dec 2023 04:56:04 -0800 Received: by stinkbox (sSMTP sendmail emulation); Mon, 18 Dec 2023 14:56:04 +0200 Date: Mon, 18 Dec 2023 14:56:04 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Javier Martinez Canillas Subject: Re: [PATCH] drm/mm: Allow CONFIG_DRM_MM_DEBUG with DRM=m Message-ID: References: <20231215111129.9559-1-ville.syrjala@linux.intel.com> <87o7ern1gn.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87o7ern1gn.fsf@minerva.mail-host-address-is-not-set> X-Patchwork-Hint: comment X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Dec 15, 2023 at 12:34:48PM +0100, Javier Martinez Canillas wrote: > Ville Syrjala writes: > > Hello Ville, > > > From: Ville Syrjälä > > > > The original rationale for > > commit cd456f8d06d2 ("drm: Restrict stackdepot usage to builtin drm.ko") > > was that depot_save_stack() (which is what we used back then) > > wasn't exported. stack_depot_save() (which is what we use now) is > > exported however, so relax the dependency allow CONFIG_DRM_MM_DEBUG > > with DRM=m. > > > > Signed-off-by: Ville Syrjälä > > --- > > drivers/gpu/drm/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > > index 31cfe2c2a2af..4b8b8f8a0e72 100644 > > --- a/drivers/gpu/drm/Kconfig > > +++ b/drivers/gpu/drm/Kconfig > > @@ -42,7 +42,7 @@ config DRM_MIPI_DSI > > config DRM_DEBUG_MM > > bool "Insert extra checks and debug info into the DRM range managers" > > default n > > - depends on DRM=y > > + depends on DRM > > depends on STACKTRACE_SUPPORT > > select STACKDEPOT > > help > > -- > > Acked-by: Javier Martinez Canillas Thanks. Pushed to drm-misc-next. -- Ville Syrjälä Intel