Re: [Buildroot] [PATCH v3 1/3] package/itstool: new host-package

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Adam, All,

On 2023-12-18 12:54 -0700, Adam Duskett spake thusly:
> Translate XML with PO files using W3C Internationalization Tag Set rules.
> This is needed for the zenity package.
> 
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>

    $ cat my_defconfig
    BR2_PER_PACKAGE_DIRECTORIES=y

    $ make BR2_DEFCONFIG=$(pwd)/my_defconfig defconfig
    [...]

    $ make host-itstool
    [...]
    checking for a Python interpreter with version >= 2.6... python
    checking for python...  /home/ymorin/dev/buildroot/O/master/per-package/host-itstool/host/bin/python
    checking for python version... 3.11
    checking for python platform... linux
    checking for GNU default python prefix... ${prefix}
    checking for GNU default python exec_prefix... ${exec_prefix}
    checking for python script directory (pythondir)...  ${PYTHON_PREFIX}/lib/python3.11/site-packages
    checking for python extension module directory (pyexecdir)...  ${PYTHON_EXEC_PREFIX}/lib/python3.11/site-packages
    checking for python module libxml2... not found
    configure: error: Python module libxml2 is needed to run this package
    make[1]: *** [package/pkg-generic.mk:273: /home/ymorin/dev/buildroot/O/master/build/host-itstool-2.0.7/.stamp_configured] Error 1
    make: *** [Makefile:23: _all] Error 2

However, the situation is going to be a bit complicated: the python3
libxml2 bindings are provided by host-libxml2, which only installs those
when BR2_PACKAGE_HOST_PYTHON3=y.

Since you introduced host-itstool as a promptless host package [0],
there is no way to ensure tht host-python3 will be enabled, so there is
no way to ensure the python3 libxml2 bindings will be installed.

So, the solution is for itstool to have a prompt, which does select
BR2_PACKAGE_HOST_PYTHON3. Also, host-libxml2 must be added as a
dependency to host-itstool.

Later in the series, zenity will have to select host itstool (as well as
get a _DEPENDENCIES on it of course).

[0] on principle, there is nothing wrong with a prompt-less host
package; just in this case does it get problematic.

Also, see below...

[--SNIP--]
> diff --git a/package/itstool/itstool.mk b/package/itstool/itstool.mk
> new file mode 100644
> index 0000000000..d9aa016f50
> --- /dev/null
> +++ b/package/itstool/itstool.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# itstool
> +#
> +################################################################################
> +
> +ITSTOOL_VERSION = 2.0.7
> +ITSTOOL_SITE = $(call github,itstool,itstool,$(ITSTOOL_VERSION))
> +ITSTOOL_LICENSE = GPL-3.0+
> +ITSTOOL_LICENSE_FILES = COPYING.GPL3
> +HOST_ITSTOOL_AUTORECONF = YES

It is customary that the need for autoreconf be explained; in this case,
it's just:

    # Straight our of git, no ./configure

If that had been the only issue, I'd have fixed when applying, but it
needs more changes as explained above.

Can you look into that, please?

Regards,
Yann E. MORIN.

> +HOST_ITSTOOL_DEPENDENCIES = host-python3
> +
> +$(eval $(host-autotools-package))
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot