All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Nick Terrell <terrelln@fb.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	Andi Kleen <ak@linux.intel.com>, Kajol Jain <kjain@linux.ibm.com>,
	Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
	Huacai Chen <chenhuacai@kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Vincent Whitchurch <vincent.whitchurch@axis.com>,
	"Steinar H. Gunderson" <sesse@google.com>,
	Liam Howlett <liam.howlett@oracle.com>,
	Miguel Ojeda <ojeda@kernel.org>,
	Colin Ian King <colin.i.king@gmail.com>,
	Dmitrii Dolgov <9erthalion6@gmail.com>,
	Yang Jihong <yangjihong1@huawei.com>,
	Ming Wang <wangming01@loongson.cn>,
	James Clark <james.clark@arm.com>,
	K Prateek Nayak <kprateek.nayak@amd.com>,
	Sean Christopherson <seanjc@google.com>,
	Leo Yan <leo.yan@linaro.org>,
	Ravi Bangoria <ravi.bangoria@amd.com>,
	German Gomez <german.gomez@arm.com>,
	Changbin Du <changbin.du@huawei.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Li Dong <lidong@vivo.com>,
	Sandipan Das <sandipan.das@amd.com>,
	liuwenyu <liuwenyu7@huawei.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	Guilherme Amadio <amadio@gentoo.org>
Subject: Re: [PATCH v6 00/47] maps/threads/dsos memory improvements and fixes
Date: Mon, 18 Dec 2023 17:53:37 -0300	[thread overview]
Message-ID: <ZYCxURwlu7Rld-IW@kernel.org> (raw)
In-Reply-To: <20231207011722.1220634-1-irogers@google.com>

Em Wed, Dec 06, 2023 at 05:16:34PM -0800, Ian Rogers escreveu:
> Modify the implementation of maps to not use an rbtree as the
> container for maps, instead use a sorted array. Improve locking and
> reference counting issues.
> 
> Similar to maps separate out and reimplement threads to use a hashmap
> for lower memory consumption and faster look up. The fixes a
> regression in memory usage where reference count checking switched to
> using non-invasive tree nodes.  Reduce its default size by 32 times
> and improve locking discipline. Also, fix regressions where tids had
> become unordered to make `perf report --tasks` and
> `perf trace --summary` output easier to read.
> 
> Better encapsulate the dsos abstraction. Remove the linked list and
> rbtree used for faster iteration and log(n) lookup to a sorted array
> for similar performance but half the memory usage per dso. Improve
> reference counting and locking discipline, adding reference count
> checking to dso.
> 
> v6:
>  - Patch 1 is a parameter name fix requested by Namhyung.
>  - Patches 2 to 13 split apart a macro to function callback refactor
>    requested by Arnaldo.
>  - Add fixes and acked-by to later patches from Namhyung.

Applied 1-10, 11 is failing, I'll try to resolve if you don't do it
first.

This should be in tmp.perf-tools-next soon

- Arnaldo

  parent reply	other threads:[~2023-12-18 20:53 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-07  1:16 [PATCH v6 00/47] maps/threads/dsos memory improvements and fixes Ian Rogers
2023-12-07  1:16 ` [PATCH v6 01/47] perf map: Improve map/unmap parameter names Ian Rogers
2023-12-11 23:38   ` Namhyung Kim
2023-12-11 23:39     ` Namhyung Kim
2023-12-11 23:52       ` Ian Rogers
2023-12-19  6:06         ` Namhyung Kim
2023-12-07  1:16 ` [PATCH v6 02/47] perf maps: Add maps__for_each_map to iterate maps holding the lock Ian Rogers
2023-12-07  1:16 ` [PATCH v6 03/47] perf events x86: Use function to add missing lock Ian Rogers
2023-12-07  1:16 ` [PATCH v6 04/47] perf report: Use function to add missing maps lock Ian Rogers
2023-12-07  1:16 ` [PATCH v6 05/47] perf tests: " Ian Rogers
2023-12-07  1:16 ` [PATCH v6 06/47] perf machine: " Ian Rogers
2023-12-07  1:16 ` [PATCH v6 07/47] perf probe-event: " Ian Rogers
2023-12-07  1:16 ` [PATCH v6 08/47] perf symbol: " Ian Rogers
2023-12-07  1:16 ` [PATCH v6 09/47] perf synthetic-events: " Ian Rogers
2023-12-07  1:16 ` [PATCH v6 10/47] perf thread: " Ian Rogers
2023-12-07  1:16 ` [PATCH v6 11/47] perf unwind: " Ian Rogers
2023-12-07  1:16 ` [PATCH v6 12/47] perf vdso: " Ian Rogers
2023-12-07  1:16 ` [PATCH v6 13/47] perf maps: Reduce scope of maps__for_each_entry Ian Rogers
2023-12-07  1:16 ` [PATCH v6 14/47] perf maps: Add remove maps function to remove a map based on callback Ian Rogers
2023-12-07  1:16 ` [PATCH v6 15/47] perf debug: Expose debug file Ian Rogers
2023-12-07  1:16 ` [PATCH v6 16/47] perf maps: Refactor maps__fixup_overlappings Ian Rogers
2023-12-07  1:16 ` [PATCH v6 17/47] perf maps: Do simple merge if given map doesn't overlap Ian Rogers
2023-12-07  1:16 ` [PATCH v6 18/47] perf maps: Rename clone to copy from Ian Rogers
2023-12-07  1:16 ` [PATCH v6 19/47] perf maps: Add maps__load_first Ian Rogers
2023-12-07  1:16 ` [PATCH v6 20/47] perf maps: Add find next entry to give entry after the given map Ian Rogers
2023-12-07  1:16 ` [PATCH v6 21/47] perf maps: Reduce scope of map_rb_node and maps internals Ian Rogers
2023-12-07  1:16 ` [PATCH v6 22/47] perf maps: Fix up overlaps during fixup_end Ian Rogers
2023-12-07  1:16 ` [PATCH v6 23/47] perf maps: Switch from rbtree to lazily sorted array for addresses Ian Rogers
2023-12-07  1:16 ` [PATCH v6 24/47] perf maps: Get map before returning in maps__find Ian Rogers
2023-12-07  1:16 ` [PATCH v6 25/47] perf maps: Get map before returning in maps__find_by_name Ian Rogers
2023-12-07  1:17 ` [PATCH v6 26/47] perf maps: Get map before returning in maps__find_next_entry Ian Rogers
2023-12-07  1:17 ` [PATCH v6 27/47] perf maps: Hide maps internals Ian Rogers
2023-12-07  1:17 ` [PATCH v6 28/47] perf maps: Locking tidy up of nr_maps Ian Rogers
2023-12-07  1:17 ` [PATCH v6 29/47] perf dso: Reorder variables to save space in struct dso Ian Rogers
2023-12-07  1:17 ` [PATCH v6 30/47] perf report: Sort child tasks by tid Ian Rogers
2023-12-07  1:17 ` [PATCH v6 31/47] perf trace: Ignore thread hashing in summary Ian Rogers
2023-12-07  1:17 ` [PATCH v6 32/47] perf machine: Move fprintf to for_each loop and a callback Ian Rogers
2023-12-07  1:17 ` [PATCH v6 33/47] perf threads: Move threads to its own files Ian Rogers
2023-12-07  1:17 ` [PATCH v6 34/47] perf threads: Switch from rbtree to hashmap Ian Rogers
2023-12-07  1:17 ` [PATCH v6 35/47] perf threads: Reduce table size from 256 to 8 Ian Rogers
2023-12-07  1:17 ` [PATCH v6 36/47] perf dsos: Attempt to better abstract dsos internals Ian Rogers
2023-12-07  1:17 ` [PATCH v6 37/47] perf dsos: Tidy reference counting and locking Ian Rogers
2023-12-07  1:17 ` [PATCH v6 38/47] perf dsos: Add dsos__for_each_dso Ian Rogers
2023-12-07  1:17 ` [PATCH v6 39/47] perf dso: Move dso functions out of dsos Ian Rogers
2023-12-07  1:17 ` [PATCH v6 40/47] perf dsos: Switch more loops to dsos__for_each_dso Ian Rogers
2023-12-07  1:17 ` [PATCH v6 41/47] perf dsos: Switch backing storage to array from rbtree/list Ian Rogers
2023-12-07  1:17 ` [PATCH v6 42/47] perf dsos: Remove __dsos__addnew Ian Rogers
2023-12-07  1:17 ` [PATCH v6 43/47] perf dsos: Remove __dsos__findnew_link_by_longname_id Ian Rogers
2023-12-07  1:17 ` [PATCH v6 44/47] perf dsos: Switch hand code to bsearch Ian Rogers
2023-12-07  1:17 ` [PATCH v6 45/47] perf dso: Add reference count checking and accessor functions Ian Rogers
2023-12-07  1:17 ` [PATCH v6 46/47] perf dso: Reference counting related fixes Ian Rogers
2023-12-07  1:17 ` [PATCH v6 47/47] perf dso: Use container_of to avoid a pointer in dso_data Ian Rogers
2023-12-18 20:53 ` Arnaldo Carvalho de Melo [this message]
2023-12-19  1:27   ` [PATCH v6 00/47] maps/threads/dsos memory improvements and fixes Arnaldo Carvalho de Melo
2023-12-20 17:46     ` Arnaldo Carvalho de Melo
2023-12-20 18:07       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZYCxURwlu7Rld-IW@kernel.org \
    --to=acme@kernel.org \
    --cc=9erthalion6@gmail.com \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=amadio@gentoo.org \
    --cc=atrajeev@linux.vnet.ibm.com \
    --cc=changbin.du@huawei.com \
    --cc=chenhuacai@kernel.org \
    --cc=colin.i.king@gmail.com \
    --cc=german.gomez@arm.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=kjain@linux.ibm.com \
    --cc=kprateek.nayak@amd.com \
    --cc=leo.yan@linaro.org \
    --cc=liam.howlett@oracle.com \
    --cc=lidong@vivo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=liuwenyu7@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@amd.com \
    --cc=sandipan.das@amd.com \
    --cc=seanjc@google.com \
    --cc=sesse@google.com \
    --cc=terrelln@fb.com \
    --cc=vincent.whitchurch@axis.com \
    --cc=wangming01@loongson.cn \
    --cc=yangjihong1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.