From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Petre Rodan <petre.rodan@subdimension.ro>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Angel Iglesias <ang.iglesiasg@gmail.com>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Andreas Klinger <ak@it-klinger.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH 2/2] iio: pressure: change driver for Honeywell MPR series
Date: Tue, 19 Dec 2023 17:41:25 +0200 [thread overview]
Message-ID: <ZYG5pZaDN11eht7A@smile.fi.intel.com> (raw)
In-Reply-To: <20231219130230.32584-3-petre.rodan@subdimension.ro>
On Tue, Dec 19, 2023 at 03:02:21PM +0200, Petre Rodan wrote:
> ChangeLog
> - rewrite flow so that driver can use either i2c or spi as communication bus
> - add spi driver (tested on MPRLS0015PA0000SA)
> - add pressure-triplet property that automatically sets pmin, pmax
> - fix transfer-function enum typo based on previous review [1]
> - fix interrupt example in binding file (FALLING -> RISING edge)
> - indentation changes based on previous code reviews
> - renamed mpr_read_pressure to mpr_read_conversion since the sensor is
> supposed to also provide temperature measuremets
> (but I think mine is broken since the raw temperature value is always
> 0x800000 - so temp reading not currently implemented)
Changelog...
> I've been told in the past that the use of mutexes is redundant in these cases
> so please assess if the guard() from the driver code is required or should be
> removed.
A comment...
> patch uses device_property_match_property_string() from the 'togreg' branch
Another comment...
> [1]: https://lore.kernel.org/lkml/20231116-grudge-hankering-b7a71d831b93@squawk/T/
Some Link: (should it be a tag?)...
Where is the commit message? Or is this just an intermediate change
to show what will be in the next version? I'm confused.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-19 15:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 13:02 [PATCH 0/2] iio: pressure: changes to mprls0025pa Petre Rodan
2023-12-19 13:02 ` [PATCH 1/2] dt-bindings: iio: pressure: honeywell,mprls0025pa Petre Rodan
2023-12-20 15:16 ` Jonathan Cameron
2023-12-20 17:25 ` Petre Rodan
2023-12-21 11:04 ` Jonathan Cameron
2023-12-22 15:27 ` Conor Dooley
2023-12-23 11:28 ` Petre Rodan
2023-12-19 13:02 ` [PATCH 2/2] iio: pressure: change driver for Honeywell MPR series Petre Rodan
2023-12-19 15:41 ` Andy Shevchenko [this message]
2023-12-19 16:51 ` Petre Rodan
2023-12-20 15:13 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYG5pZaDN11eht7A@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ak@it-klinger.de \
--cc=ang.iglesiasg@gmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=petre.rodan@subdimension.ro \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.