From: Keith Busch <kbusch@kernel.org>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@meta.com>,
linux-nvme@lists.infradead.org, axboe@kernel.dk,
chaitanyak@nvidia.com
Subject: Re: [PATCHv2] nvme-pci: enhance timeout kernel log
Date: Tue, 19 Dec 2023 09:15:10 -0700 [thread overview]
Message-ID: <ZYHBjllwmdS8BIjA@kbusch-mbp> (raw)
In-Reply-To: <2863ba06-747c-401a-85db-2ecbdfc78e04@nvidia.com>
On Tue, Dec 19, 2023 at 06:09:23PM +0200, Max Gurtovoy wrote:
>
>
> On 19/12/2023 16:15, Sagi Grimberg wrote:
> >
> > > > - "I/O %d QID %d timeout, completion polled\n",
> > > > + "I/O tag %d QID %d timeout, completion polled\n",
> > >
> > > Q: should we use the Linux term tag or the NVMe term command ID
> > > (or command_id) ? I don't really care, just thinking out loud.
> >
> > I was fine with neither tbh, but tag is better than command_id I
> > think.
> >
>
> In the current Keith code it is actually the tag.
> If you would like to print the cid please use: nvme_cid(req).
>
> I guess the cid will be the useful value that we can compare to the
> wireshark or the target prints.
Yes! This currently prints the "tag" from blk-mq. I can change it to
print the encoded command_id in the SQE. Or both!
next prev parent reply other threads:[~2023-12-19 16:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 22:46 [PATCHv2] nvme-pci: enhance timeout kernel log Keith Busch
2023-12-19 5:01 ` Christoph Hellwig
2023-12-19 14:15 ` Sagi Grimberg
2023-12-19 16:09 ` Max Gurtovoy
2023-12-19 16:15 ` Keith Busch [this message]
2023-12-19 16:21 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYHBjllwmdS8BIjA@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.