From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0551D200C7 for ; Tue, 19 Dec 2023 16:52:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LxU+Od9m" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3363aa2bbfbso5098720f8f.0 for ; Tue, 19 Dec 2023 08:52:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703004742; x=1703609542; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zy4Z3eEuLBj08ts84l431wJvHoWWggzPm4qQ5zBcMOE=; b=LxU+Od9mZpj3Z+GvaGPTeccQyQMN4oPXZG9rn6kOPLGh27bJRAmGa70EaiII+EWQwX u6nKGXUMmC7ffav9JQFk3n1A76TNZaXPGG1NxrzV1ite1+GihcqK7U7Uq6eL56QTolYW 4IW2q/FFFRO6RZXmxL5k4tk3yUenIHaxrDA8Dy9JyojarmZY/Z3opQV5ao8OrANYBmLH Ww+08hxUGKXW7kzy6phlWzpKMD4gIHnPe114nslATp+n4lWBoC0a56SjqBj266V7fs0r rk/CmuH216wL7UP8rhzYkLBJwH0625LZZz+VQ3p85nSrjdDek9LTyLehw3rGgAOMOWgZ kjZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703004742; x=1703609542; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zy4Z3eEuLBj08ts84l431wJvHoWWggzPm4qQ5zBcMOE=; b=APw3Z7szplD/WQxL7w5gbQGCFXmsFzIV2WApX8VTZ5mzzIkV/0QUZ/637VIpDXBWo2 TNouRlFz6oajM/LM4f+GFGX0ffSb5ghjls3rb4tAlJnIhfTtr+oEggpCoSJpl6APfqAE 3u7bcCJv2QkwvNqdxRD5e0R1DZr/4Z3sHtslv44TR0w8R2BvUYq1r8w7XSH0mjNj9wgZ DzZu7RJCVCQgggu6qY0GIhB7/LfhehGSg6T3totAzpffuHplpbESUhIlAc54O+tvd2Jb mKYweyO5JZTkZR6VWZDEWA0nMYaYF3FJqDjuC8SB3k6BofkmcA4TFawY0shJUmmYze9r 9yYw== X-Gm-Message-State: AOJu0Yy0zd63msty7f2OD6bWTohQdBn9wIEaUwbwyjC5w4lDjMURMSpS ZrwGmGjD0PKQiI0Whdvdwz61Hw== X-Google-Smtp-Source: AGHT+IFIh9biTT2PfAWfIIivnLl6PU1NZBv6rg4KrRM98BXFbXikPQgRjibC9rN/fogphV8WUSVbZA== X-Received: by 2002:adf:f282:0:b0:336:7758:c6f1 with SMTP id k2-20020adff282000000b003367758c6f1mr251211wro.113.1703004742182; Tue, 19 Dec 2023 08:52:22 -0800 (PST) Received: from linaro.org ([79.115.23.25]) by smtp.gmail.com with ESMTPSA id h9-20020a5d4309000000b003366d04b050sm4280826wrq.38.2023.12.19.08.52.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 08:52:21 -0800 (PST) Date: Tue, 19 Dec 2023 18:52:20 +0200 From: Abel Vesa To: Alexander Stein Cc: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Oliver F . Brown" , Ranjani Vaidyanathan Subject: Re: [PATCH 1/1] clk: imx: clk-imx8qxp: fix LVDS bypass, pixel and phy clocks Message-ID: References: <20231218122407.2757175-1-alexander.stein@ew.tq-group.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231218122407.2757175-1-alexander.stein@ew.tq-group.com> On 23-12-18 13:24:07, Alexander Stein wrote: > To be compatibel with SCU firmware based on 1.15 a different clock > routing for LVDS is needed. > compatible > Signed-off-by: Oliver F. Brown > Signed-off-by: Ranjani Vaidyanathan > Signed-off-by: Alexander Stein With that: Reviewed-by: Abel Vesa > --- > This patch originates from the downstream kernel squashing patches [1] and [2] > as suggested by the commit message. > I adjusted the commit so that the name stays the same as before. > > I am somewhat unsure about the From: tag, as both commits have different > authors. > > Best regards, > Alexander > > [1] https://github.com/Freescale/linux-fslc/commit/05b5fd0eebd0 > [2] https://github.com/Freescale/linux-fslc/commit/0a202c564e5f > drivers/clk/imx/clk-imx8qxp.c | 24 ++++++++++++++++++++---- > 1 file changed, 20 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/imx/clk-imx8qxp.c b/drivers/clk/imx/clk-imx8qxp.c > index 41f0a45aa162..7d8883916cac 100644 > --- a/drivers/clk/imx/clk-imx8qxp.c > +++ b/drivers/clk/imx/clk-imx8qxp.c > @@ -66,6 +66,22 @@ static const char * const lcd_pxl_sels[] = { > "lcd_pxl_bypass_div_clk", > }; > > +static const char *const lvds0_sels[] = { > + "clk_dummy", > + "clk_dummy", > + "clk_dummy", > + "clk_dummy", > + "mipi0_lvds_bypass_clk", > +}; > + > +static const char *const lvds1_sels[] = { > + "clk_dummy", > + "clk_dummy", > + "clk_dummy", > + "clk_dummy", > + "mipi1_lvds_bypass_clk", > +}; > + > static const char * const mipi_sels[] = { > "clk_dummy", > "clk_dummy", > @@ -207,9 +223,9 @@ static int imx8qxp_clk_probe(struct platform_device *pdev) > /* MIPI-LVDS SS */ > imx_clk_scu("mipi0_bypass_clk", IMX_SC_R_MIPI_0, IMX_SC_PM_CLK_BYPASS); > imx_clk_scu("mipi0_pixel_clk", IMX_SC_R_MIPI_0, IMX_SC_PM_CLK_PER); > - imx_clk_scu("mipi0_lvds_pixel_clk", IMX_SC_R_LVDS_0, IMX_SC_PM_CLK_MISC2); > imx_clk_scu("mipi0_lvds_bypass_clk", IMX_SC_R_LVDS_0, IMX_SC_PM_CLK_BYPASS); > - imx_clk_scu("mipi0_lvds_phy_clk", IMX_SC_R_LVDS_0, IMX_SC_PM_CLK_MISC3); > + imx_clk_scu2("mipi0_lvds_pixel_clk", lvds0_sels, ARRAY_SIZE(lvds0_sels), IMX_SC_R_LVDS_0, IMX_SC_PM_CLK_MISC2); > + imx_clk_scu2("mipi0_lvds_phy_clk", lvds0_sels, ARRAY_SIZE(lvds0_sels), IMX_SC_R_LVDS_0, IMX_SC_PM_CLK_MISC3); > imx_clk_scu2("mipi0_dsi_tx_esc_clk", mipi_sels, ARRAY_SIZE(mipi_sels), IMX_SC_R_MIPI_0, IMX_SC_PM_CLK_MST_BUS); > imx_clk_scu2("mipi0_dsi_rx_esc_clk", mipi_sels, ARRAY_SIZE(mipi_sels), IMX_SC_R_MIPI_0, IMX_SC_PM_CLK_SLV_BUS); > imx_clk_scu2("mipi0_dsi_phy_clk", mipi_sels, ARRAY_SIZE(mipi_sels), IMX_SC_R_MIPI_0, IMX_SC_PM_CLK_PHY); > @@ -219,9 +235,9 @@ static int imx8qxp_clk_probe(struct platform_device *pdev) > > imx_clk_scu("mipi1_bypass_clk", IMX_SC_R_MIPI_1, IMX_SC_PM_CLK_BYPASS); > imx_clk_scu("mipi1_pixel_clk", IMX_SC_R_MIPI_1, IMX_SC_PM_CLK_PER); > - imx_clk_scu("mipi1_lvds_pixel_clk", IMX_SC_R_LVDS_1, IMX_SC_PM_CLK_MISC2); > imx_clk_scu("mipi1_lvds_bypass_clk", IMX_SC_R_LVDS_1, IMX_SC_PM_CLK_BYPASS); > - imx_clk_scu("mipi1_lvds_phy_clk", IMX_SC_R_LVDS_1, IMX_SC_PM_CLK_MISC3); > + imx_clk_scu2("mipi1_lvds_pixel_clk", lvds1_sels, ARRAY_SIZE(lvds1_sels), IMX_SC_R_LVDS_1, IMX_SC_PM_CLK_MISC2); > + imx_clk_scu2("mipi1_lvds_phy_clk", lvds1_sels, ARRAY_SIZE(lvds1_sels), IMX_SC_R_LVDS_1, IMX_SC_PM_CLK_MISC3); > > imx_clk_scu2("mipi1_dsi_tx_esc_clk", mipi_sels, ARRAY_SIZE(mipi_sels), IMX_SC_R_MIPI_1, IMX_SC_PM_CLK_MST_BUS); > imx_clk_scu2("mipi1_dsi_rx_esc_clk", mipi_sels, ARRAY_SIZE(mipi_sels), IMX_SC_R_MIPI_1, IMX_SC_PM_CLK_SLV_BUS); > -- > 2.34.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83F36C41535 for ; Tue, 19 Dec 2023 16:52:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5xqZ+Hp5TrLi2O6fBdIvJ07VenBWOthmI+FCMjoXKzs=; b=050VNqYYrxLnBB TdysvWuTfJHvAcz1Cv0qsiO4LnCWwvYREj6g+Wuse4hYaG8aZO7F0cPbLwlReiden286kHBiUhVdD eYK/bPnzdAYovcn4+yy93d1Ot6S701cgLNruAgNajeu+4+UaVEHVje2K5ycBgzCkUUGgv7PVGYgeT 8SU6E2njxW0LntyKVfB/EEmDdKNMKr9ErnFzzZK3WEHjZ0cZwx/4qBvwq+9xsudkbzw73z7er6ml1 QI3jGbkvfGRmkVnhMGkdac1UTdS9ErAArhGT2QwaFEgogbnP02UViwUHid18ztPslczu0L9+GG3sI +fyLMITVwFihuRrApoow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFdKX-00EmE5-0E; Tue, 19 Dec 2023 16:52:29 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFdKT-00EmD2-0F for linux-arm-kernel@lists.infradead.org; Tue, 19 Dec 2023 16:52:27 +0000 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-33660cf2296so3795918f8f.3 for ; Tue, 19 Dec 2023 08:52:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703004742; x=1703609542; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zy4Z3eEuLBj08ts84l431wJvHoWWggzPm4qQ5zBcMOE=; b=A3jZ6IGZ/2ryUY8x12TqhM/8GcoJ+2H5hbEJafO4pt1A66Y4HztSSkV7dyscOx3tQ+ 3XpX9mhFLYGsWL0Cyiu5EaCPzLPySU6gv9ZazLJ3cojq9D/BpqhQmwXT03LwGyRaVhTW IyrdJQEXTYt2CPtOUEpCLzpBFazdO8loIwyL+tsHwCHKlTQCi6lAeAl3uB7eAfQ9BKm/ fJCfqgVKS5Nzc6GjQTGEKLqHSC4ANmyEzNz7cKYbMJQephIx3FrGN0xwNapPjxBI7lfA HJJgmTaWKmGvmNEAvZu9y4AcuymgZ9dr06uWM89ec0DNdrMK88MpesgC+SMMOiJxYkER SqpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703004742; x=1703609542; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zy4Z3eEuLBj08ts84l431wJvHoWWggzPm4qQ5zBcMOE=; b=uM8rK7VToc3ADDPNzi+TtAoSUBfrKHO4/Rsgw84/Ig1XFJzaMBZmdBQg+KZ77MK0ZX gBwVNMf6RdNpgkMCKW7H/+tAmbLBxvWOarzVtjEa+Z86vXyHyiMxpWMu4pi8TAnpN8Uh eSc1UJfXZ+yTmcAgPU27ft9s81v40IkHx84uGQhP/7JOX/BVTlA2r3sniXGMs0yn9FNy w/rgvpgkuDgnGx7bzSmZtBVgX9tq7yo/I/Uani1UqrYPNeIZT/pPJIdWCkBuMs2NgQtI KAxVNUNhe+k7esWYAST9eizn+xLXdqqEwYnqNFGYrGhaVDmRdEb/rO8h16C87PKpHYvI O44Q== X-Gm-Message-State: AOJu0YxqSLOdY6SkzM4zFV7+A9L8Q+wNdne9v+E2Qu181oTM88fQ0BLx JMxwF2QQkUf+5nmrC2r57F4ERg== X-Google-Smtp-Source: AGHT+IFIh9biTT2PfAWfIIivnLl6PU1NZBv6rg4KrRM98BXFbXikPQgRjibC9rN/fogphV8WUSVbZA== X-Received: by 2002:adf:f282:0:b0:336:7758:c6f1 with SMTP id k2-20020adff282000000b003367758c6f1mr251211wro.113.1703004742182; Tue, 19 Dec 2023 08:52:22 -0800 (PST) Received: from linaro.org ([79.115.23.25]) by smtp.gmail.com with ESMTPSA id h9-20020a5d4309000000b003366d04b050sm4280826wrq.38.2023.12.19.08.52.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 08:52:21 -0800 (PST) Date: Tue, 19 Dec 2023 18:52:20 +0200 From: Abel Vesa To: Alexander Stein Cc: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Oliver F . Brown" , Ranjani Vaidyanathan Subject: Re: [PATCH 1/1] clk: imx: clk-imx8qxp: fix LVDS bypass, pixel and phy clocks Message-ID: References: <20231218122407.2757175-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231218122407.2757175-1-alexander.stein@ew.tq-group.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231219_085225_117265_D62E45B8 X-CRM114-Status: GOOD ( 20.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23-12-18 13:24:07, Alexander Stein wrote: > To be compatibel with SCU firmware based on 1.15 a different clock > routing for LVDS is needed. > compatible > Signed-off-by: Oliver F. Brown > Signed-off-by: Ranjani Vaidyanathan > Signed-off-by: Alexander Stein With that: Reviewed-by: Abel Vesa > --- > This patch originates from the downstream kernel squashing patches [1] and [2] > as suggested by the commit message. > I adjusted the commit so that the name stays the same as before. > > I am somewhat unsure about the From: tag, as both commits have different > authors. > > Best regards, > Alexander > > [1] https://github.com/Freescale/linux-fslc/commit/05b5fd0eebd0 > [2] https://github.com/Freescale/linux-fslc/commit/0a202c564e5f > drivers/clk/imx/clk-imx8qxp.c | 24 ++++++++++++++++++++---- > 1 file changed, 20 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/imx/clk-imx8qxp.c b/drivers/clk/imx/clk-imx8qxp.c > index 41f0a45aa162..7d8883916cac 100644 > --- a/drivers/clk/imx/clk-imx8qxp.c > +++ b/drivers/clk/imx/clk-imx8qxp.c > @@ -66,6 +66,22 @@ static const char * const lcd_pxl_sels[] = { > "lcd_pxl_bypass_div_clk", > }; > > +static const char *const lvds0_sels[] = { > + "clk_dummy", > + "clk_dummy", > + "clk_dummy", > + "clk_dummy", > + "mipi0_lvds_bypass_clk", > +}; > + > +static const char *const lvds1_sels[] = { > + "clk_dummy", > + "clk_dummy", > + "clk_dummy", > + "clk_dummy", > + "mipi1_lvds_bypass_clk", > +}; > + > static const char * const mipi_sels[] = { > "clk_dummy", > "clk_dummy", > @@ -207,9 +223,9 @@ static int imx8qxp_clk_probe(struct platform_device *pdev) > /* MIPI-LVDS SS */ > imx_clk_scu("mipi0_bypass_clk", IMX_SC_R_MIPI_0, IMX_SC_PM_CLK_BYPASS); > imx_clk_scu("mipi0_pixel_clk", IMX_SC_R_MIPI_0, IMX_SC_PM_CLK_PER); > - imx_clk_scu("mipi0_lvds_pixel_clk", IMX_SC_R_LVDS_0, IMX_SC_PM_CLK_MISC2); > imx_clk_scu("mipi0_lvds_bypass_clk", IMX_SC_R_LVDS_0, IMX_SC_PM_CLK_BYPASS); > - imx_clk_scu("mipi0_lvds_phy_clk", IMX_SC_R_LVDS_0, IMX_SC_PM_CLK_MISC3); > + imx_clk_scu2("mipi0_lvds_pixel_clk", lvds0_sels, ARRAY_SIZE(lvds0_sels), IMX_SC_R_LVDS_0, IMX_SC_PM_CLK_MISC2); > + imx_clk_scu2("mipi0_lvds_phy_clk", lvds0_sels, ARRAY_SIZE(lvds0_sels), IMX_SC_R_LVDS_0, IMX_SC_PM_CLK_MISC3); > imx_clk_scu2("mipi0_dsi_tx_esc_clk", mipi_sels, ARRAY_SIZE(mipi_sels), IMX_SC_R_MIPI_0, IMX_SC_PM_CLK_MST_BUS); > imx_clk_scu2("mipi0_dsi_rx_esc_clk", mipi_sels, ARRAY_SIZE(mipi_sels), IMX_SC_R_MIPI_0, IMX_SC_PM_CLK_SLV_BUS); > imx_clk_scu2("mipi0_dsi_phy_clk", mipi_sels, ARRAY_SIZE(mipi_sels), IMX_SC_R_MIPI_0, IMX_SC_PM_CLK_PHY); > @@ -219,9 +235,9 @@ static int imx8qxp_clk_probe(struct platform_device *pdev) > > imx_clk_scu("mipi1_bypass_clk", IMX_SC_R_MIPI_1, IMX_SC_PM_CLK_BYPASS); > imx_clk_scu("mipi1_pixel_clk", IMX_SC_R_MIPI_1, IMX_SC_PM_CLK_PER); > - imx_clk_scu("mipi1_lvds_pixel_clk", IMX_SC_R_LVDS_1, IMX_SC_PM_CLK_MISC2); > imx_clk_scu("mipi1_lvds_bypass_clk", IMX_SC_R_LVDS_1, IMX_SC_PM_CLK_BYPASS); > - imx_clk_scu("mipi1_lvds_phy_clk", IMX_SC_R_LVDS_1, IMX_SC_PM_CLK_MISC3); > + imx_clk_scu2("mipi1_lvds_pixel_clk", lvds1_sels, ARRAY_SIZE(lvds1_sels), IMX_SC_R_LVDS_1, IMX_SC_PM_CLK_MISC2); > + imx_clk_scu2("mipi1_lvds_phy_clk", lvds1_sels, ARRAY_SIZE(lvds1_sels), IMX_SC_R_LVDS_1, IMX_SC_PM_CLK_MISC3); > > imx_clk_scu2("mipi1_dsi_tx_esc_clk", mipi_sels, ARRAY_SIZE(mipi_sels), IMX_SC_R_MIPI_1, IMX_SC_PM_CLK_MST_BUS); > imx_clk_scu2("mipi1_dsi_rx_esc_clk", mipi_sels, ARRAY_SIZE(mipi_sels), IMX_SC_R_MIPI_1, IMX_SC_PM_CLK_SLV_BUS); > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel