All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Paul Durrant" <paul@xen.org>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Wei Liu" <wl@xen.org>, "Lukasz Hawrylko" <lukasz@hawrylko.pl>,
	"Daniel P. Smith" <dpsmith@apertussolutions.com>,
	"Mateusz Mówka" <mateusz.mowka@intel.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 7/7] x86/iommu: cleanup unused functions
Date: Wed, 20 Dec 2023 11:31:38 +0100	[thread overview]
Message-ID: <ZYLCiq2XLgSP7ZMo@macbook> (raw)
In-Reply-To: <02a8e90e-dc4b-4fda-a2a7-50c12d356c63@suse.com>

On Tue, Dec 19, 2023 at 05:23:57PM +0100, Jan Beulich wrote:
> On 15.12.2023 15:18, Roger Pau Monne wrote:
> > Remove xen_in_range() and vpci_is_mmcfg_address() now that hey are unused.
> > 
> > Adjust comments to point to the new functions that replace the existing ones.
> 
> And because of this affecting what was done earlier in the series, perhaps
> best if patches 5-7 would be committed together.

By committed together do you mean squashed?

I agree that it would be best if the series is committed in one go,
otherwise the comments in the tree can be inconsistent.

> > No functional change.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Thanks.


  reply	other threads:[~2023-12-20 10:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-15 14:18 [PATCH v3 0/7] x86/iommu: improve setup time of hwdom IOMMU Roger Pau Monne
2023-12-15 14:18 ` [PATCH v3 1/7] iommu/vt-d: do not assume page table levels for quarantine domain Roger Pau Monne
2023-12-15 14:18 ` [PATCH v3 2/7] x86/p2m: move and rename paging_max_paddr_bits() Roger Pau Monne
2023-12-19 15:38   ` Jan Beulich
2023-12-15 14:18 ` [PATCH v3 3/7] amd-vi: set IOMMU page table levels based on guest reported paddr width Roger Pau Monne
2023-12-19 15:40   ` Jan Beulich
2023-12-15 14:18 ` [PATCH v3 4/7] x86/iommu: introduce a rangeset to perform hwdom IOMMU setup Roger Pau Monne
2023-12-19 16:06   ` Jan Beulich
2023-12-20  9:52     ` Roger Pau Monné
2023-12-15 14:18 ` [PATCH v3 5/7] x86/iommu: remove regions not to be mapped Roger Pau Monne
2023-12-19 16:18   ` Jan Beulich
2023-12-20 10:22     ` Roger Pau Monné
2023-12-15 14:18 ` [PATCH v3 6/7] x86/iommu: switch hwdom IOMMU to use a rangeset Roger Pau Monne
2023-12-19 16:21   ` Jan Beulich
2023-12-15 14:18 ` [PATCH v3 7/7] x86/iommu: cleanup unused functions Roger Pau Monne
2023-12-19 16:23   ` Jan Beulich
2023-12-20 10:31     ` Roger Pau Monné [this message]
2023-12-20 10:36       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZYLCiq2XLgSP7ZMo@macbook \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=dpsmith@apertussolutions.com \
    --cc=jbeulich@suse.com \
    --cc=lukasz@hawrylko.pl \
    --cc=mateusz.mowka@intel.com \
    --cc=paul@xen.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.