From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Esther Shimanovich <eshima@google.com>
Cc: Esther Shimanovich <eshimanovich@chromium.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Rajat Jain <rajatja@google.com>
Subject: Re: [PATCH v2] PCI: Relabel JHL6540 on Lenovo X1 Carbon 7,8
Date: Wed, 20 Dec 2023 14:03:57 -0800 [thread overview]
Message-ID: <ZYNkzdw7FzlTQqty@google.com> (raw)
In-Reply-To: <CAK5fCsAAXLaXBCy_pBEaynog=xjuZNSP2b0edwrcZ_3Vo4xxCQ@mail.gmail.com>
On Wed, Dec 20, 2023 at 02:46:20PM -0500, Esther Shimanovich wrote:
> > Again, maybe PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_C_4C_BRIDGE?
>
> Question--- PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_C_4C_BRIDGE is defined in
> "drivers/thunderbolt/nhi.h" as opposed to "include/linux/pci_ids.h".
> It seems like the ids in "drivers/thunderbolt/nhi.h" are specifically
> for use within the thunderbolt driver only. Would you want me to move
> it into pci_ids.h so that I could use it here? Or could I ignore this
> suggestion? My personal inclination is that that would make more sense
> to do in a separate refactoring patch.
I'll leave that decision to PCI maintainers.
Thanks.
--
Dmitry
prev parent reply other threads:[~2023-12-20 22:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 21:34 [PATCH v2] PCI: Relabel JHL6540 on Lenovo X1 Carbon 7,8 Esther Shimanovich
2023-12-19 22:15 ` Dmitry Torokhov
2023-12-19 23:19 ` Esther Shimanovich
2023-12-20 1:38 ` Dmitry Torokhov
2023-12-20 19:46 ` Esther Shimanovich
2023-12-20 22:03 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYNkzdw7FzlTQqty@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=bhelgaas@google.com \
--cc=eshima@google.com \
--cc=eshimanovich@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rajatja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.