All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Young <sean@mess.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-media@vger.kernel.org, linux-pwm@vger.kernel.org,
	"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: (subset) [PATCH v10 0/6] Improve pwm-ir-tx precision
Date: Thu, 21 Dec 2023 09:09:25 +0000	[thread overview]
Message-ID: <ZYQAxflmh2_hjMK2@gofer.mess.org> (raw)
In-Reply-To: <ZYMRyijtS4mUXia1@orome.fritz.box>

On Wed, Dec 20, 2023 at 05:09:46PM +0100, Thierry Reding wrote:
> On Wed, Dec 20, 2023 at 05:06:06PM +0100, Thierry Reding wrote:
> > On Tue, 19 Dec 2023 16:30:23 +0000, Sean Young wrote:
> > > The pwm-ir-tx driver has to turn the pwm signal on and off, and suffers
> > > from delays as this is done in process context. Make this work in atomic
> > > context.
> > > 
> > > changes:
> > > 
> > > v10:
> > >  - Uwe Kleine-König review comments/fixes
> > > 
> > > [...]
> > 
> > Applied, thanks!
> > 
> > [6/6] media: pwm-ir-tx: Trigger edges from hrtimer interrupt context
> >       commit: 363d0e56285e80cda997d41d94c22313b673557d
> 
> Hi Sean,
> 
> I actually applied all of them (except I took patch 5 from v11), not
> sure why b4 only kept track of patch 6.

Great, thank you. I'm very pleased about this: the pwm-ir-tx driver
now produces an prefect signal on rpi. The alternative driver, gpio-ir-tx,
bitbangs and holds the cpu under spinlock for 100ms or however long the
signal is, which is just a disaster (for e.g. real time linux). This gives
us a way out.

> Mauro didn't reply when I asked
> whether he's okay with me picking this up into the PWM tree, but given
> that you're the pwm-ir-tx maintainer I think that'll be fine. If not I
> can back this out again.

Mauro is not very responsive nowadays, but I'm sure it's fine.


Sean

      reply	other threads:[~2023-12-21  9:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-19 16:30 [PATCH v10 0/6] Improve pwm-ir-tx precision Sean Young
2023-12-19 16:30 ` [PATCH v10 1/6] pwm: Rename pwm_apply_state() to pwm_apply_might_sleep() Sean Young
2023-12-19 16:30   ` Sean Young
2023-12-19 16:30   ` Sean Young
2023-12-19 16:30 ` [PATCH v10 2/6] pwm: Replace ENOTSUPP with EOPNOTSUPP Sean Young
2023-12-19 17:01   ` Uwe Kleine-König
2023-12-19 16:30 ` [PATCH v10 3/6] pwm: renesas: Remove unused include Sean Young
2023-12-19 16:30 ` [PATCH v10 4/6] pwm: Make it possible to apply PWM changes in atomic context Sean Young
2023-12-20 10:31   ` Uwe Kleine-König
2023-12-19 16:30 ` [PATCH v10 5/6] pwm: bcm2835: Allow PWM driver to be used " Sean Young
2023-12-19 16:30   ` Sean Young
2023-12-19 16:58   ` Uwe Kleine-König
2023-12-19 16:58     ` Uwe Kleine-König
2023-12-19 16:30 ` [PATCH v10 6/6] media: pwm-ir-tx: Trigger edges from hrtimer interrupt context Sean Young
2023-12-20 16:06 ` (subset) [PATCH v10 0/6] Improve pwm-ir-tx precision Thierry Reding
2023-12-20 16:09   ` Thierry Reding
2023-12-21  9:09     ` Sean Young [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZYQAxflmh2_hjMK2@gofer.mess.org \
    --to=sean@mess.org \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.