From: Jiri Olsa <olsajiri@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: daniel@iogearbox.net, andrii@kernel.org, martin.lau@kernel.org,
dxu@dxuuu.xyz, memxor@gmail.com, john.fastabend@gmail.com,
bpf@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v2 bpf-next 0/5] bpf: volatile compare
Date: Thu, 21 Dec 2023 19:01:51 +0100 [thread overview]
Message-ID: <ZYR9jwJOgRjW0YYr@krava> (raw)
In-Reply-To: <20231221033854.38397-1-alexei.starovoitov@gmail.com>
On Wed, Dec 20, 2023 at 07:38:49PM -0800, Alexei Starovoitov wrote:
> From: Alexei Starovoitov <ast@kernel.org>
>
> v1->v2:
> Fixed issues pointed out by Daniel, added more tests, attempted to convert profiler.c,
> but barrier_var() wins vs bpf_cmp(). To be investigated.
> Patches 1-4 are good to go, but 5 needs more work.
>
> Alexei Starovoitov (5):
> selftests/bpf: Attempt to build BPF programs with -Wsign-compare
> bpf: Introduce "volatile compare" macro
> selftests/bpf: Convert exceptions_assert.c to bpf_cmp
> selftests/bpf: Remove bpf_assert_eq-like macros.
> selftests/bpf: Attempt to convert profiler.c to bpf_cmp.
lgtm, for patches 1-4:
Acked-by: Jiri Olsa <jolsa@kernel.org>
jirka
>
> tools/testing/selftests/bpf/Makefile | 1 +
> .../testing/selftests/bpf/bpf_experimental.h | 194 ++++--------------
> .../bpf/progs/bpf_iter_bpf_percpu_hash_map.c | 2 +-
> .../selftests/bpf/progs/bpf_iter_task_vmas.c | 2 +-
> .../selftests/bpf/progs/bpf_iter_tasks.c | 2 +-
> .../selftests/bpf/progs/bpf_iter_test_kern4.c | 2 +-
> .../progs/cgroup_getset_retval_setsockopt.c | 2 +-
> .../selftests/bpf/progs/cgrp_ls_sleepable.c | 2 +-
> .../selftests/bpf/progs/cpumask_success.c | 2 +-
> .../testing/selftests/bpf/progs/exceptions.c | 20 +-
> .../selftests/bpf/progs/exceptions_assert.c | 80 ++++----
> tools/testing/selftests/bpf/progs/iters.c | 4 +-
> .../selftests/bpf/progs/iters_task_vma.c | 3 +-
> .../selftests/bpf/progs/linked_funcs1.c | 2 +-
> .../selftests/bpf/progs/linked_funcs2.c | 2 +-
> .../testing/selftests/bpf/progs/linked_list.c | 2 +-
> .../selftests/bpf/progs/local_storage.c | 2 +-
> tools/testing/selftests/bpf/progs/lsm.c | 2 +-
> .../selftests/bpf/progs/normal_map_btf.c | 2 +-
> .../selftests/bpf/progs/profiler.inc.h | 71 ++-----
> tools/testing/selftests/bpf/progs/profiler2.c | 1 +
> tools/testing/selftests/bpf/progs/profiler3.c | 1 +
> .../selftests/bpf/progs/sockopt_inherit.c | 2 +-
> .../selftests/bpf/progs/sockopt_multi.c | 2 +-
> .../selftests/bpf/progs/sockopt_qos_to_cc.c | 2 +-
> .../testing/selftests/bpf/progs/test_bpf_ma.c | 2 +-
> .../bpf/progs/test_core_reloc_kernel.c | 2 +-
> .../bpf/progs/test_core_reloc_module.c | 8 +-
> .../selftests/bpf/progs/test_fsverity.c | 2 +-
> .../bpf/progs/test_skc_to_unix_sock.c | 2 +-
> .../bpf/progs/test_xdp_do_redirect.c | 2 +-
> 31 files changed, 146 insertions(+), 279 deletions(-)
>
> --
> 2.34.1
>
>
prev parent reply other threads:[~2023-12-21 18:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 3:38 [PATCH v2 bpf-next 0/5] bpf: volatile compare Alexei Starovoitov
2023-12-21 3:38 ` [PATCH v2 bpf-next 1/5] selftests/bpf: Attempt to build BPF programs with -Wsign-compare Alexei Starovoitov
2023-12-21 3:38 ` [PATCH v2 bpf-next 2/5] bpf: Introduce "volatile compare" macro Alexei Starovoitov
2023-12-21 4:27 ` Kumar Kartikeya Dwivedi
2023-12-22 22:59 ` Alexei Starovoitov
2023-12-25 20:33 ` Alexei Starovoitov
2024-01-04 20:06 ` Eduard Zingerman
2024-01-04 21:02 ` Alexei Starovoitov
2024-01-05 21:47 ` Eduard Zingerman
2024-01-08 21:21 ` Yonghong Song
2024-01-08 23:16 ` Eduard Zingerman
2024-01-08 21:33 ` asm register constraint. Was: " Alexei Starovoitov
2024-01-08 23:22 ` Yonghong Song
2024-01-09 10:49 ` Jose E. Marchesi
2024-01-09 12:09 ` Jose E. Marchesi
2024-01-11 18:33 ` Jose E. Marchesi
2024-01-15 16:33 ` Eduard Zingerman
2024-01-16 17:47 ` Alexei Starovoitov
2024-01-16 19:07 ` Yonghong Song
2024-01-16 19:34 ` Alexei Starovoitov
2024-01-16 23:14 ` Yonghong Song
2024-01-17 22:43 ` Alexei Starovoitov
2024-01-16 23:55 ` Eduard Zingerman
2024-01-16 18:40 ` Alexei Starovoitov
2024-01-16 23:15 ` Eduard Zingerman
2024-01-11 2:46 ` Alexei Starovoitov
2024-01-11 10:34 ` Jose E. Marchesi
2024-01-11 16:46 ` Eduard Zingerman
2023-12-21 3:38 ` [PATCH v2 bpf-next 3/5] selftests/bpf: Convert exceptions_assert.c to bpf_cmp Alexei Starovoitov
2023-12-21 3:38 ` [PATCH v2 bpf-next 4/5] selftests/bpf: Remove bpf_assert_eq-like macros Alexei Starovoitov
2023-12-21 3:38 ` [RFC PATCH v2 bpf-next 5/5] selftests/bpf: Attempt to convert profiler.c to bpf_cmp Alexei Starovoitov
2023-12-21 18:01 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYR9jwJOgRjW0YYr@krava \
--to=olsajiri@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dxu@dxuuu.xyz \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@fb.com \
--cc=martin.lau@kernel.org \
--cc=memxor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.