From: Benjamin Poirier <benjamin.poirier@gmail.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Jay Vosburgh <jay.vosburgh@canonical.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] selftests: bonding: do not set port down when adding to bond
Date: Sat, 23 Dec 2023 17:54:26 -0500 [thread overview]
Message-ID: <ZYdlIskJQhAqkBvu@d3> (raw)
In-Reply-To: <20231223125922.3280841-1-liuhangbin@gmail.com>
On 2023-12-23 20:59 +0800, Hangbin Liu wrote:
> Similar to commit be809424659c ("selftests: bonding: do not set port down
> before adding to bond"). The bond-arp-interval-causes-panic test failed
> after commit a4abfa627c38 ("net: rtnetlink: Enslave device before bringing
> it up") as the kernel will set the port down _after_ adding to bond if setting
> port down specifically.
>
> Fix it by removing the link down operation when adding to bond.
>
> Fixes: 2ffd57327ff1 ("selftests: bonding: cause oops in bond_rr_gen_slave_id")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
Tested-by: Benjamin Poirier <benjamin.poirier@gmail.com>
next prev parent reply other threads:[~2023-12-23 22:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-23 12:59 [PATCH net] selftests: bonding: do not set port down when adding to bond Hangbin Liu
2023-12-23 22:54 ` Benjamin Poirier [this message]
2024-01-02 14:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYdlIskJQhAqkBvu@d3 \
--to=benjamin.poirier@gmail.com \
--cc=davem@davemloft.net \
--cc=jay.vosburgh@canonical.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.