From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out198-156.us.a.mail.aliyun.com (out198-156.us.a.mail.aliyun.com [47.90.198.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1D7E35F03 for ; Mon, 25 Dec 2023 10:11:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sjterm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sjterm.com X-Alimail-AntiSpam:AC=CONTINUE;BC=0.07467577|-1;BR=01201311R751ec;CH=green;DM=|CONTINUE|false|;DS=SPAM|spam_ad|0.839325-0.000325292-0.160349;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047213;MF=fuyao@sjterm.com;NM=1;PH=DS;RN=16;RT=16;SR=0;TI=SMTPD_---.VsSYimv_1703499085; Received: from localhost(mailfrom:fuyao@sjterm.com fp:SMTPD_---.VsSYimv_1703499085) by smtp.aliyun-inc.com; Mon, 25 Dec 2023 18:11:25 +0800 Date: Mon, 25 Dec 2023 18:11:24 +0800 From: fuyao To: Andre Przywara Cc: fuyao , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Alexandre TORGUE , Enric Balletbo i Serra , Baruch Siach , Paul Barker , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] ARM: dts: sun8i: r40: open the regulator aldo1 Message-ID: Mail-Followup-To: Andre Przywara , fuyao , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Alexandre TORGUE , Enric Balletbo i Serra , Baruch Siach , Paul Barker , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org References: <20231220150400.0f32e2a5@donnerap.manchester.arm.com> <20231221103906.1830ef94@donnerap.manchester.arm.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231221103906.1830ef94@donnerap.manchester.arm.com> Organization: work_work_work On Thu, Dec 21, 2023 at 10:39:06AM +0000, Andre Przywara wrote: > On Thu, 21 Dec 2023 10:20:49 +0800 > fuyao wrote: > > Hi, > > thanks for the reply! > > > On Wed, Dec 20, 2023 at 03:04:00PM +0000, Andre Przywara wrote: > > > On Wed, 20 Dec 2023 16:18:43 +0800 > > > fuyao wrote: > > > > > > Hi, > > > > > > > the aldo1 is connect regulator pin which power the TV. > > > > > > What do you mean with that? That ALDO1 is connected to VCC-TVOUT and/or > > > VCC-TVIN on the R40 SoC? > > > > The ALDO1 is connected to VCC-TVOUT on the R40 Soc. > > Ah, thanks for the confirmation. > > > > > The USB core use TV ref as reference Voltage. > > > > > > The USB core in the SoC? So pin VCC-USB, which requires 3.3V, the same > > > voltage as the TV pins? > > > Which means this doesn't really have much to do with TV, it's just that > > > USB and also "TV" are supplied by ALDO1? > > > > The internal USB PHY requires a reference voltage. It seems that in > > order to save costs, the reference voltage of the TVOUT module is used. > > Do you mean a USB *reference* voltage that is separate from the USB PHY > power supply voltage, so pin VCC-USB on the SoC? And that it is internally > connected to some TV-OUT related circuits? So that would apply to all > devices using the R40 SoC then? yes, The usb need a power from TV module insides. > > Or is it simply that the SoC pins VCC-TVOUT and VCC-USB are connected > together, on this SoM? no > Do you have access to some schematic? I couldn't find one online easily, > so cannot check this myself. > It has up to https://file.io/VSUL4FDrapDY > Thanks, > Andre > > > > > Signed-off-by: fuyao > > > > --- > > > > arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi | 7 +++++++ > > > > 1 file changed, 7 insertions(+) > > > > > > > > diff --git a/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi b/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi > > > > index 9f39b5a2bb35..8906170461df 100644 > > > > --- a/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi > > > > +++ b/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi > > > > @@ -42,6 +42,13 @@ &pio { > > > > vcc-pg-supply = <®_dldo1>; > > > > }; > > > > > > > > +®_aldo1 { > > > > + regulator-always-on; > > > > > > So did USB never work before, with the DT as in mainline? > > > > > > > The USB can work, but is unstable. Occasionally disconnected because of > > the D+/D- electrical characteristics. > > > > > For always-on regulators it would be good to see some rationale why this > > > cannot be referenced by its consumer. If it is really supplying the USB > > > core, that would be a reason, because we don't have a good way of > > > describing this. > > > > > > > + regulator-min-microvolt = <3300000>; > > > > + regulator-max-microvolt = <3300000>; > > > > + regulator-name = "vcc-aldo1"; > > > > > > Regulators should be named after their users, so use something like: > > > regulator-name = "vcc-3v3-tv-usb"; > > > > > > > thanks. > > > > > That then also serves as documentation of why this is always on. > > > > > > Cheers, > > > Andre > > > > > > > +}; > > > > + > > > > ®_aldo2 { > > > > regulator-always-on; > > > > regulator-min-microvolt = <1800000>; > > > > > -- fuyao [付尧] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41DF3C3DA6E for ; Mon, 25 Dec 2023 10:12:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6oDzFevIPTNU9N0ySeItTAoOlBdNIoVlbm9W8hsx5is=; b=uz6RxCBDR4EHJd 8dN6ZCfu+VHgjQvMuHP70YLa5MwFYYdrLHgGzdZvdhnxF4C+miP5YffjA3aPtwS2a04j+IfDkbpfl N2NLdkJTqiGEesLixqESknDIyaZCjUU1xpybsCxnoZmjJyXNzbZc51HrqfIU9127m7Tbv54PZmn+W D1GVAhZUIIHPqa+Dh1l2pAcyTpz9jGqjvMDA+VEip7f0yvxoXqhMNpJdzYQulm8iCcV7r4hiARFbz EQDbY4COFDhdn7fMPhzEBgptYyTw674QkHsmlgsm3PHxm55eC/4T11xf8RuR6DL9Nx6KGnthVBq8a SN/AbfAd6CxAt7GflRLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rHhvp-00AW9q-2X; Mon, 25 Dec 2023 10:11:33 +0000 Received: from out28-44.mail.aliyun.com ([115.124.28.44]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rHhvm-00AW9L-0J for linux-arm-kernel@lists.infradead.org; Mon, 25 Dec 2023 10:11:32 +0000 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.07467577|-1;BR=01201311R751ec;CH=green;DM=|CONTINUE|false|;DS=SPAM|spam_ad|0.839325-0.000325292-0.160349;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047213;MF=fuyao@sjterm.com;NM=1;PH=DS;RN=16;RT=16;SR=0;TI=SMTPD_---.VsSYimv_1703499085; Received: from localhost(mailfrom:fuyao@sjterm.com fp:SMTPD_---.VsSYimv_1703499085) by smtp.aliyun-inc.com; Mon, 25 Dec 2023 18:11:25 +0800 Date: Mon, 25 Dec 2023 18:11:24 +0800 From: fuyao To: Andre Przywara Cc: fuyao , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Alexandre TORGUE , Enric Balletbo i Serra , Baruch Siach , Paul Barker , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] ARM: dts: sun8i: r40: open the regulator aldo1 Message-ID: Mail-Followup-To: Andre Przywara , fuyao , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Alexandre TORGUE , Enric Balletbo i Serra , Baruch Siach , Paul Barker , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org References: <20231220150400.0f32e2a5@donnerap.manchester.arm.com> <20231221103906.1830ef94@donnerap.manchester.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231221103906.1830ef94@donnerap.manchester.arm.com> Organization: work_work_work X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231225_021130_419466_5886CE2F X-CRM114-Status: GOOD ( 38.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBEZWMgMjEsIDIwMjMgYXQgMTA6Mzk6MDZBTSArMDAwMCwgQW5kcmUgUHJ6eXdhcmEg d3JvdGU6Cj4gT24gVGh1LCAyMSBEZWMgMjAyMyAxMDoyMDo0OSArMDgwMAo+IGZ1eWFvIDxmdXlh b0BzanRlcm0uY29tPiB3cm90ZToKPiAKPiBIaSwKPiAKPiB0aGFua3MgZm9yIHRoZSByZXBseSEK PiAKPiA+IE9uIFdlZCwgRGVjIDIwLCAyMDIzIGF0IDAzOjA0OjAwUE0gKzAwMDAsIEFuZHJlIFBy enl3YXJhIHdyb3RlOgo+ID4gPiBPbiBXZWQsIDIwIERlYyAyMDIzIDE2OjE4OjQzICswODAwCj4g PiA+IGZ1eWFvIDxmdXlhbzE2OTdAY3lnLmNvbT4gd3JvdGU6Cj4gPiA+IAo+ID4gPiBIaSwKPiA+ ID4gICAKPiA+ID4gPiB0aGUgYWxkbzEgaXMgY29ubmVjdCByZWd1bGF0b3IgcGluIHdoaWNoIHBv d2VyIHRoZSBUVi4gIAo+ID4gPiAKPiA+ID4gV2hhdCBkbyB5b3UgbWVhbiB3aXRoIHRoYXQ/IFRo YXQgQUxETzEgaXMgY29ubmVjdGVkIHRvIFZDQy1UVk9VVCBhbmQvb3IKPiA+ID4gVkNDLVRWSU4g b24gdGhlIFI0MCBTb0M/ICAKPiA+IAo+ID4gVGhlIEFMRE8xIGlzIGNvbm5lY3RlZCB0byBWQ0Mt VFZPVVQgb24gdGhlIFI0MCBTb2MuCj4gCj4gQWgsIHRoYW5rcyBmb3IgdGhlIGNvbmZpcm1hdGlv bi4KPiAKPiA+ID4gPiBUaGUgVVNCIGNvcmUgdXNlIFRWIHJlZiBhcyByZWZlcmVuY2UgVm9sdGFn ZS4gIAo+ID4gPiAKPiA+ID4gVGhlIFVTQiBjb3JlIGluIHRoZSBTb0M/IFNvIHBpbiBWQ0MtVVNC LCB3aGljaCByZXF1aXJlcyAzLjNWLCB0aGUgc2FtZQo+ID4gPiB2b2x0YWdlIGFzIHRoZSBUViBw aW5zPwo+ID4gPiBXaGljaCBtZWFucyB0aGlzIGRvZXNuJ3QgcmVhbGx5IGhhdmUgbXVjaCB0byBk byB3aXRoIFRWLCBpdCdzIGp1c3QgdGhhdAo+ID4gPiBVU0IgYW5kIGFsc28gIlRWIiBhcmUgc3Vw cGxpZWQgYnkgQUxETzE/ICAKPiA+IAo+ID4gVGhlIGludGVybmFsIFVTQiBQSFkgcmVxdWlyZXMg YSByZWZlcmVuY2Ugdm9sdGFnZS4gSXQgc2VlbXMgdGhhdCBpbgo+ID4gb3JkZXIgdG8gc2F2ZSBj b3N0cywgdGhlIHJlZmVyZW5jZSB2b2x0YWdlIG9mIHRoZSBUVk9VVCBtb2R1bGUgaXMgdXNlZC4K PiAKPiBEbyB5b3UgbWVhbiBhIFVTQiAqcmVmZXJlbmNlKiB2b2x0YWdlIHRoYXQgaXMgc2VwYXJh dGUgZnJvbSB0aGUgVVNCIFBIWQo+IHBvd2VyIHN1cHBseSB2b2x0YWdlLCBzbyBwaW4gVkNDLVVT QiBvbiB0aGUgU29DPyBBbmQgdGhhdCBpdCBpcyBpbnRlcm5hbGx5Cj4gY29ubmVjdGVkIHRvIHNv bWUgVFYtT1VUIHJlbGF0ZWQgY2lyY3VpdHM/IFNvIHRoYXQgd291bGQgYXBwbHkgdG8gYWxsCj4g ZGV2aWNlcyB1c2luZyB0aGUgUjQwIFNvQyB0aGVuPwp5ZXMsIFRoZSB1c2IgbmVlZCBhIHBvd2Vy IGZyb20gVFYgbW9kdWxlIGluc2lkZXMuCj4gCj4gT3IgaXMgaXQgc2ltcGx5IHRoYXQgdGhlIFNv QyBwaW5zIFZDQy1UVk9VVCBhbmQgVkNDLVVTQiBhcmUgY29ubmVjdGVkCj4gdG9nZXRoZXIsIG9u IHRoaXMgU29NPwpubwo+IERvIHlvdSBoYXZlIGFjY2VzcyB0byBzb21lIHNjaGVtYXRpYz8gSSBj b3VsZG4ndCBmaW5kIG9uZSBvbmxpbmUgZWFzaWx5LAo+IHNvIGNhbm5vdCBjaGVjayB0aGlzIG15 c2VsZi4KPiAKSXQgaGFzIHVwIHRvIGh0dHBzOi8vZmlsZS5pby9WU1VMNEZEcmFwRFkKPiBUaGFu a3MsCj4gQW5kcmUKPiAKPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBmdXlhbyA8ZnV5YW8xNjk3QGN5 Zy5jb20+Cj4gPiA+ID4gLS0tCj4gPiA+ID4gIGFyY2gvYXJtL2Jvb3QvZHRzL2FsbHdpbm5lci9z dW44aS1yNDAtZmV0YTQwaS5kdHNpIHwgNyArKysrKysrCj4gPiA+ID4gIDEgZmlsZSBjaGFuZ2Vk LCA3IGluc2VydGlvbnMoKykKPiA+ID4gPiAKPiA+ID4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0v Ym9vdC9kdHMvYWxsd2lubmVyL3N1bjhpLXI0MC1mZXRhNDBpLmR0c2kgYi9hcmNoL2FybS9ib290 L2R0cy9hbGx3aW5uZXIvc3VuOGktcjQwLWZldGE0MGkuZHRzaQo+ID4gPiA+IGluZGV4IDlmMzli NWEyYmIzNS4uODkwNjE3MDQ2MWRmIDEwMDY0NAo+ID4gPiA+IC0tLSBhL2FyY2gvYXJtL2Jvb3Qv ZHRzL2FsbHdpbm5lci9zdW44aS1yNDAtZmV0YTQwaS5kdHNpCj4gPiA+ID4gKysrIGIvYXJjaC9h cm0vYm9vdC9kdHMvYWxsd2lubmVyL3N1bjhpLXI0MC1mZXRhNDBpLmR0c2kKPiA+ID4gPiBAQCAt NDIsNiArNDIsMTMgQEAgJnBpbyB7Cj4gPiA+ID4gIAl2Y2MtcGctc3VwcGx5ID0gPCZyZWdfZGxk bzE+Owo+ID4gPiA+ICB9Owo+ID4gPiA+ICAKPiA+ID4gPiArJnJlZ19hbGRvMSB7Cj4gPiA+ID4g KwlyZWd1bGF0b3ItYWx3YXlzLW9uOyAgCj4gPiA+IAo+ID4gPiBTbyBkaWQgVVNCIG5ldmVyIHdv cmsgYmVmb3JlLCB3aXRoIHRoZSBEVCBhcyBpbiBtYWlubGluZT8KPiA+ID4gICAKPiA+IAo+ID4g VGhlIFVTQiBjYW4gd29yaywgYnV0IGlzIHVuc3RhYmxlLiBPY2Nhc2lvbmFsbHkgZGlzY29ubmVj dGVkIGJlY2F1c2Ugb2YKPiA+IHRoZSBEKy9ELSBlbGVjdHJpY2FsIGNoYXJhY3RlcmlzdGljcy4K PiA+IAo+ID4gPiBGb3IgYWx3YXlzLW9uIHJlZ3VsYXRvcnMgaXQgd291bGQgYmUgZ29vZCB0byBz ZWUgc29tZSByYXRpb25hbGUgd2h5IHRoaXMKPiA+ID4gY2Fubm90IGJlIHJlZmVyZW5jZWQgYnkg aXRzIGNvbnN1bWVyLiBJZiBpdCBpcyByZWFsbHkgc3VwcGx5aW5nIHRoZSBVU0IKPiA+ID4gY29y ZSwgdGhhdCB3b3VsZCBiZSBhIHJlYXNvbiwgYmVjYXVzZSB3ZSBkb24ndCBoYXZlIGEgZ29vZCB3 YXkgb2YKPiA+ID4gZGVzY3JpYmluZyB0aGlzLgo+ID4gPiAgIAo+ID4gPiA+ICsJcmVndWxhdG9y LW1pbi1taWNyb3ZvbHQgPSA8MzMwMDAwMD47Cj4gPiA+ID4gKwlyZWd1bGF0b3ItbWF4LW1pY3Jv dm9sdCA9IDwzMzAwMDAwPjsKPiA+ID4gPiArCXJlZ3VsYXRvci1uYW1lID0gInZjYy1hbGRvMSI7 ICAKPiA+ID4gCj4gPiA+IFJlZ3VsYXRvcnMgc2hvdWxkIGJlIG5hbWVkIGFmdGVyIHRoZWlyIHVz ZXJzLCBzbyB1c2Ugc29tZXRoaW5nIGxpa2U6Cj4gPiA+IAlyZWd1bGF0b3ItbmFtZSA9ICJ2Y2Mt M3YzLXR2LXVzYiI7Cj4gPiA+ICAgCj4gPiAKPiA+IHRoYW5rcy4KPiA+IAo+ID4gPiBUaGF0IHRo ZW4gYWxzbyBzZXJ2ZXMgYXMgZG9jdW1lbnRhdGlvbiBvZiB3aHkgdGhpcyBpcyBhbHdheXMgb24u Cj4gPiA+IAo+ID4gPiBDaGVlcnMsCj4gPiA+IEFuZHJlCj4gPiA+ICAgCj4gPiA+ID4gK307Cj4g PiA+ID4gKwo+ID4gPiA+ICAmcmVnX2FsZG8yIHsKPiA+ID4gPiAgCXJlZ3VsYXRvci1hbHdheXMt b247Cj4gPiA+ID4gIAlyZWd1bGF0b3ItbWluLW1pY3Jvdm9sdCA9IDwxODAwMDAwPjsgIAo+ID4g PiAgIAo+ID4gCgotLSAKZnV5YW8gW+S7mOWwp10KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK