From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B8DA1DFE8; Wed, 27 Dec 2023 18:35:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z+okM2UP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7BF2C433C7; Wed, 27 Dec 2023 18:35:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703702157; bh=0siblmpSE3KVqzpkVehEyjAK/TXGvMOcCY6Sg22LjFk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z+okM2UPtZvpqDe2UxBEUhMFMY05kH1/mlKCbek+O2bzesZLs7yZVmy1hcDhscxY6 5oUBNI9vp6zmRW9vu8ZmOHdWiKuqpM7UZoiojjcQqamytmNifU3mqaOKez4TsRNLp7 /VJ5LXD5VLWeNb2N8vrNnWeaffF4jpDPCfIQ0HpR9G41q5NYbH6J/pyijpIMkc4tBH 7LF1nsxObXxnsbPOGNyvpLFY4mShT1jzpD+cRw5TdiklWxDKe2Y63Vkoic74VxLpbf 1qR/pfaGdQxMkKAiduWwWmdhqnFd/GLZBen4weUNLoc+RlWnQn8v27yrnOOSuRq4qy KGPhIUqlsFXXA== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rIYkz-00024a-0q; Wed, 27 Dec 2023 19:35:53 +0100 Date: Wed, 27 Dec 2023 19:35:53 +0100 From: Johan Hovold To: Felix Zhang Cc: Johan Hovold , Luiz Augusto von Dentz , Marcel Holtmann , Johan Hedberg , Hector Martin , Sven Peter , Alyssa Rosenzweig , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] Bluetooth: hci_bcm4377: do not mark valid bd_addr as invalid Message-ID: References: <20231227101003.10534-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Dec 27, 2023 at 01:19:39PM -0500, Felix Zhang wrote: > On Wed, 2023-12-27 at 11:10 +0100, Johan Hovold wrote: > > A recent commit restored the original (and still documented) > > semantics > > for the HCI_QUIRK_USE_BDADDR_PROPERTY quirk so that the device > > address > > is considered invalid unless an address is provided by firmware. > > > > This specifically means that this flag must only be set for devices > > with > > invalid addresses, but the Broadcom BCM4377 driver has so far been > > setting this flag unconditionally. > > > > Fortunately the driver already checks for invalid addresses during > > setup > > and sets the HCI_QUIRK_INVALID_BDADDR flag, which can simply be > > replaced > > with HCI_QUIRK_USE_BDADDR_PROPERTY to indicate that the default > > address > > is invalid but can be overridden by firmware (long term, this should > > probably just always be allowed). > > > > Fixes: 6945795bc81a ("Bluetooth: fix use-bdaddr-property quirk") > > Cc: stable@vger.kernel.org      # 6.5 > > Reported-by: Felix Zhang > > Link: > > https://lore.kernel.org/r/77419ffacc5b4875e920e038332575a2a5bff29f.camel@mrman314.tech/ > > Signed-off-by: Johan Hovold > Thanks for the patch! I have just tested the patch on my MacBookAir9,1 > with some modifications to make it patch with the master branch of the > Linux kernel, and it works great! The device is recognized by the > system; and I can scan, pair, connect, and play audio just fine. If > you want me to send over the modified patch that I have used, please > let me know. Thanks for confirming. You should not need to modify the patch, though, as it has been created against 6.7-rc6 and there hasn't been any changes to this driver since rc1. Johan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F977C46CD4 for ; Wed, 27 Dec 2023 18:36:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hPC5fRLt4PkSIkGTf/5Ub0ogtW03ok/a+OiMBwEYRLE=; b=XyH6Me0DmfF00s g3KJdDf1MMIL+pZSDj8+w3wqPvlpsTN6v6H8W2QYo9hmN/lqW9rvfy8WrPu3YxQ2dpXfFxEOum+nI NMNb1Ybdf9Z/rb5M6w5+DCV2W3M7dYhaysZgjtDLEUe6uRD1RJtrzFEm3D/uqxccDN8Wgk3XrRX9y puMnt9JtflcAW82OOGhmCGpbOf11iTxl+WICWp9PNLxoPlGodF5bwdXIRI84dfT3oyyl8E2zYpBY6 a7XcAlfCSuKFRwD+GZRjkiEeGQz+VuOYG2pquR3tU/L0QMpwCwfSA+W8piT6n9c/2KVVGYP+AjN/m kbCogu6rCJtIAtQWcYqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rIYlD-00FKHT-0s; Wed, 27 Dec 2023 18:36:07 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rIYlA-00FKGn-1P for linux-arm-kernel@lists.infradead.org; Wed, 27 Dec 2023 18:36:05 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 20BA2601D5; Wed, 27 Dec 2023 18:35:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7BF2C433C7; Wed, 27 Dec 2023 18:35:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703702157; bh=0siblmpSE3KVqzpkVehEyjAK/TXGvMOcCY6Sg22LjFk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z+okM2UPtZvpqDe2UxBEUhMFMY05kH1/mlKCbek+O2bzesZLs7yZVmy1hcDhscxY6 5oUBNI9vp6zmRW9vu8ZmOHdWiKuqpM7UZoiojjcQqamytmNifU3mqaOKez4TsRNLp7 /VJ5LXD5VLWeNb2N8vrNnWeaffF4jpDPCfIQ0HpR9G41q5NYbH6J/pyijpIMkc4tBH 7LF1nsxObXxnsbPOGNyvpLFY4mShT1jzpD+cRw5TdiklWxDKe2Y63Vkoic74VxLpbf 1qR/pfaGdQxMkKAiduWwWmdhqnFd/GLZBen4weUNLoc+RlWnQn8v27yrnOOSuRq4qy KGPhIUqlsFXXA== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rIYkz-00024a-0q; Wed, 27 Dec 2023 19:35:53 +0100 Date: Wed, 27 Dec 2023 19:35:53 +0100 From: Johan Hovold To: Felix Zhang Cc: Johan Hovold , Luiz Augusto von Dentz , Marcel Holtmann , Johan Hedberg , Hector Martin , Sven Peter , Alyssa Rosenzweig , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] Bluetooth: hci_bcm4377: do not mark valid bd_addr as invalid Message-ID: References: <20231227101003.10534-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231227_103604_539996_0223C951 X-CRM114-Status: GOOD ( 23.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBEZWMgMjcsIDIwMjMgYXQgMDE6MTk6MzlQTSAtMDUwMCwgRmVsaXggWmhhbmcgd3Jv dGU6Cj4gT24gV2VkLCAyMDIzLTEyLTI3IGF0IDExOjEwICswMTAwLCBKb2hhbiBIb3ZvbGQgd3Jv dGU6Cj4gPiBBIHJlY2VudCBjb21taXQgcmVzdG9yZWQgdGhlIG9yaWdpbmFsIChhbmQgc3RpbGwg ZG9jdW1lbnRlZCkKPiA+IHNlbWFudGljcwo+ID4gZm9yIHRoZSBIQ0lfUVVJUktfVVNFX0JEQURE Ul9QUk9QRVJUWSBxdWlyayBzbyB0aGF0IHRoZSBkZXZpY2UKPiA+IGFkZHJlc3MKPiA+IGlzIGNv bnNpZGVyZWQgaW52YWxpZCB1bmxlc3MgYW4gYWRkcmVzcyBpcyBwcm92aWRlZCBieSBmaXJtd2Fy ZS4KPiA+IAo+ID4gVGhpcyBzcGVjaWZpY2FsbHkgbWVhbnMgdGhhdCB0aGlzIGZsYWcgbXVzdCBv bmx5IGJlIHNldCBmb3IgZGV2aWNlcwo+ID4gd2l0aAo+ID4gaW52YWxpZCBhZGRyZXNzZXMsIGJ1 dCB0aGUgQnJvYWRjb20gQkNNNDM3NyBkcml2ZXIgaGFzIHNvIGZhciBiZWVuCj4gPiBzZXR0aW5n IHRoaXMgZmxhZyB1bmNvbmRpdGlvbmFsbHkuCj4gPiAKPiA+IEZvcnR1bmF0ZWx5IHRoZSBkcml2 ZXIgYWxyZWFkeSBjaGVja3MgZm9yIGludmFsaWQgYWRkcmVzc2VzIGR1cmluZwo+ID4gc2V0dXAK PiA+IGFuZCBzZXRzIHRoZSBIQ0lfUVVJUktfSU5WQUxJRF9CREFERFIgZmxhZywgd2hpY2ggY2Fu IHNpbXBseSBiZQo+ID4gcmVwbGFjZWQKPiA+IHdpdGggSENJX1FVSVJLX1VTRV9CREFERFJfUFJP UEVSVFkgdG8gaW5kaWNhdGUgdGhhdCB0aGUgZGVmYXVsdAo+ID4gYWRkcmVzcwo+ID4gaXMgaW52 YWxpZCBidXQgY2FuIGJlIG92ZXJyaWRkZW4gYnkgZmlybXdhcmUgKGxvbmcgdGVybSwgdGhpcyBz aG91bGQKPiA+IHByb2JhYmx5IGp1c3QgYWx3YXlzIGJlIGFsbG93ZWQpLgo+ID4gCj4gPiBGaXhl czogNjk0NTc5NWJjODFhICgiQmx1ZXRvb3RoOiBmaXggdXNlLWJkYWRkci1wcm9wZXJ0eSBxdWly ayIpCj4gPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZ8KgwqDCoMKgwqAgIyA2LjUKPiA+IFJl cG9ydGVkLWJ5OiBGZWxpeCBaaGFuZyA8bXJtYW5AbXJtYW4zMTQudGVjaD4KPiA+IExpbms6Cj4g PiBodHRwczovL2xvcmUua2VybmVsLm9yZy9yLzc3NDE5ZmZhY2M1YjQ4NzVlOTIwZTAzODMzMjU3 NWEyYTViZmYyOWYuY2FtZWxAbXJtYW4zMTQudGVjaC8KPiA+IFNpZ25lZC1vZmYtYnk6IEpvaGFu IEhvdm9sZCA8am9oYW4rbGluYXJvQGtlcm5lbC5vcmc+Cgo+IFRoYW5rcyBmb3IgdGhlIHBhdGNo ISAgSSBoYXZlIGp1c3QgdGVzdGVkIHRoZSBwYXRjaCBvbiBteSBNYWNCb29rQWlyOSwxCj4gd2l0 aCBzb21lIG1vZGlmaWNhdGlvbnMgdG8gbWFrZSBpdCBwYXRjaCB3aXRoIHRoZSBtYXN0ZXIgYnJh bmNoIG9mIHRoZQo+IExpbnV4IGtlcm5lbCwgYW5kIGl0IHdvcmtzIGdyZWF0ISAgVGhlIGRldmlj ZSBpcyByZWNvZ25pemVkIGJ5IHRoZQo+IHN5c3RlbTsgYW5kIEkgY2FuIHNjYW4sIHBhaXIsIGNv bm5lY3QsIGFuZCBwbGF5IGF1ZGlvIGp1c3QgZmluZS4gIElmCj4geW91IHdhbnQgbWUgdG8gc2Vu ZCBvdmVyIHRoZSBtb2RpZmllZCBwYXRjaCB0aGF0IEkgaGF2ZSB1c2VkLCBwbGVhc2UKPiBsZXQg bWUga25vdy4KClRoYW5rcyBmb3IgY29uZmlybWluZy4gWW91IHNob3VsZCBub3QgbmVlZCB0byBt b2RpZnkgdGhlIHBhdGNoLCB0aG91Z2gsCmFzIGl0IGhhcyBiZWVuIGNyZWF0ZWQgYWdhaW5zdCA2 LjctcmM2IGFuZCB0aGVyZSBoYXNuJ3QgYmVlbiBhbnkgY2hhbmdlcwp0byB0aGlzIGRyaXZlciBz aW5jZSByYzEuCgpKb2hhbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=