Re: [Buildroot] [PATCH 1/3] package/gdb: add support for GDB 14.1

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Thomas, All,

On 2023-12-24 17:08 +0100, Thomas Petazzoni via buildroot spake thusly:
> All patches are still relevant, and have been rebased on top of GDB
> 14.1.
> 
> GDB 14.1 now needs mpfr unconditionally, so it is added as a
> dependency of host-gdb, and of gdb when the full debugger is built.
[--SNIP--]
> diff --git a/package/gdb/Config.in b/package/gdb/Config.in
> index e4ab39a2bd..7251dce668 100644
> --- a/package/gdb/Config.in
> +++ b/package/gdb/Config.in
> @@ -59,6 +59,7 @@ config BR2_PACKAGE_GDB_DEBUGGER
>  	depends on BR2_USE_WCHAR
>  	depends on !BR2_sh
>  	select BR2_PACKAGE_GMP if !BR2_arc
> +	select BR2_PACKAGE_MPFR if BR2_GDB_VERSION_14

This is a bit fragile: when we add gdb 15, and drop gdb 12, gdb 14 will
become the default version. Then, if the host variant is not selected,
BR2_GDB_VERSION_14 will not be set. If the user enables the full gdb n
target, mpfr will not be selected.

I've added a litle blurb in the config.in.host, pointing to this part of
the code for an appropriate update.

Applied to master, thanks.

Alternatively, I wonder if we shouldn't jsut make mpfr unconditional for
all versions of gdb, now.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot