All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Julien Olivain" <ju.o@free.fr>,
	"Raphaël Mélotte" <raphael.melotte@mind.be>,
	"Asaf Kahlon" <asafka7@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 4/6] package/python-swig: new package
Date: Wed, 10 Jan 2024 12:01:05 +0100	[thread overview]
Message-ID: <ZZ548XGug565N5dq@landeda> (raw)
In-Reply-To: <20240110093850.2302133-4-james.hilliard1@gmail.com>

James, All,

On 2024-01-10 02:38 -0700, James Hilliard spake thusly:
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

What's the difference with the swig package we already have?

On PyPi, the package you are adding is called just swig, and the page
on PyPi [0] redirects to the project's homepage [1] that is the same
as the homepage for our package/swig/, but the repository it pints to is
different [2] rather than the one from the swig homepage [3].

The description for the swig-on-pypi repository states:

    A project that packages SWIG as a Python package, enabling swig to
    be installed from PyPI:
        pip install swig

    or used as part of build-system.requires in a pyproject.toml file:
        [build-system]
        requires = ["swig"]

So, here are a few questions:

  - can we instead us the existing package/swig to provide the same
    functionality as python-swig? I see there is a --enable-python3
    flag, at least.

  - if not, then will the two conflict, i.e: will python-swig install
    the same set of files as swig does, even partially?

  - if not, do we need to keep both versions in sync? Currently,
    package/swig is still only at 4.1.1.

[0] https://pypi.org/project/swig/
[1] https://swig.org/
[2] https://github.com/nightlark/swig-pypi
[3] https://github.com/swig/swig

Regards,
Yann E. MORIN.

> ---
>  package/python-swig/python-swig.hash |  5 +++++
>  package/python-swig/python-swig.mk   | 17 +++++++++++++++++
>  2 files changed, 22 insertions(+)
>  create mode 100644 package/python-swig/python-swig.hash
>  create mode 100644 package/python-swig/python-swig.mk
> 
> diff --git a/package/python-swig/python-swig.hash b/package/python-swig/python-swig.hash
> new file mode 100644
> index 0000000000..d60477f602
> --- /dev/null
> +++ b/package/python-swig/python-swig.hash
> @@ -0,0 +1,5 @@
> +# md5, sha256 from https://pypi.org/pypi/swig/json
> +md5  c2bf820a545f333d47b7be513baaee3c  swig-4.1.1.post1.tar.gz
> +sha256  5cbf2d4dfc413f74cac197704296a9ef065a3f81c7b3792ff11a56d312c4f652  swig-4.1.1.post1.tar.gz
> +# Locally computed sha256 checksums
> +sha256  73ba74dfaa520b49a401b5d21459a8523a146f3b7518a833eea5efa85130bf68  LICENSE
> diff --git a/package/python-swig/python-swig.mk b/package/python-swig/python-swig.mk
> new file mode 100644
> index 0000000000..89ede170c8
> --- /dev/null
> +++ b/package/python-swig/python-swig.mk
> @@ -0,0 +1,17 @@
> +################################################################################
> +#
> +# python-swig
> +#
> +################################################################################
> +
> +PYTHON_SWIG_VERSION = 4.1.1.post1
> +PYTHON_SWIG_SOURCE = swig-$(PYTHON_SWIG_VERSION).tar.gz
> +PYTHON_SWIG_SITE = https://files.pythonhosted.org/packages/da/b8/d1bfba3d7f75eeca60ecdcb2c214e5cdebb7477437d45db77b6dafee80f9
> +PYTHON_SWIG_SETUP_TYPE = setuptools
> +PYTHON_SWIG_LICENSE = Apache-2.0
> +PYTHON_SWIG_LICENSE_FILES = LICENSE
> +HOST_PYTHON_SWIG_DEPENDENCIES = \
> +	host-python-scikit-build \
> +	host-python-setuptools-scm
> +
> +$(eval $(host-python-package))
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-01-10 11:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-10  9:38 [Buildroot] [PATCH 1/6] package/mupdf: bump to version 1.23.8 James Hilliard
2024-01-10  9:38 ` [Buildroot] [PATCH 2/6] package/python-distro: add host build James Hilliard
2024-01-10  9:38 ` [Buildroot] [PATCH 3/6] package/python-scikit-build: new package James Hilliard
2024-01-10  9:38 ` [Buildroot] [PATCH 4/6] package/python-swig: " James Hilliard
2024-01-10 11:01   ` Yann E. MORIN [this message]
2024-01-10 11:30     ` James Hilliard
2024-01-10 14:13       ` Yann E. MORIN
2024-01-10 14:15         ` Yann E. MORIN
2024-01-10 23:55         ` James Hilliard
2024-01-10  9:38 ` [Buildroot] [PATCH 5/6] ackage/python-libclang: " James Hilliard
2024-01-10  9:38 ` [Buildroot] [PATCH 6/6] package/python-pymupdf: bump to version 1.23.9rc2 James Hilliard
2024-02-08 11:28   ` Raphaël Mélotte via buildroot
2024-02-08 21:29     ` Arnout Vandecappelle via buildroot
2024-02-09 13:15       ` Raphaël Mélotte via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZZ548XGug565N5dq@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=asafka7@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=james.hilliard1@gmail.com \
    --cc=ju.o@free.fr \
    --cc=raphael.melotte@mind.be \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.