From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/madplay: force arm mode instead of Thumb mode
Date: Wed, 10 Jan 2024 11:36:13 +0100 [thread overview]
Message-ID: <ZZ5zHcDmANt7f1c-@landeda> (raw)
In-Reply-To: <20240109173015.7528-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2024-01-09 18:30 +0100, Fabrice Fontaine spake thusly:
> Fix the following build failure raised because madplay uses mad_f_mul
> which is defined in usr/include/mad.h (installed by libmad which has
> been fixed by a similar workaround in commit
> 0aaadd525f2df02911349ffe1518814fa095bf96, unfortunately the fix works
> for compiled code, not mad_f_mul define):
>
> /tmp/cc5SGGoU.s:102: Error: selected processor does not support `smull r8,r9,r2,r4' in Thumb mode
>
> Fixes:
> - http://autobuild.buildroot.org/results/0c0955d4f6726b50cad721f4d3437dabde316e70
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/madplay/madplay.mk | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/package/madplay/madplay.mk b/package/madplay/madplay.mk
> index e1a78bd7d7..91ee44ab5f 100644
> --- a/package/madplay/madplay.mk
> +++ b/package/madplay/madplay.mk
> @@ -15,6 +15,14 @@ MADPLAY_DEPENDENCIES = host-pkgconf libmad libid3tag $(TARGET_NLS_DEPENDENCIES)
> # Also 0003-configure-ac-use-pkg-config-to-find-id3tag.patch
> MADPLAY_AUTORECONF = YES
>
> +# madplay uses libmad which has some assembly function that is not present in
> +# Thumb mode:
> +# Error: selected processor does not support `smull r8,r9,r2,r4' in Thumb mode
> +# so, we desactivate Thumb mode
> +ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB),y)
> +MADPLAY_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -marm"
> +endif
> +
> # Check if ALSA is built, then we should configure after alsa-lib so
> # ./configure can find alsa-lib.
> ifeq ($(BR2_PACKAGE_MADPLAY_ALSA),y)
> --
> 2.43.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-01-10 10:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 17:30 [Buildroot] [PATCH 1/1] package/madplay: force arm mode instead of Thumb mode Fabrice Fontaine
2024-01-10 10:36 ` Yann E. MORIN [this message]
2024-01-13 13:59 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZ5zHcDmANt7f1c-@landeda \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.