From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5314020F9; Tue, 2 Jan 2024 02:54:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cyJf3ixC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47A37C433C8; Tue, 2 Jan 2024 02:54:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704164065; bh=11z9yjbOWrH6tSiyWTkbin1v0ZP1GSqeHEVZ1qpwWW4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cyJf3ixCiPi9UvwUkSVUpOmKCh2ropGCL0NBDwtKRDYXQBHVLgzbEDPcu3Fja3YJG jSZs8VQEgmsEJFXxqzyDTpXLIyEvLGB9gRcZcYNrAM16lNkkiVRzm+TveG0nnUdsDO Cz9Xw1AdV6g9B3vuf+hPBycNosrLD86ng+fYciVOev6XLcgrRF4jz70RQMH5NzMvdv pcsyHKuZwX9hcMrpv5EtGFEKrqiVHYWwXPKdQhUADat9VR8ZW3EnNoQU9k4MY3EztT 7r9FaoDjSiOJIV8ph/7zp97UKkY4ISTBuOqOvwxFU52/3up2s1I2mMBs9cjS3+GXOv b0gUGT9N0gE1A== Date: Tue, 2 Jan 2024 10:41:40 +0800 From: Jisheng Zhang To: Nadav Amit Cc: Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Catalin Marinas , Paul Walmsley , Palmer Dabbelt , Albert Ou , Arnd Bergmann , linux-arch@vger.kernel.org, linux-mm , linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List , linux-riscv@lists.infradead.org, Nadav Amit , Andrea Arcangeli , Andy Lutomirski , Dave Hansen , Thomas Gleixner , Yu Zhao , the arch/x86 maintainers Subject: Re: [PATCH 1/2] mm/tlb: fix fullmm semantics Message-ID: References: <20231228084642.1765-1-jszhang@kernel.org> <20231228084642.1765-2-jszhang@kernel.org> <204B6410-2EFA-462B-9DF7-64CC5F1D3AD2@broadcom.com> Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <204B6410-2EFA-462B-9DF7-64CC5F1D3AD2@broadcom.com> On Sat, Dec 30, 2023 at 11:54:02AM +0200, Nadav Amit wrote: > > > > On Dec 28, 2023, at 10:46 AM, Jisheng Zhang wrote: > > > > From: Nadav Amit > > > > fullmm in mmu_gather is supposed to indicate that the mm is torn-down > > (e.g., on process exit) and can therefore allow certain optimizations. > > However, tlb_finish_mmu() sets fullmm, when in fact it want to say that > > the TLB should be fully flushed. > > > > Change tlb_finish_mmu() to set need_flush_all and check this flag in > > tlb_flush_mmu_tlbonly() when deciding whether a flush is needed. > > > > At the same time, bring the arm64 fullmm on process exit optimization back. > > > > Signed-off-by: Nadav Amit > > Signed-off-by: Jisheng Zhang > > Cc: Andrea Arcangeli > > Cc: Andrew Morton > > Cc: Andy Lutomirski > > Cc: Dave Hansen > > Cc: Peter Zijlstra > > Cc: Thomas Gleixner > > Cc: Will Deacon > > Cc: Yu Zhao > > Cc: Nick Piggin > > Cc: x86@kernel.org > > --- > > arch/arm64/include/asm/tlb.h | 5 ++++- > > include/asm-generic/tlb.h | 2 +- > > mm/mmu_gather.c | 2 +- > > 3 files changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/include/asm/tlb.h b/arch/arm64/include/asm/tlb.h > > index 846c563689a8..6164c5f3b78f 100644 > > --- a/arch/arm64/include/asm/tlb.h > > +++ b/arch/arm64/include/asm/tlb.h > > @@ -62,7 +62,10 @@ static inline void tlb_flush(struct mmu_gather *tlb) > > * invalidating the walk-cache, since the ASID allocator won't > > * reallocate our ASID without invalidating the entire TLB. > > */ > > - if (tlb->fullmm) { > > + if (tlb->fullmm) > > + return; > > + > > + if (tlb->need_flush_all) { > > if (!last_level) > > flush_tlb_mm(tlb->mm); > > return; > > > > Thanks for pulling my patch out of the abyss, but the chunk above > did not come from my old patch. I stated this in cover letter msg ;) IMHO, current arm64 uses fullmm as need_flush_all, so I think we need at least the need_flush_all line. I'd like to see comments from arm64 experts. > > My knowledge of arm64 is a bit limited, but the code does not seem > to match the comment, so if it is correct (which I strongly doubt), > the comment should be updated. will do if the above change is accepted by arm64 > > [1] https://lore.kernel.org/all/20210131001132.3368247-2-namit@vmware.com/ > > > -- > This electronic communication and the information and any files transmitted > with it, or attached to it, are confidential and are intended solely for > the use of the individual or entity to whom it is addressed and may contain > information that is confidential, legally privileged, protected by privacy > laws, or otherwise restricted from disclosure to anyone else. If you are > not the intended recipient or the person responsible for delivering the > e-mail to the intended recipient, you are hereby notified that any use, > copying, distributing, dissemination, forwarding, printing, or copying of > this e-mail is strictly prohibited. If you received this e-mail in error, > please return the e-mail to the sender, delete it from your computer, and > destroy any printed copy of it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D35BC4706F for ; Tue, 2 Jan 2024 02:54:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Pd866KCD6WtzmIDjqTbtxFwodofgAkjFn88LvhlLbyc=; b=Y0yCkLwRKzTiws yX53vJRuY1QaKzBJJBytHRs3xV2cn0bBj5vFc/1pkN2apYWT5Ln30OE1+5OEElpbfeem/bwBA1S5s uj0ihbHdD7RPEUI7WxWsCNctnIMi/vxcyVI6iH1jHRlKmfMW0g9U89BFBh8VfCOUiII+S6CrpxjUa Y/+cuqHNi1fO91VBgWKlz4ZRrwEEJDMqGsh9RP8p2KWjAheipDCve65ML50lAp0t1x2pqk/ZQ11VW 7pi6aFbZKt0gFBfBsmT8xC2JN4bWQNT0zn3g7tMv16t8Sho7eoTXIInxx0r2IjnQ2lmAjHQVVK8if lW9ukfqXIuvwefMgF9Zw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rKUvM-006zpz-0S; Tue, 02 Jan 2024 02:54:36 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rKUvI-006zoc-1C; Tue, 02 Jan 2024 02:54:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4CE23CE0B74; Tue, 2 Jan 2024 02:54:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47A37C433C8; Tue, 2 Jan 2024 02:54:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704164065; bh=11z9yjbOWrH6tSiyWTkbin1v0ZP1GSqeHEVZ1qpwWW4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cyJf3ixCiPi9UvwUkSVUpOmKCh2ropGCL0NBDwtKRDYXQBHVLgzbEDPcu3Fja3YJG jSZs8VQEgmsEJFXxqzyDTpXLIyEvLGB9gRcZcYNrAM16lNkkiVRzm+TveG0nnUdsDO Cz9Xw1AdV6g9B3vuf+hPBycNosrLD86ng+fYciVOev6XLcgrRF4jz70RQMH5NzMvdv pcsyHKuZwX9hcMrpv5EtGFEKrqiVHYWwXPKdQhUADat9VR8ZW3EnNoQU9k4MY3EztT 7r9FaoDjSiOJIV8ph/7zp97UKkY4ISTBuOqOvwxFU52/3up2s1I2mMBs9cjS3+GXOv b0gUGT9N0gE1A== Date: Tue, 2 Jan 2024 10:41:40 +0800 From: Jisheng Zhang To: Nadav Amit Cc: Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Catalin Marinas , Paul Walmsley , Palmer Dabbelt , Albert Ou , Arnd Bergmann , linux-arch@vger.kernel.org, linux-mm , linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List , linux-riscv@lists.infradead.org, Nadav Amit , Andrea Arcangeli , Andy Lutomirski , Dave Hansen , Thomas Gleixner , Yu Zhao , the arch/x86 maintainers Subject: Re: [PATCH 1/2] mm/tlb: fix fullmm semantics Message-ID: References: <20231228084642.1765-1-jszhang@kernel.org> <20231228084642.1765-2-jszhang@kernel.org> <204B6410-2EFA-462B-9DF7-64CC5F1D3AD2@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <204B6410-2EFA-462B-9DF7-64CC5F1D3AD2@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240101_185432_872010_F8AAFEA8 X-CRM114-Status: GOOD ( 39.32 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gU2F0LCBEZWMgMzAsIDIwMjMgYXQgMTE6NTQ6MDJBTSArMDIwMCwgTmFkYXYgQW1pdCB3cm90 ZToKPiAKPiAKPiA+IE9uIERlYyAyOCwgMjAyMywgYXQgMTA6NDbigK9BTSwgSmlzaGVuZyBaaGFu ZyA8anN6aGFuZ0BrZXJuZWwub3JnPiB3cm90ZToKPiA+IAo+ID4gRnJvbTogTmFkYXYgQW1pdCA8 bmFtaXRAdm13YXJlLmNvbT4KPiA+IAo+ID4gZnVsbG1tIGluIG1tdV9nYXRoZXIgaXMgc3VwcG9z ZWQgdG8gaW5kaWNhdGUgdGhhdCB0aGUgbW0gaXMgdG9ybi1kb3duCj4gPiAoZS5nLiwgb24gcHJv Y2VzcyBleGl0KSBhbmQgY2FuIHRoZXJlZm9yZSBhbGxvdyBjZXJ0YWluIG9wdGltaXphdGlvbnMu Cj4gPiBIb3dldmVyLCB0bGJfZmluaXNoX21tdSgpIHNldHMgZnVsbG1tLCB3aGVuIGluIGZhY3Qg aXQgd2FudCB0byBzYXkgdGhhdAo+ID4gdGhlIFRMQiBzaG91bGQgYmUgZnVsbHkgZmx1c2hlZC4K PiA+IAo+ID4gQ2hhbmdlIHRsYl9maW5pc2hfbW11KCkgdG8gc2V0IG5lZWRfZmx1c2hfYWxsIGFu ZCBjaGVjayB0aGlzIGZsYWcgaW4KPiA+IHRsYl9mbHVzaF9tbXVfdGxib25seSgpIHdoZW4gZGVj aWRpbmcgd2hldGhlciBhIGZsdXNoIGlzIG5lZWRlZC4KPiA+IAo+ID4gQXQgdGhlIHNhbWUgdGlt ZSwgYnJpbmcgdGhlIGFybTY0IGZ1bGxtbSBvbiBwcm9jZXNzIGV4aXQgb3B0aW1pemF0aW9uIGJh Y2suCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IE5hZGF2IEFtaXQgPG5hbWl0QHZtd2FyZS5jb20+ Cj4gPiBTaWduZWQtb2ZmLWJ5OiBKaXNoZW5nIFpoYW5nIDxqc3poYW5nQGtlcm5lbC5vcmc+Cj4g PiBDYzogQW5kcmVhIEFyY2FuZ2VsaSA8YWFyY2FuZ2VAcmVkaGF0LmNvbT4KPiA+IENjOiBBbmRy ZXcgTW9ydG9uIDxha3BtQGxpbnV4LWZvdW5kYXRpb24ub3JnPgo+ID4gQ2M6IEFuZHkgTHV0b21p cnNraSA8bHV0b0BrZXJuZWwub3JnPgo+ID4gQ2M6IERhdmUgSGFuc2VuIDxkYXZlLmhhbnNlbkBs aW51eC5pbnRlbC5jb20+Cj4gPiBDYzogUGV0ZXIgWmlqbHN0cmEgPHBldGVyekBpbmZyYWRlYWQu b3JnPgo+ID4gQ2M6IFRob21hcyBHbGVpeG5lciA8dGdseEBsaW51dHJvbml4LmRlPgo+ID4gQ2M6 IFdpbGwgRGVhY29uIDx3aWxsQGtlcm5lbC5vcmc+Cj4gPiBDYzogWXUgWmhhbyA8eXV6aGFvQGdv b2dsZS5jb20+Cj4gPiBDYzogTmljayBQaWdnaW4gPG5waWdnaW5AZ21haWwuY29tPgo+ID4gQ2M6 IHg4NkBrZXJuZWwub3JnCj4gPiAtLS0KPiA+IGFyY2gvYXJtNjQvaW5jbHVkZS9hc20vdGxiLmgg fCA1ICsrKystCj4gPiBpbmNsdWRlL2FzbS1nZW5lcmljL3RsYi5oICAgIHwgMiArLQo+ID4gbW0v bW11X2dhdGhlci5jICAgICAgICAgICAgICB8IDIgKy0KPiA+IDMgZmlsZXMgY2hhbmdlZCwgNiBp bnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9h cm02NC9pbmNsdWRlL2FzbS90bGIuaCBiL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vdGxiLmgKPiA+ IGluZGV4IDg0NmM1NjM2ODlhOC4uNjE2NGM1ZjNiNzhmIDEwMDY0NAo+ID4gLS0tIGEvYXJjaC9h cm02NC9pbmNsdWRlL2FzbS90bGIuaAo+ID4gKysrIGIvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS90 bGIuaAo+ID4gQEAgLTYyLDcgKzYyLDEwIEBAIHN0YXRpYyBpbmxpbmUgdm9pZCB0bGJfZmx1c2go c3RydWN0IG1tdV9nYXRoZXIgKnRsYikKPiA+IAkgKiBpbnZhbGlkYXRpbmcgdGhlIHdhbGstY2Fj aGUsIHNpbmNlIHRoZSBBU0lEIGFsbG9jYXRvciB3b24ndAo+ID4gCSAqIHJlYWxsb2NhdGUgb3Vy IEFTSUQgd2l0aG91dCBpbnZhbGlkYXRpbmcgdGhlIGVudGlyZSBUTEIuCj4gPiAJICovCj4gPiAt CWlmICh0bGItPmZ1bGxtbSkgewo+ID4gKwlpZiAodGxiLT5mdWxsbW0pCj4gPiArCQlyZXR1cm47 Cj4gPiArCj4gPiArCWlmICh0bGItPm5lZWRfZmx1c2hfYWxsKSB7Cj4gPiAJCWlmICghbGFzdF9s ZXZlbCkKPiA+IAkJCWZsdXNoX3RsYl9tbSh0bGItPm1tKTsKPiA+IAkJcmV0dXJuOwo+ID4gCj4g Cj4gVGhhbmtzIGZvciBwdWxsaW5nIG15IHBhdGNoIG91dCBvZiB0aGUgYWJ5c3MsIGJ1dCB0aGUg Y2h1bmsgYWJvdmUKPiBkaWQgbm90IGNvbWUgZnJvbSBteSBvbGQgcGF0Y2guCgpJIHN0YXRlZCB0 aGlzIGluIGNvdmVyIGxldHRlciBtc2cgOykgSU1ITywgY3VycmVudCBhcm02NCB1c2VzIGZ1bGxt bSBhcwpuZWVkX2ZsdXNoX2FsbCwgc28gSSB0aGluayB3ZSBuZWVkIGF0IGxlYXN0IHRoZSBuZWVk X2ZsdXNoX2FsbCBsaW5lLgoKSSdkIGxpa2UgdG8gc2VlIGNvbW1lbnRzIGZyb20gYXJtNjQgZXhw ZXJ0cy4KCj4gCj4gTXkga25vd2xlZGdlIG9mIGFybTY0IGlzIGEgYml0IGxpbWl0ZWQsIGJ1dCB0 aGUgY29kZSBkb2VzIG5vdCBzZWVtCj4gdG8gbWF0Y2ggdGhlIGNvbW1lbnQsIHNvIGlmIGl0IGlz IGNvcnJlY3QgKHdoaWNoIEkgc3Ryb25nbHkgZG91YnQpLAo+IHRoZSBjb21tZW50IHNob3VsZCBi ZSB1cGRhdGVkLgoKd2lsbCBkbyBpZiB0aGUgYWJvdmUgY2hhbmdlIGlzIGFjY2VwdGVkIGJ5IGFy bTY0Cgo+IAo+IFsxXSBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvMjAyMTAxMzEwMDExMzIu MzM2ODI0Ny0yLW5hbWl0QHZtd2FyZS5jb20vCj4gCj4gCj4gLS0gCj4gVGhpcyBlbGVjdHJvbmlj IGNvbW11bmljYXRpb24gYW5kIHRoZSBpbmZvcm1hdGlvbiBhbmQgYW55IGZpbGVzIHRyYW5zbWl0 dGVkIAo+IHdpdGggaXQsIG9yIGF0dGFjaGVkIHRvIGl0LCBhcmUgY29uZmlkZW50aWFsIGFuZCBh cmUgaW50ZW5kZWQgc29sZWx5IGZvciAKPiB0aGUgdXNlIG9mIHRoZSBpbmRpdmlkdWFsIG9yIGVu dGl0eSB0byB3aG9tIGl0IGlzIGFkZHJlc3NlZCBhbmQgbWF5IGNvbnRhaW4gCj4gaW5mb3JtYXRp b24gdGhhdCBpcyBjb25maWRlbnRpYWwsIGxlZ2FsbHkgcHJpdmlsZWdlZCwgcHJvdGVjdGVkIGJ5 IHByaXZhY3kgCj4gbGF3cywgb3Igb3RoZXJ3aXNlIHJlc3RyaWN0ZWQgZnJvbSBkaXNjbG9zdXJl IHRvIGFueW9uZSBlbHNlLiBJZiB5b3UgYXJlIAo+IG5vdCB0aGUgaW50ZW5kZWQgcmVjaXBpZW50 IG9yIHRoZSBwZXJzb24gcmVzcG9uc2libGUgZm9yIGRlbGl2ZXJpbmcgdGhlIAo+IGUtbWFpbCB0 byB0aGUgaW50ZW5kZWQgcmVjaXBpZW50LCB5b3UgYXJlIGhlcmVieSBub3RpZmllZCB0aGF0IGFu eSB1c2UsIAo+IGNvcHlpbmcsIGRpc3RyaWJ1dGluZywgZGlzc2VtaW5hdGlvbiwgZm9yd2FyZGlu ZywgcHJpbnRpbmcsIG9yIGNvcHlpbmcgb2YgCj4gdGhpcyBlLW1haWwgaXMgc3RyaWN0bHkgcHJv aGliaXRlZC4gSWYgeW91IHJlY2VpdmVkIHRoaXMgZS1tYWlsIGluIGVycm9yLCAKPiBwbGVhc2Ug cmV0dXJuIHRoZSBlLW1haWwgdG8gdGhlIHNlbmRlciwgZGVsZXRlIGl0IGZyb20geW91ciBjb21w dXRlciwgYW5kIAo+IGRlc3Ryb3kgYW55IHByaW50ZWQgY29weSBvZiBpdC4KCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcg bGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2F4CC47074 for ; Tue, 2 Jan 2024 02:55:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P+1jHAohv44NxvvQQhXqKR02DEBU/E4SrMZa/HJ5bmI=; b=nexf7Vf841080w W8EdjzSyy/vni8JMcQa3VXULSCz7jUfA1ceu9nFv4Isa/CoXhqxFh0KwS0CF+r1spC0YvgMSFJ3vt fOqZQgE71pIqzmATRs4z9QdlluLE3o9mfxrE2iGLzKtk7v7L/+Jicgil3KDGgaRKa6JkrkAr9uuBE cU3gVIs2yufz22+2sjYIdYKgb8TmK5C9oesgCBfuWV0PS+2vtZAz69eFDKkhZ59SM+4qOS67YkQH1 cMVWT1PQj0TrAXWkaynab3y4OnVOq457NzWA/FiPY/XzpvhCdtcBl1TrhG1zONHjx+Gq+kLa4XOp/ Xrl85k6IDXzylPfdSTJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rKUvL-006zpp-22; Tue, 02 Jan 2024 02:54:35 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rKUvI-006zoc-1C; Tue, 02 Jan 2024 02:54:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4CE23CE0B74; Tue, 2 Jan 2024 02:54:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47A37C433C8; Tue, 2 Jan 2024 02:54:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704164065; bh=11z9yjbOWrH6tSiyWTkbin1v0ZP1GSqeHEVZ1qpwWW4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cyJf3ixCiPi9UvwUkSVUpOmKCh2ropGCL0NBDwtKRDYXQBHVLgzbEDPcu3Fja3YJG jSZs8VQEgmsEJFXxqzyDTpXLIyEvLGB9gRcZcYNrAM16lNkkiVRzm+TveG0nnUdsDO Cz9Xw1AdV6g9B3vuf+hPBycNosrLD86ng+fYciVOev6XLcgrRF4jz70RQMH5NzMvdv pcsyHKuZwX9hcMrpv5EtGFEKrqiVHYWwXPKdQhUADat9VR8ZW3EnNoQU9k4MY3EztT 7r9FaoDjSiOJIV8ph/7zp97UKkY4ISTBuOqOvwxFU52/3up2s1I2mMBs9cjS3+GXOv b0gUGT9N0gE1A== Date: Tue, 2 Jan 2024 10:41:40 +0800 From: Jisheng Zhang To: Nadav Amit Cc: Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Catalin Marinas , Paul Walmsley , Palmer Dabbelt , Albert Ou , Arnd Bergmann , linux-arch@vger.kernel.org, linux-mm , linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List , linux-riscv@lists.infradead.org, Nadav Amit , Andrea Arcangeli , Andy Lutomirski , Dave Hansen , Thomas Gleixner , Yu Zhao , the arch/x86 maintainers Subject: Re: [PATCH 1/2] mm/tlb: fix fullmm semantics Message-ID: References: <20231228084642.1765-1-jszhang@kernel.org> <20231228084642.1765-2-jszhang@kernel.org> <204B6410-2EFA-462B-9DF7-64CC5F1D3AD2@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <204B6410-2EFA-462B-9DF7-64CC5F1D3AD2@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240101_185432_872010_F8AAFEA8 X-CRM114-Status: GOOD ( 39.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBEZWMgMzAsIDIwMjMgYXQgMTE6NTQ6MDJBTSArMDIwMCwgTmFkYXYgQW1pdCB3cm90 ZToKPiAKPiAKPiA+IE9uIERlYyAyOCwgMjAyMywgYXQgMTA6NDbigK9BTSwgSmlzaGVuZyBaaGFu ZyA8anN6aGFuZ0BrZXJuZWwub3JnPiB3cm90ZToKPiA+IAo+ID4gRnJvbTogTmFkYXYgQW1pdCA8 bmFtaXRAdm13YXJlLmNvbT4KPiA+IAo+ID4gZnVsbG1tIGluIG1tdV9nYXRoZXIgaXMgc3VwcG9z ZWQgdG8gaW5kaWNhdGUgdGhhdCB0aGUgbW0gaXMgdG9ybi1kb3duCj4gPiAoZS5nLiwgb24gcHJv Y2VzcyBleGl0KSBhbmQgY2FuIHRoZXJlZm9yZSBhbGxvdyBjZXJ0YWluIG9wdGltaXphdGlvbnMu Cj4gPiBIb3dldmVyLCB0bGJfZmluaXNoX21tdSgpIHNldHMgZnVsbG1tLCB3aGVuIGluIGZhY3Qg aXQgd2FudCB0byBzYXkgdGhhdAo+ID4gdGhlIFRMQiBzaG91bGQgYmUgZnVsbHkgZmx1c2hlZC4K PiA+IAo+ID4gQ2hhbmdlIHRsYl9maW5pc2hfbW11KCkgdG8gc2V0IG5lZWRfZmx1c2hfYWxsIGFu ZCBjaGVjayB0aGlzIGZsYWcgaW4KPiA+IHRsYl9mbHVzaF9tbXVfdGxib25seSgpIHdoZW4gZGVj aWRpbmcgd2hldGhlciBhIGZsdXNoIGlzIG5lZWRlZC4KPiA+IAo+ID4gQXQgdGhlIHNhbWUgdGlt ZSwgYnJpbmcgdGhlIGFybTY0IGZ1bGxtbSBvbiBwcm9jZXNzIGV4aXQgb3B0aW1pemF0aW9uIGJh Y2suCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IE5hZGF2IEFtaXQgPG5hbWl0QHZtd2FyZS5jb20+ Cj4gPiBTaWduZWQtb2ZmLWJ5OiBKaXNoZW5nIFpoYW5nIDxqc3poYW5nQGtlcm5lbC5vcmc+Cj4g PiBDYzogQW5kcmVhIEFyY2FuZ2VsaSA8YWFyY2FuZ2VAcmVkaGF0LmNvbT4KPiA+IENjOiBBbmRy ZXcgTW9ydG9uIDxha3BtQGxpbnV4LWZvdW5kYXRpb24ub3JnPgo+ID4gQ2M6IEFuZHkgTHV0b21p cnNraSA8bHV0b0BrZXJuZWwub3JnPgo+ID4gQ2M6IERhdmUgSGFuc2VuIDxkYXZlLmhhbnNlbkBs aW51eC5pbnRlbC5jb20+Cj4gPiBDYzogUGV0ZXIgWmlqbHN0cmEgPHBldGVyekBpbmZyYWRlYWQu b3JnPgo+ID4gQ2M6IFRob21hcyBHbGVpeG5lciA8dGdseEBsaW51dHJvbml4LmRlPgo+ID4gQ2M6 IFdpbGwgRGVhY29uIDx3aWxsQGtlcm5lbC5vcmc+Cj4gPiBDYzogWXUgWmhhbyA8eXV6aGFvQGdv b2dsZS5jb20+Cj4gPiBDYzogTmljayBQaWdnaW4gPG5waWdnaW5AZ21haWwuY29tPgo+ID4gQ2M6 IHg4NkBrZXJuZWwub3JnCj4gPiAtLS0KPiA+IGFyY2gvYXJtNjQvaW5jbHVkZS9hc20vdGxiLmgg fCA1ICsrKystCj4gPiBpbmNsdWRlL2FzbS1nZW5lcmljL3RsYi5oICAgIHwgMiArLQo+ID4gbW0v bW11X2dhdGhlci5jICAgICAgICAgICAgICB8IDIgKy0KPiA+IDMgZmlsZXMgY2hhbmdlZCwgNiBp bnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9h cm02NC9pbmNsdWRlL2FzbS90bGIuaCBiL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vdGxiLmgKPiA+ IGluZGV4IDg0NmM1NjM2ODlhOC4uNjE2NGM1ZjNiNzhmIDEwMDY0NAo+ID4gLS0tIGEvYXJjaC9h cm02NC9pbmNsdWRlL2FzbS90bGIuaAo+ID4gKysrIGIvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS90 bGIuaAo+ID4gQEAgLTYyLDcgKzYyLDEwIEBAIHN0YXRpYyBpbmxpbmUgdm9pZCB0bGJfZmx1c2go c3RydWN0IG1tdV9nYXRoZXIgKnRsYikKPiA+IAkgKiBpbnZhbGlkYXRpbmcgdGhlIHdhbGstY2Fj aGUsIHNpbmNlIHRoZSBBU0lEIGFsbG9jYXRvciB3b24ndAo+ID4gCSAqIHJlYWxsb2NhdGUgb3Vy IEFTSUQgd2l0aG91dCBpbnZhbGlkYXRpbmcgdGhlIGVudGlyZSBUTEIuCj4gPiAJICovCj4gPiAt CWlmICh0bGItPmZ1bGxtbSkgewo+ID4gKwlpZiAodGxiLT5mdWxsbW0pCj4gPiArCQlyZXR1cm47 Cj4gPiArCj4gPiArCWlmICh0bGItPm5lZWRfZmx1c2hfYWxsKSB7Cj4gPiAJCWlmICghbGFzdF9s ZXZlbCkKPiA+IAkJCWZsdXNoX3RsYl9tbSh0bGItPm1tKTsKPiA+IAkJcmV0dXJuOwo+ID4gCj4g Cj4gVGhhbmtzIGZvciBwdWxsaW5nIG15IHBhdGNoIG91dCBvZiB0aGUgYWJ5c3MsIGJ1dCB0aGUg Y2h1bmsgYWJvdmUKPiBkaWQgbm90IGNvbWUgZnJvbSBteSBvbGQgcGF0Y2guCgpJIHN0YXRlZCB0 aGlzIGluIGNvdmVyIGxldHRlciBtc2cgOykgSU1ITywgY3VycmVudCBhcm02NCB1c2VzIGZ1bGxt bSBhcwpuZWVkX2ZsdXNoX2FsbCwgc28gSSB0aGluayB3ZSBuZWVkIGF0IGxlYXN0IHRoZSBuZWVk X2ZsdXNoX2FsbCBsaW5lLgoKSSdkIGxpa2UgdG8gc2VlIGNvbW1lbnRzIGZyb20gYXJtNjQgZXhw ZXJ0cy4KCj4gCj4gTXkga25vd2xlZGdlIG9mIGFybTY0IGlzIGEgYml0IGxpbWl0ZWQsIGJ1dCB0 aGUgY29kZSBkb2VzIG5vdCBzZWVtCj4gdG8gbWF0Y2ggdGhlIGNvbW1lbnQsIHNvIGlmIGl0IGlz IGNvcnJlY3QgKHdoaWNoIEkgc3Ryb25nbHkgZG91YnQpLAo+IHRoZSBjb21tZW50IHNob3VsZCBi ZSB1cGRhdGVkLgoKd2lsbCBkbyBpZiB0aGUgYWJvdmUgY2hhbmdlIGlzIGFjY2VwdGVkIGJ5IGFy bTY0Cgo+IAo+IFsxXSBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvMjAyMTAxMzEwMDExMzIu MzM2ODI0Ny0yLW5hbWl0QHZtd2FyZS5jb20vCj4gCj4gCj4gLS0gCj4gVGhpcyBlbGVjdHJvbmlj IGNvbW11bmljYXRpb24gYW5kIHRoZSBpbmZvcm1hdGlvbiBhbmQgYW55IGZpbGVzIHRyYW5zbWl0 dGVkIAo+IHdpdGggaXQsIG9yIGF0dGFjaGVkIHRvIGl0LCBhcmUgY29uZmlkZW50aWFsIGFuZCBh cmUgaW50ZW5kZWQgc29sZWx5IGZvciAKPiB0aGUgdXNlIG9mIHRoZSBpbmRpdmlkdWFsIG9yIGVu dGl0eSB0byB3aG9tIGl0IGlzIGFkZHJlc3NlZCBhbmQgbWF5IGNvbnRhaW4gCj4gaW5mb3JtYXRp b24gdGhhdCBpcyBjb25maWRlbnRpYWwsIGxlZ2FsbHkgcHJpdmlsZWdlZCwgcHJvdGVjdGVkIGJ5 IHByaXZhY3kgCj4gbGF3cywgb3Igb3RoZXJ3aXNlIHJlc3RyaWN0ZWQgZnJvbSBkaXNjbG9zdXJl IHRvIGFueW9uZSBlbHNlLiBJZiB5b3UgYXJlIAo+IG5vdCB0aGUgaW50ZW5kZWQgcmVjaXBpZW50 IG9yIHRoZSBwZXJzb24gcmVzcG9uc2libGUgZm9yIGRlbGl2ZXJpbmcgdGhlIAo+IGUtbWFpbCB0 byB0aGUgaW50ZW5kZWQgcmVjaXBpZW50LCB5b3UgYXJlIGhlcmVieSBub3RpZmllZCB0aGF0IGFu eSB1c2UsIAo+IGNvcHlpbmcsIGRpc3RyaWJ1dGluZywgZGlzc2VtaW5hdGlvbiwgZm9yd2FyZGlu ZywgcHJpbnRpbmcsIG9yIGNvcHlpbmcgb2YgCj4gdGhpcyBlLW1haWwgaXMgc3RyaWN0bHkgcHJv aGliaXRlZC4gSWYgeW91IHJlY2VpdmVkIHRoaXMgZS1tYWlsIGluIGVycm9yLCAKPiBwbGVhc2Ug cmV0dXJuIHRoZSBlLW1haWwgdG8gdGhlIHNlbmRlciwgZGVsZXRlIGl0IGZyb20geW91ciBjb21w dXRlciwgYW5kIAo+IGRlc3Ryb3kgYW55IHByaW50ZWQgY29weSBvZiBpdC4KCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK