From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 034DDC46CD2 for ; Tue, 2 Jan 2024 05:37:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bywOz3pcomEzEWhEXJ5KGT7j5uSgSbrRe5XfIxYtjlI=; b=Bx9jQ/EZg4il2i tvr2a01HEXvVpmu5DWu+kVOXGN0p52cV0hhZIblKvkCDsWr1LyEzOjOQlhO6L1xS8cPPgmkoIf84N OLtXX1fFi6371vlvGoT+TO7BbaJeXQk4NFnKd/kPeqV+TvOjvwDo6C2oYuVb+UHbuNRcXNNA3i8jY XQyY6zBL46w3vE+CI4/+pvEEd67NLrrwVzLqiEfrS90/khcVPn8mJu57FAxyduZdVbEpQusNF0Ixb 6yfQqtZON2WM0CwG5o2oufK8TNXH1VXefcGpitlnQ/lnll1IH1Yb+7O916lNndZQTjoqNW1M4hMvF QOXUOBlykyM/JdxJDniw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rKXTC-0077tJ-0F; Tue, 02 Jan 2024 05:37:42 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rKXT7-0077rZ-2V for linux-riscv@lists.infradead.org; Tue, 02 Jan 2024 05:37:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704173855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eCnGZSmn0Xbft/VvC3w27VmkfIRRQMc7XVfvoJNmfHo=; b=aAjr2CcL3ZNlU4giTwaa8lKKewvWOns6u8sCT3oDje9TKppiUSu3euPbf6YoC+EbZm30KA QbFHD+o4Kj7sODWqCgomPYgeDH2bcxxwQkDJLlTXyeB7hQr/RYJ8E8B+/FdhCKMY10YYbv PoM8u6v6SM7sUXtgYMPQrz1liXCAVSY= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-331-EnQcK3NdOIGFmDIP4cM_RA-1; Tue, 02 Jan 2024 00:37:32 -0500 X-MC-Unique: EnQcK3NdOIGFmDIP4cM_RA-1 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-6da4d130a82so881295b3a.1 for ; Mon, 01 Jan 2024 21:37:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704173851; x=1704778651; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eCnGZSmn0Xbft/VvC3w27VmkfIRRQMc7XVfvoJNmfHo=; b=DL9ISnVC14hgGa7pY4QgTXATE+w7gXeL+0T7yx2eHo4ZMBiiTPZFmJIHsxZKjotHc1 nswCq152jiUpEU+dXaxWNkHG/GcMmPxDG/+LhPqCwxkSUdYLbM8noFXm2IAhbDRKkwcW 8yeVsXH7POe4rJAyT9bc4dWas762Z/ZQoTrptrQsQxX5+vZxvuT1LROfYdWDBDZQT26g mq5+7kTjijIflHV32LWMLhuhmUzmBsvlbz9bn5VWhOqFf3GmVkngZgtsyLFXY0Ic1wu7 izmtv/YeeTor/RsBpv8iMzz9NZGw6xZPKkXDYHUDI9KGWdtav0wziOqiha8OD/PSX8/t Nvwg== X-Gm-Message-State: AOJu0YwH/OhpLKGh/yCuSbAKpXzawLob9BoYznJJjVKF1PcePeL3jEy4 Wc/20BIzMhtPNyaMpoxrV+Y/6n54OOetOQQVOS0qPa7PAKDspM8Fg8IPTlF5V5Jab1u4CfFMmJ9 J/0bYg+qKgtuYIiQ107BzNTusc5IxjnUdX5qX X-Received: by 2002:a17:902:ce86:b0:1d3:eecd:b296 with SMTP id f6-20020a170902ce8600b001d3eecdb296mr33590835plg.6.1704173851409; Mon, 01 Jan 2024 21:37:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IHENzr2M0aJyyZm2vt3XzuVCeWLevZs5IuWsUdjc1ZzU9FWxHr/jzg4D3MMktI1x4ptpcHyFg== X-Received: by 2002:a17:902:ce86:b0:1d3:eecd:b296 with SMTP id f6-20020a170902ce8600b001d3eecdb296mr33590810plg.6.1704173851161; Mon, 01 Jan 2024 21:37:31 -0800 (PST) Received: from x1n ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id v4-20020a17090331c400b001d49c0daf60sm6900347ple.265.2024.01.01.21.37.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jan 2024 21:37:30 -0800 (PST) Date: Tue, 2 Jan 2024 13:37:14 +0800 From: Peter Xu To: Muchun Song Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , Christophe Leroy , Lorenzo Stoakes , David Hildenbrand , Vlastimil Babka , Mike Kravetz , Mike Rapoport , Christoph Hellwig , John Hubbard , Andrew Jones , linux-arm-kernel@lists.infradead.org, Michael Ellerman , "Kirill A . Shutemov" , linuxppc-dev@lists.ozlabs.org, Rik van Riel , linux-riscv@lists.infradead.org, Yang Shi , James Houghton , "Aneesh Kumar K . V" , Andrew Morton , Jason Gunthorpe , Andrea Arcangeli , Axel Rasmussen Subject: Re: [PATCH 03/13] mm: Provide generic pmd_thp_or_huge() Message-ID: References: <20231219075538.414708-1-peterx@redhat.com> <20231219075538.414708-4-peterx@redhat.com> <135b3189-f459-4b57-9861-bb8acb999d91@linux.dev> MIME-Version: 1.0 In-Reply-To: <135b3189-f459-4b57-9861-bb8acb999d91@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240101_213737_902223_B8C4A4E9 X-CRM114-Status: GOOD ( 15.30 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Dec 25, 2023 at 02:29:53PM +0800, Muchun Song wrote: > > @@ -1355,6 +1355,10 @@ static inline int pmd_write(pmd_t pmd) > > #endif /* pmd_write */ > > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > > +#ifndef pmd_thp_or_huge > > I think it may be the time to rename to pmd_thp_or_hugetlb, > the "huge" is really confusing. thp is not huge? Actually, > it is huge. It is better to make it more specific from now on, like > "hugetlb". The rename will need to touch ARM code, which I wanted to avoid, see: arch/arm64/include/asm/pgtable.h:#define pmd_thp_or_huge(pmd) (pmd_huge(pmd) || pmd_trans_huge(pmd)) So far this series only touches generic code. Would you mind I keep this patch as-is, and leave renaming to later? > > BTW, please cc me via the new email (muchun.song@linux.dev) next edition. Sure. Thanks for taking a look. -- Peter Xu _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB024C46CD2 for ; Tue, 2 Jan 2024 05:38:29 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Odj7rz48; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dfCljb4P; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4T41q81W8Bz3cSv for ; Tue, 2 Jan 2024 16:38:28 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Odj7rz48; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dfCljb4P; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=peterx@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4T41pB0xLJz2xQH for ; Tue, 2 Jan 2024 16:37:36 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704173853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eCnGZSmn0Xbft/VvC3w27VmkfIRRQMc7XVfvoJNmfHo=; b=Odj7rz48zp0HHWF24KJK3cwlgQo/J4wkGft2blXKh0bPgU+Am7N0j6QZgAGM+iELbDMA3R cbnACgNgxhvOTt8EaPVRigYeyE72G14ntjNv3lOBY+8/EXG38cBgTjTVUW9r7LGVgjr+Cf 8c0y4/+nBWKoaRo9KePvQmvUvj3/Fm8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704173854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eCnGZSmn0Xbft/VvC3w27VmkfIRRQMc7XVfvoJNmfHo=; b=dfCljb4P/Zm94hlE5D7Mk9MJ7dVJZnzqd5rw5ipiAzqqVzIdwivZaOBek4WGjkk+r0iXav YIHdrpH5OAY9LTWwwsPBxZbAXVQuC+/F7OCl7tp/jGaVUwIkNOkIRql4cnQwcVPV2cbC+z jYj7m7GjZBkGV2xDmznS0kBI+CVeGCw= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-408-laKnWce5Mku0qc3BgK-UkQ-1; Tue, 02 Jan 2024 00:37:32 -0500 X-MC-Unique: laKnWce5Mku0qc3BgK-UkQ-1 Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-6d9bf77a474so1816179b3a.0 for ; Mon, 01 Jan 2024 21:37:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704173851; x=1704778651; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eCnGZSmn0Xbft/VvC3w27VmkfIRRQMc7XVfvoJNmfHo=; b=fzj5RZtROqlEyAZuOIg9KM3wqS/ujXM4P69R8Fe17HkjTVWkHm5sNIqyloOvHS9Hxr xpfp8c1seK3Gb9GlSUhiQcBCJQzKDQYxdw9H1X9W2aTSUSvbgSCK06MAj4cb2we9Jis1 a2e+krL0yP7QhIMQF36tb/htBOmjcQ0v3EzdyJuQXHPeT0qtvfZTQJpNXKtL6U+EcPWL LwAsCsgo2EPDqPVY6XWi/sY27ZEpGLrGTSnOVG6DJJjBUWawSujNwMjgDGHQaDlX/byo 9uLQlLF+a5+hFx0AiIgxpawhK8DM6PdmIHfjypHk9ohfJhlg4nBQq/XDZCamjDg5GTpa mrOQ== X-Gm-Message-State: AOJu0YwwkmSLmnHS2ORTxsnrBXxTmeGu2eUMlnZjOX6+SlUf4CxhHvq/ +4XrxFnVHNnIrwrJWrfSBvbLectXGZubnjdMwJHSxPadTHQU/jclylJgQHTwB7FGBYS83R6kYaA Vi4pw5+fobotqzrFq5UmoZm/G44IZmaj/8w== X-Received: by 2002:a17:902:ce86:b0:1d3:eecd:b296 with SMTP id f6-20020a170902ce8600b001d3eecdb296mr33590824plg.6.1704173851405; Mon, 01 Jan 2024 21:37:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IHENzr2M0aJyyZm2vt3XzuVCeWLevZs5IuWsUdjc1ZzU9FWxHr/jzg4D3MMktI1x4ptpcHyFg== X-Received: by 2002:a17:902:ce86:b0:1d3:eecd:b296 with SMTP id f6-20020a170902ce8600b001d3eecdb296mr33590810plg.6.1704173851161; Mon, 01 Jan 2024 21:37:31 -0800 (PST) Received: from x1n ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id v4-20020a17090331c400b001d49c0daf60sm6900347ple.265.2024.01.01.21.37.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jan 2024 21:37:30 -0800 (PST) Date: Tue, 2 Jan 2024 13:37:14 +0800 From: Peter Xu To: Muchun Song Subject: Re: [PATCH 03/13] mm: Provide generic pmd_thp_or_huge() Message-ID: References: <20231219075538.414708-1-peterx@redhat.com> <20231219075538.414708-4-peterx@redhat.com> <135b3189-f459-4b57-9861-bb8acb999d91@linux.dev> MIME-Version: 1.0 In-Reply-To: <135b3189-f459-4b57-9861-bb8acb999d91@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: James Houghton , David Hildenbrand , Yang Shi , Andrew Jones , linux-mm@kvack.org, Matthew Wilcox , linux-riscv@lists.infradead.org, Andrea Arcangeli , Christoph Hellwig , "Aneesh Kumar K . V" , Vlastimil Babka , Jason Gunthorpe , Axel Rasmussen , Rik van Riel , John Hubbard , "Kirill A . Shutemov" , linux-arm-kernel@lists.infradead.org, Lorenzo Stoakes , linux-kernel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, Mike Rapoport , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Dec 25, 2023 at 02:29:53PM +0800, Muchun Song wrote: > > @@ -1355,6 +1355,10 @@ static inline int pmd_write(pmd_t pmd) > > #endif /* pmd_write */ > > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > > +#ifndef pmd_thp_or_huge > > I think it may be the time to rename to pmd_thp_or_hugetlb, > the "huge" is really confusing. thp is not huge? Actually, > it is huge. It is better to make it more specific from now on, like > "hugetlb". The rename will need to touch ARM code, which I wanted to avoid, see: arch/arm64/include/asm/pgtable.h:#define pmd_thp_or_huge(pmd) (pmd_huge(pmd) || pmd_trans_huge(pmd)) So far this series only touches generic code. Would you mind I keep this patch as-is, and leave renaming to later? > > BTW, please cc me via the new email (muchun.song@linux.dev) next edition. Sure. Thanks for taking a look. -- Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A920C46CD2 for ; Tue, 2 Jan 2024 05:38:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kkg1nEh8nasS2/MUSb+hYdHpGgRlr9Em/YdBxwlT784=; b=nktH52SNj/06xc E6aDA0Lt4DiC4B76OdMlsa+rL7uNNzgp2mvF23HxpicCwENdVFrwRPlyJevWUyg92QlXypBnJDzwK Nfxgga8mX5DOBQX/YSR2g3X00UOGxciRsM2DpGXhGHXHTwz/eFaqRJop/bPevCpZAuEe8ucn5M3h5 d+HxaGSiCeXmjuWpcFPB8Q2ZlXK5rcRt44wTAoxWol3u4NE6f6TWfdgxQjf9HG3uUNFn8hWmYjV2E UXKk0q/neRnv2oZvJ8CPEckIokHkROEeedOu4JuNM5VroKGyLbNgLswy8c+yWinHsrQ9QBiSXBY9+ Trm7AlBYfYTft2A1pwgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rKXTA-0077t7-1f; Tue, 02 Jan 2024 05:37:40 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rKXT7-0077rW-0l for linux-arm-kernel@lists.infradead.org; Tue, 02 Jan 2024 05:37:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704173853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eCnGZSmn0Xbft/VvC3w27VmkfIRRQMc7XVfvoJNmfHo=; b=Odj7rz48zp0HHWF24KJK3cwlgQo/J4wkGft2blXKh0bPgU+Am7N0j6QZgAGM+iELbDMA3R cbnACgNgxhvOTt8EaPVRigYeyE72G14ntjNv3lOBY+8/EXG38cBgTjTVUW9r7LGVgjr+Cf 8c0y4/+nBWKoaRo9KePvQmvUvj3/Fm8= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-152-RC_xA5nVNlGjp8VG6lR9MA-1; Tue, 02 Jan 2024 00:37:32 -0500 X-MC-Unique: RC_xA5nVNlGjp8VG6lR9MA-1 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-28bea0ff98cso2090992a91.0 for ; Mon, 01 Jan 2024 21:37:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704173851; x=1704778651; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eCnGZSmn0Xbft/VvC3w27VmkfIRRQMc7XVfvoJNmfHo=; b=mSNEJ/FP9uWMTUNF1uQ/CSB8gzPg6V+v2dDvWSy16CsbkjXovBpGTV022AHoKg9x3H mqYchRgOF2pk8n1DCPT88gizXltIq/k+SdeCDOMq1M2X0Nrq7ZrenWun7NC769MKNZ5C D8JY5BM8cIg22o1xK6yPH6IJJ35AaTLnVfguzCkcfi9OYYjq8EIfYudTJzS64/szuhpP UZzz0kTu3Madjb+x882oXWdqiqUk1K5PtjArh95CV+4ettqMbdOaaR8xx9oorH70DtN2 on3uUazoGszabuRmGTpKlyWFxWIvquvjviG2gkpfnD+eY5xze4RAgQANrwH8EfvJSQu1 VEEA== X-Gm-Message-State: AOJu0Yyh1sES75lEBRoPfjFXxYEeUdPwTvoySy2s6UiNsVdV1CJknF9a LuU/tC9sqqpR+2szzpv9I+7gXFUS8Yx7y8JFpQOuIyQgKWcWHz/UFcbRcwnVEHsOG3UiFB3jO2b xnCaZ+Kv02CoqQv0ymNpA9LqxeYAOkrgo97oeA4rXCes= X-Received: by 2002:a17:902:ce86:b0:1d3:eecd:b296 with SMTP id f6-20020a170902ce8600b001d3eecdb296mr33590828plg.6.1704173851407; Mon, 01 Jan 2024 21:37:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IHENzr2M0aJyyZm2vt3XzuVCeWLevZs5IuWsUdjc1ZzU9FWxHr/jzg4D3MMktI1x4ptpcHyFg== X-Received: by 2002:a17:902:ce86:b0:1d3:eecd:b296 with SMTP id f6-20020a170902ce8600b001d3eecdb296mr33590810plg.6.1704173851161; Mon, 01 Jan 2024 21:37:31 -0800 (PST) Received: from x1n ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id v4-20020a17090331c400b001d49c0daf60sm6900347ple.265.2024.01.01.21.37.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jan 2024 21:37:30 -0800 (PST) Date: Tue, 2 Jan 2024 13:37:14 +0800 From: Peter Xu To: Muchun Song Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , Christophe Leroy , Lorenzo Stoakes , David Hildenbrand , Vlastimil Babka , Mike Kravetz , Mike Rapoport , Christoph Hellwig , John Hubbard , Andrew Jones , linux-arm-kernel@lists.infradead.org, Michael Ellerman , "Kirill A . Shutemov" , linuxppc-dev@lists.ozlabs.org, Rik van Riel , linux-riscv@lists.infradead.org, Yang Shi , James Houghton , "Aneesh Kumar K . V" , Andrew Morton , Jason Gunthorpe , Andrea Arcangeli , Axel Rasmussen Subject: Re: [PATCH 03/13] mm: Provide generic pmd_thp_or_huge() Message-ID: References: <20231219075538.414708-1-peterx@redhat.com> <20231219075538.414708-4-peterx@redhat.com> <135b3189-f459-4b57-9861-bb8acb999d91@linux.dev> MIME-Version: 1.0 In-Reply-To: <135b3189-f459-4b57-9861-bb8acb999d91@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240101_213737_785912_4AA5393A X-CRM114-Status: GOOD ( 16.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 25, 2023 at 02:29:53PM +0800, Muchun Song wrote: > > @@ -1355,6 +1355,10 @@ static inline int pmd_write(pmd_t pmd) > > #endif /* pmd_write */ > > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > > +#ifndef pmd_thp_or_huge > > I think it may be the time to rename to pmd_thp_or_hugetlb, > the "huge" is really confusing. thp is not huge? Actually, > it is huge. It is better to make it more specific from now on, like > "hugetlb". The rename will need to touch ARM code, which I wanted to avoid, see: arch/arm64/include/asm/pgtable.h:#define pmd_thp_or_huge(pmd) (pmd_huge(pmd) || pmd_trans_huge(pmd)) So far this series only touches generic code. Would you mind I keep this patch as-is, and leave renaming to later? > > BTW, please cc me via the new email (muchun.song@linux.dev) next edition. Sure. Thanks for taking a look. -- Peter Xu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64BDDC46CD2 for ; Tue, 2 Jan 2024 05:37:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 092F36B006E; Tue, 2 Jan 2024 00:37:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 043576B0078; Tue, 2 Jan 2024 00:37:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E31176B007E; Tue, 2 Jan 2024 00:37:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D10016B006E for ; Tue, 2 Jan 2024 00:37:36 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9F77640741 for ; Tue, 2 Jan 2024 05:37:36 +0000 (UTC) X-FDA: 81633263712.23.8BAA290 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 904E518000F for ; Tue, 2 Jan 2024 05:37:34 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Odj7rz48; spf=pass (imf06.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704173854; a=rsa-sha256; cv=none; b=slmchKVsq6L6dFsl/RtiTWd5/Phbx8gTseQTNiJrP3kKNd0wNhavrjtyg02uIipioYmdNr jZONHrPCiBKnRe0n0CTFU0Ohmrr8o51mH2lzPcisfbUMm3VGhii4IEWZn0mOo704x0B1Zp /x0XuTs3NNgU+R6DcFGf4edQ0KcmiYM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Odj7rz48; spf=pass (imf06.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704173854; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eCnGZSmn0Xbft/VvC3w27VmkfIRRQMc7XVfvoJNmfHo=; b=LaCSlpNrjUhxW774HU8K23gIhxbBoSlw1H8aN19H/GesKBbYoEDpAWR84+b4g4y5xwPRv1 5FulYttSTZu/cYT7DFVAJWh5xKT3CSeXBBy9CaIgq/M57lsyiwqIMIswyd2bnd+v3XfXYS p0cS2nkhACiT16gzZBX4f+mfLlSl3v0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704173853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eCnGZSmn0Xbft/VvC3w27VmkfIRRQMc7XVfvoJNmfHo=; b=Odj7rz48zp0HHWF24KJK3cwlgQo/J4wkGft2blXKh0bPgU+Am7N0j6QZgAGM+iELbDMA3R cbnACgNgxhvOTt8EaPVRigYeyE72G14ntjNv3lOBY+8/EXG38cBgTjTVUW9r7LGVgjr+Cf 8c0y4/+nBWKoaRo9KePvQmvUvj3/Fm8= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-408-EmvlHgAMO_K2BQ-vDcoNcg-1; Tue, 02 Jan 2024 00:37:32 -0500 X-MC-Unique: EmvlHgAMO_K2BQ-vDcoNcg-1 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-28c0765415eso1772220a91.1 for ; Mon, 01 Jan 2024 21:37:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704173851; x=1704778651; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eCnGZSmn0Xbft/VvC3w27VmkfIRRQMc7XVfvoJNmfHo=; b=eb5LtK4F3O6G5AXcT2lNqLCLUMkuCA79zPI6evuB/7FmPvS3TdhaIcZMp9IDR8Rvmt WBDB7obPIc5YjF1ezppMNVlGT17OnwV8WhOLkGVlePEpP7cge2ubi9J1GvKAdE67nn6r 1OuT9f5jYyL+Sb9Hf1yQXIZTYnZPu5Jbm50j/lam7MolQtFIXpt5epF13AuQTzx1cfl1 YAD8ngDVGIs74SmP3Nvl2wq/ST3m/BmCZ9oaMMb5nQtEJ/LlUZBed1z5F8d1bjWmBRkT MoepNXnxCMYILh/jgJ90fZ1gtLOPb37efEhd4c7bpyvIX/mBNn8yjyGX/5p1wpfw9H/Y VnuA== X-Gm-Message-State: AOJu0Yy6HPR5GCIMZspmm+G6D2Sa3CVW7Ubi1BV2KmlEw1kjTasL0KqU jHFviL+1o23f/uPLeBd0PWja0h65Fds5zVmJMwhkN+tIKT+q95/nY+AkUxh8Ddd6RWwlv5E1qKr SQx09w7hnrAm4u80U7ns= X-Received: by 2002:a17:902:ce86:b0:1d3:eecd:b296 with SMTP id f6-20020a170902ce8600b001d3eecdb296mr33590832plg.6.1704173851408; Mon, 01 Jan 2024 21:37:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IHENzr2M0aJyyZm2vt3XzuVCeWLevZs5IuWsUdjc1ZzU9FWxHr/jzg4D3MMktI1x4ptpcHyFg== X-Received: by 2002:a17:902:ce86:b0:1d3:eecd:b296 with SMTP id f6-20020a170902ce8600b001d3eecdb296mr33590810plg.6.1704173851161; Mon, 01 Jan 2024 21:37:31 -0800 (PST) Received: from x1n ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id v4-20020a17090331c400b001d49c0daf60sm6900347ple.265.2024.01.01.21.37.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jan 2024 21:37:30 -0800 (PST) Date: Tue, 2 Jan 2024 13:37:14 +0800 From: Peter Xu To: Muchun Song Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , Christophe Leroy , Lorenzo Stoakes , David Hildenbrand , Vlastimil Babka , Mike Kravetz , Mike Rapoport , Christoph Hellwig , John Hubbard , Andrew Jones , linux-arm-kernel@lists.infradead.org, Michael Ellerman , "Kirill A . Shutemov" , linuxppc-dev@lists.ozlabs.org, Rik van Riel , linux-riscv@lists.infradead.org, Yang Shi , James Houghton , "Aneesh Kumar K . V" , Andrew Morton , Jason Gunthorpe , Andrea Arcangeli , Axel Rasmussen Subject: Re: [PATCH 03/13] mm: Provide generic pmd_thp_or_huge() Message-ID: References: <20231219075538.414708-1-peterx@redhat.com> <20231219075538.414708-4-peterx@redhat.com> <135b3189-f459-4b57-9861-bb8acb999d91@linux.dev> MIME-Version: 1.0 In-Reply-To: <135b3189-f459-4b57-9861-bb8acb999d91@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 904E518000F X-Stat-Signature: h3idpy35hc3gizi14zjskneh499oyawg X-Rspam-User: X-HE-Tag: 1704173854-555772 X-HE-Meta: U2FsdGVkX1+8fyqSIQl8oSUybzWHcVJ7oA2hl7hD0KaiV82LZX9ZPBNIvGDKx7hrs/osmIvZqRyDFRNoNaG6y+FRVq4o6sU+9DoujLmS29U5SUY5u0FnWPCt03SWLyWhF4V2qPiSotW5ffxaYKnpC7d3hi4JPKEle/xlDL/UicLUSATs8EtEq20D+/8SYB4R3DmVKDx4z97invgaxomRAB7F1HOmRR8CkPMlL15UXKiVrVBc3/4BXQDyHk5RhzJfGzdQKxBJDZUuogXTIy8/SaLj/MW1Wf2BcMCBschkbPib/z3B7Ksw5CZfm0AD4LHtaOCnHJigXSXP1+PkBodJuNEh+08hJvM0NI5fO8eoOVEe0xy3xBBsRHqPgvZyUh5IS27p4sfAZvsS6mjjzEjRlPYZtG8RaKPiYGkeCNBUftClrffBgIj+aytHKiJdRvuh0V96Pog76z5E4h7s17N9ftqPpCAgPIxQatU3QWp6xIwrl7+sFK3PO+wv4PlgzHRPglm13LhWtQM8r5ENkCMheo+a13UAkALIeT4T2OhQlhHAz4IOnElEeZAZhPYBvHi/80BRmx6P3PW+YC1h8/oyAp5KDOljXcw+rmW/TNcTNK0UPlvj5zYHZDgvUcdJlxXaZyVUM7xK1UcelNS6CP07iF7tUSSmeQRzyXQidc30FZfxVc20hOBNfNmi3+3TJrsK5UNHSb1dQm/PBmheyRmyfq4b8ywMv70o9ILJoW8wcV9JaaXaPRdv17qJ5pGQIZPWYkbI8eRypLSNr6GrNH7P9EW/ZWhTcI1B1dtLKL8jbNTPieo1EcwcSs/TsrNEU80UrwJUvlxVov7YYIglX/XjS+g4v+c7WYtY3V/2g74uTArqhfsIUGIWWvycvcX/YJhB+T5dS9EnYn+YBFhWjutjb9H+hIarX29M4IPCikUZG1eQQMCCSd8/Xa0RYKppPn81YEalOGbmxZjP/BZBODJ /zv67rvH ojHaB9wVpZmKe7QX5ra/5G+Jv0OB3yUT/M31b8/kP3rkTdHza/xVsDxkI27KYxCWBT8lYaPoIB22PB7dU1JqqJFZ4Gr6TfLQApONBHJVbNYzjVJasGk7uruZR0bwjoWszy0H3LgtnU4rO84SB3Wyw9ZRi81ebKJeK2hUOL5ZDh2duFASh4+Rq+QpCDTgsu3azWAMN1ir3PoGLZJreVKqNb1vWhOzWENXZ2YI6zah1fN7r0JBOMjkC1/PcHqJI+toW22waMhjZV9nUP0AOx5zZUFONn+ObKaxVYKsL0h27lDnUbUwdJLg35QMi9OSXQg3xZWE+ru3LWp4XbkEe3mT/AOb2pgfYpZt4N44G54Ae8sezwU2Yc1Qkguoun3HDjEheI9wxcs6qzhnMYfgp1uFpRI8d+y4M+8O5e6/G9ljK2rdWtmbEW23G8ZweBzds5L6W/QgASt2VABYObi0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 25, 2023 at 02:29:53PM +0800, Muchun Song wrote: > > @@ -1355,6 +1355,10 @@ static inline int pmd_write(pmd_t pmd) > > #endif /* pmd_write */ > > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > > +#ifndef pmd_thp_or_huge > > I think it may be the time to rename to pmd_thp_or_hugetlb, > the "huge" is really confusing. thp is not huge? Actually, > it is huge. It is better to make it more specific from now on, like > "hugetlb". The rename will need to touch ARM code, which I wanted to avoid, see: arch/arm64/include/asm/pgtable.h:#define pmd_thp_or_huge(pmd) (pmd_huge(pmd) || pmd_trans_huge(pmd)) So far this series only touches generic code. Would you mind I keep this patch as-is, and leave renaming to later? > > BTW, please cc me via the new email (muchun.song@linux.dev) next edition. Sure. Thanks for taking a look. -- Peter Xu