From: Breno Leitao <leitao@debian.org>
To: Simon Horman <horms@kernel.org>, vegard.nossum@oracle.com
Cc: Vegard Nossum <vegard.nossum@oracle.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH net-next] Documentation: add pyyaml to requirements.txt
Date: Tue, 2 Jan 2024 03:51:35 -0800 [thread overview]
Message-ID: <ZZP4x7oSbLdugeDL@gmail.com> (raw)
In-Reply-To: <20231224164620.GB228041@kernel.org>
Hello Vegard,
On Fri, Dec 22, 2023 at 02:36:28PM +0100, Vegard Nossum wrote:
> Commit f061c9f7d058 ("Documentation: Document each netlink family") added
> a new Python script that is invoked during 'make htmldocs' and which reads
> the netlink YAML spec files.
>
> Using the virtualenv from scripts/sphinx-pre-install, we get this new
> error wen running 'make htmldocs':
The commit doesn't depend on sphinx. This is a standalone script now.
The requirements file is at tools/net/ynl/requirements.txt not in sphinx
> Note: This was somehow present in the original patch submission:
> <https://lore.kernel.org/all/20231103135622.250314-1-leitao@debian.org/>
> I'm not sure why the pyyaml requirement disappeared in the meantime.
It disapperared because the original patch version was a sphinx module,
thus, pyaml was not at sphinx dependency.
In the commit final form, the script is a standalone script inside
'tools/net/ynl', and PyYAML is already tracked in
`tools/net/ynl/requirements.txt`.
That said, can you try to install `tools/net/ynl/requirements.txt` and
see if you are able to reproduce the problem?
next prev parent reply other threads:[~2024-01-02 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 13:36 [PATCH net-next] Documentation: add pyyaml to requirements.txt Vegard Nossum
2023-12-22 17:40 ` Jani Nikula
2023-12-24 16:46 ` Simon Horman
2024-01-02 11:51 ` Breno Leitao [this message]
2024-01-02 13:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZP4x7oSbLdugeDL@gmail.com \
--to=leitao@debian.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.