Re: [Buildroot] [PATCH 1/1] Revert "package/docker: enable selinux module"

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] Revert "package/docker: enable selinux module"
Date: Tue, 2 Jan 2024 20:57:40 +0100	[thread overview]
Message-ID: <ZZRqtHvbEG1i8Fbk@landeda> (raw)
In-Reply-To: <20240102194155.1345165-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2024-01-02 20:41 +0100, Fabrice Fontaine spake thusly:
> This reverts commit 245b13a0778ec6ad061555b0b994e7649ef01006 as docker
> selinux module is for docker-engine, not for "a system tray dock for X"
> 
> Moreover, it raises the following build failure:
> 
> Compiling targeted policy.33
> env LD_LIBRARY_PATH="/home/buildroot/autobuild/instance-0/output-1/per-package/refpolicy/host/lib:/home/buildroot/autobuild/instance-0/output-1/per-package/refpolicy/host/usr/lib" /home/buildroot/autobuild/instance-0/output-1/per-package/refpolicy/host/usr/bin/checkpolicy -c 33 -U deny -S -O -E policy.conf -o policy.33
> policy.conf:1912:ERROR 'attribute container_engine_domain is not declared' at token ';' on line 1912:
> type dockerd_t, container_engine_domain;
> type dockerd_exec_t;

Does that mean we can't do:

    DOCKER_ENGINE_SELINUX_MODULES = docker

either?

> Fixes:
>  - http://autobuild.buildroot.org/results/87d78b6f15875f0fa3e6fc85e352db14ab0383bb
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/docker/docker.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/docker/docker.mk b/package/docker/docker.mk
> index 39f7ee4580..4a8c6fcd8d 100644
> --- a/package/docker/docker.mk
> +++ b/package/docker/docker.mk
> @@ -7,7 +7,7 @@
>  DOCKER_VERSION = 1.5
>  DOCKER_SITE = http://icculus.org/openbox/2/docker
>  DOCKER_DEPENDENCIES = host-pkgconf libglib2 xlib_libX11
> -DOCKER_SELINUX_MODULES = docker
> +
>  DOCKER_LICENSE = GPL-2.0+
>  # The 'or later' is specified at the end of the README, so include that one too.
>  DOCKER_LICENSE_FILES = COPYING README
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot