From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75091C46CD2 for ; Tue, 2 Jan 2024 20:04:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9ipidn9DdcAG05+2ISRwacXC4HlVwQBjrEQo8ewArjc=; b=aPPt+v/Wk9dy+0B7kDDH30WX6s mJlCyXYWilpOZcJuORtLuS0fAMqUqRtfSazSyNXRDQanBVEO02R+hJaOIvqxHcn59ElhvaOe4U1AJ gaR4UdvoGPcyoID9GoPmfdA5mAqyRt7X54AM3zr3+T2EmaPo6kjqY+JkAxybyCqUkSFLOnWhpaz4F 2v1EFrq5GQY3mx6HrxY4zbWJ9izLVW/sjs8XjGIOQMP4UX7DrHcEx9aGRE4kWu+zLDggWwQzUO6Vl oLnJeDpvMUj3ZkRXzNb73pxmizI2Dgg2M5we2fg6WMXY0ZSC2zbaxOlB58ZTMlUwYmOX3AR2VPxIB 6rAGnliw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rKl00-008tgv-2O; Tue, 02 Jan 2024 20:04:28 +0000 Received: from pidgin.makrotopia.org ([185.142.180.65]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rKkzx-008tgM-2b; Tue, 02 Jan 2024 20:04:27 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1rKkzf-0000Qg-1y; Tue, 02 Jan 2024 20:04:09 +0000 Date: Tue, 2 Jan 2024 21:01:23 +0100 From: Daniel Golle To: Eric Woudstra Subject: Re: [PATCH RFC net-next] net: pcs: pcs-mtk-lynxi fix mtk_pcs_lynxi_get_state() for 2500base-x Message-ID: References: <20240102074408.1049203-1-ericwouds@gmail.com> <92190426-3614-4774-9E9F-18F121622788@gmail.com> <74223164-ab50-4d6d-a4f4-561b0a70d396@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <74223164-ab50-4d6d-a4f4-561b0a70d396@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240102_120425_841658_28CD74F4 X-CRM114-Status: GOOD ( 10.74 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , AngeloGioacchino Del Regno , netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, "Russell King \(Oracle\)" , linux-kernel@vger.kernel.org, Eric Dumazet , Alexander Couzens , Matthias Brugger , Jakub Kicinski , Paolo Abeni , "David S. Miller" , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Jan 02, 2024 at 08:33:32PM +0100, Eric Woudstra wrote: > [...] > > So if phylink_mii_c22_pcs_decode_state() should not set the speed, then it is not correctly set somewhere else. Yes, but the fix should go to pcs-mtk-lynxi.c and you don't need to change phylink for it to work. This should be enough: https://patchwork.kernel.org/project/netdevbpf/patch/091e466912f1333bb76d23e95dc6019c9b71645f.1699565880.git.daniel@makrotopia.org/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22AEAC46CD2 for ; Tue, 2 Jan 2024 20:04:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ryIP7WFhtb7K4VqhgBY1G0TAV9MvIYe2MGZeKDMWXUU=; b=aJZmCWL529VUP5 3DlA89WUDjDUcGVQ/J0cBA6jl7BBdAbQ25crrANsAeLmEa64N0ozN5HMZLlRKZGNBJNokw9Nu5wIJ DSDZgSm7a2q1OfzMZrya1f5A3SMp6mSsllTQu5AprEvHDe6Vj2tV3xaMxDuJkNYPImgen9WR9Me58 8A4EaJFvSjDQWP89coglKziseF11KnHSUYiHiOn3AhIonyjkOVGF9u0oq6AnBQzZokXfY+OjrqMKI YR2tvs0Ow5lB93KTewY6CvSja0KYhXVA1LEfdtNuoJpWcJRxqU9R68Eh0T5LBk4X5uynEH6LULMNP 7Jp3+hkA+gu2V+TT9XSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rKl00-008tgr-0Z; Tue, 02 Jan 2024 20:04:28 +0000 Received: from pidgin.makrotopia.org ([185.142.180.65]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rKkzx-008tgM-2b; Tue, 02 Jan 2024 20:04:27 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1rKkzf-0000Qg-1y; Tue, 02 Jan 2024 20:04:09 +0000 Date: Tue, 2 Jan 2024 21:01:23 +0100 From: Daniel Golle To: Eric Woudstra Cc: "Russell King (Oracle)" , Alexander Couzens , Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH RFC net-next] net: pcs: pcs-mtk-lynxi fix mtk_pcs_lynxi_get_state() for 2500base-x Message-ID: References: <20240102074408.1049203-1-ericwouds@gmail.com> <92190426-3614-4774-9E9F-18F121622788@gmail.com> <74223164-ab50-4d6d-a4f4-561b0a70d396@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <74223164-ab50-4d6d-a4f4-561b0a70d396@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240102_120425_841658_28CD74F4 X-CRM114-Status: GOOD ( 10.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 02, 2024 at 08:33:32PM +0100, Eric Woudstra wrote: > [...] > > So if phylink_mii_c22_pcs_decode_state() should not set the speed, then it is not correctly set somewhere else. Yes, but the fix should go to pcs-mtk-lynxi.c and you don't need to change phylink for it to work. This should be enough: https://patchwork.kernel.org/project/netdevbpf/patch/091e466912f1333bb76d23e95dc6019c9b71645f.1699565880.git.daniel@makrotopia.org/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85C3616400; Tue, 2 Jan 2024 20:04:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1rKkzf-0000Qg-1y; Tue, 02 Jan 2024 20:04:09 +0000 Date: Tue, 2 Jan 2024 21:01:23 +0100 From: Daniel Golle To: Eric Woudstra Cc: "Russell King (Oracle)" , Alexander Couzens , Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH RFC net-next] net: pcs: pcs-mtk-lynxi fix mtk_pcs_lynxi_get_state() for 2500base-x Message-ID: References: <20240102074408.1049203-1-ericwouds@gmail.com> <92190426-3614-4774-9E9F-18F121622788@gmail.com> <74223164-ab50-4d6d-a4f4-561b0a70d396@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <74223164-ab50-4d6d-a4f4-561b0a70d396@gmail.com> On Tue, Jan 02, 2024 at 08:33:32PM +0100, Eric Woudstra wrote: > [...] > > So if phylink_mii_c22_pcs_decode_state() should not set the speed, then it is not correctly set somewhere else. Yes, but the fix should go to pcs-mtk-lynxi.c and you don't need to change phylink for it to work. This should be enough: https://patchwork.kernel.org/project/netdevbpf/patch/091e466912f1333bb76d23e95dc6019c9b71645f.1699565880.git.daniel@makrotopia.org/