From: Jiri Pirko <jiri@resnulli.us>
To: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Cc: netdev@vger.kernel.org, vadim.fedorenko@linux.dev,
michal.michalik@intel.com, milena.olech@intel.com,
pabeni@redhat.com, kuba@kernel.org,
Jan Glaza <jan.glaza@intel.com>
Subject: Re: [PATCH net v2 4/4] dpll: hide "zombie" pins for userspace
Date: Thu, 4 Jan 2024 16:07:09 +0100 [thread overview]
Message-ID: <ZZbJndeZ09-DeztP@nanopsycho> (raw)
In-Reply-To: <20240104111132.42730-5-arkadiusz.kubalewski@intel.com>
Thu, Jan 04, 2024 at 12:11:32PM CET, arkadiusz.kubalewski@intel.com wrote:
[...]
>@@ -1179,6 +1195,10 @@ int dpll_nl_pin_set_doit(struct sk_buff *skb, struct genl_info *info)
What about dpll_nl_pin_get_doit(), dpll_nl_pin_id_get_doit()?
I think it would be better to move the check to:
dpll_pin_pre_doit()
> {
> struct dpll_pin *pin = info->user_ptr[0];
>
>+ if (!xa_empty(&pin->parent_refs) &&
>+ !dpll_pin_parents_registered(pin))
>+ return -ENODEV;
>+
> return dpll_pin_set_from_nlattr(pin, info);
> }
>
>--
>2.38.1
>
next prev parent reply other threads:[~2024-01-04 15:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 11:11 [PATCH net v2 0/4] dpll: fix unordered unbind/bind registerer issues Arkadiusz Kubalewski
2024-01-04 11:11 ` [PATCH net v2 1/4] dpll: fix pin dump crash after module unbind Arkadiusz Kubalewski
2024-01-04 15:08 ` Jiri Pirko
2024-01-11 9:06 ` Kubalewski, Arkadiusz
2024-01-04 11:11 ` [PATCH net v2 2/4] dpll: fix pin dump crash for rebound module Arkadiusz Kubalewski
2024-01-04 15:40 ` Jiri Pirko
2024-01-11 9:07 ` Kubalewski, Arkadiusz
2024-01-04 11:11 ` [PATCH net v2 3/4] dpll: fix register pin with unregistered parent pin Arkadiusz Kubalewski
2024-01-04 14:48 ` Jiri Pirko
2024-01-11 9:06 ` Kubalewski, Arkadiusz
2024-01-04 11:11 ` [PATCH net v2 4/4] dpll: hide "zombie" pins for userspace Arkadiusz Kubalewski
2024-01-04 15:04 ` Jiri Pirko
2024-01-11 9:16 ` Kubalewski, Arkadiusz
2024-01-04 15:07 ` Jiri Pirko [this message]
2024-01-11 9:16 ` Kubalewski, Arkadiusz
2024-01-04 15:09 ` Jiri Pirko
2024-01-11 9:16 ` Kubalewski, Arkadiusz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZbJndeZ09-DeztP@nanopsycho \
--to=jiri@resnulli.us \
--cc=arkadiusz.kubalewski@intel.com \
--cc=jan.glaza@intel.com \
--cc=kuba@kernel.org \
--cc=michal.michalik@intel.com \
--cc=milena.olech@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.