All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhao Liu <zhao1.liu@linux.intel.com>
To: Samuel Tardieu <samuel.tardieu@telecom-paris.fr>
Cc: "Michael Tokarev" <mjt@tls.msk.ru>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Darren Kenny" <darren.kenny@oracle.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-trivial@nongnu.org, "Zhenyu Wang" <zhenyu.z.wang@intel.com>,
	"Zhao Liu" <zhao1.liu@intel.com>,
	"Yongwei Ma" <yongwei.ma@intel.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH v2] scripts/checkpatch: Support codespell checking
Date: Fri, 5 Jan 2024 00:21:02 +0800	[thread overview]
Message-ID: <ZZba7sAdGooq482x@intel.com> (raw)
In-Reply-To: <87frze5vlc.fsf@telecom-paris.fr>

Hi Samuel,

On Wed, Jan 03, 2024 at 03:36:59PM +0100, Samuel Tardieu wrote:
> Date: Wed, 03 Jan 2024 15:36:59 +0100
> From: Samuel Tardieu <samuel.tardieu@telecom-paris.fr>
> Subject: Re: [PATCH v2] scripts/checkpatch: Support codespell checking
> 
> > +  --codespell                Use the codespell dictionary for
> > spelling/typos
> > +                             (default:$codespellfile)
> 
> Nitpick: I would have used a space after ":".

OK! I'll add it to improve the readability of the help printout.

> 
> > +	# If /usr/share/codespell/dictionary.txt is not present, try to find
> > it
> > +	# under codespell's install directory:
> > <codespell_root>/data/dictionary.txt
> 
> This works correctly on my NixOS system using a non-FHS layout and properly
> locates the codespell file.
> 
> This patch made me find a typo in one of my commit messages.
> 
> Tested-by: Samuel Tardieu <sam@rfc1149.net>
>

Thanks! Good to know this enhancement can help you!

Regards,
Zhao



      reply	other threads:[~2024-01-04 16:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-15 10:34 [PATCH v2] scripts/checkpatch: Support codespell checking Zhao Liu
2024-01-03 14:07 ` Zhao Liu
2024-01-03 14:36 ` Samuel Tardieu
2024-01-04 16:21   ` Zhao Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZZba7sAdGooq482x@intel.com \
    --to=zhao1.liu@linux.intel.com \
    --cc=alex.bennee@linaro.org \
    --cc=darren.kenny@oracle.com \
    --cc=laurent@vivier.eu \
    --cc=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=samuel.tardieu@telecom-paris.fr \
    --cc=thuth@redhat.com \
    --cc=yongwei.ma@intel.com \
    --cc=zhao1.liu@intel.com \
    --cc=zhenyu.z.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.