From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 408CA28DD7 for ; Thu, 4 Jan 2024 17:18:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Ja8Ppc1S" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-28ca63fd071so417898a91.3 for ; Thu, 04 Jan 2024 09:18:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1704388699; x=1704993499; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=IRi6ZcW7R00/a07ptTf12NVKem9z9qCQn2dzbpt/bz4=; b=Ja8Ppc1S3aCr5sZA7GHoefZu/RsLtfnC18IxPw5wQ3FqHr89fK/MD+GzqTfKPLxg/M Y+WfAiu5aaM+a054sst2kzGhGBMCV04d7JjLMl/ncf/e0rwGyc+KgE9PlG8JT16xqklo 8jO9P+Qkv52dRMNg/9HEP1oWRGfGIlQ/UOf7kJQngYyM7rOIYL7OpCSJsxeoB6HVgpf0 9M0OXWqGESgeBXzMG9JJuQaMUrUusgiBZjAT7s9Br07dm2i/XFolwG4fgl/8jCLIeHGJ bMWlWzxoSpUgKwCqMBJ7ituPqGmTI5D8QgvjnIEV6L6qMOQk2AxpObXOsFJD3Z6GCllj vO1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704388699; x=1704993499; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IRi6ZcW7R00/a07ptTf12NVKem9z9qCQn2dzbpt/bz4=; b=W0P00+pfy11r/EsszZSS2CLi0HRBp0XylzS6Dlc6BltepEiVfZbJtKNb00kkDVxEEn W6zKrZKYxByJPJqpYEU9T1WFyqkNliokgjWmwpYYKrlymaesx71/zy1hY6glixA0W6YO +i8edPvh0193HR4Td7N0yeS/AOwqM7LR8ATgoEA7VgzkqSuIcPqIa6ZYy2GBfItvvHqI c4AZQLPGxyn+fftTcbT6LWt+3nIXKgDlzfCobaNtmXfZeOTJHcQd6gVum3MPgPropZE/ NHXKR5ArzqWN2RR7rqVgETtLfXJXu+fFo3OuCshebiKPpyS7EfF7CtjWtqXMFCsdHTkc 6WCQ== X-Gm-Message-State: AOJu0Yw3b4B2WLtMnAztedGkhFfL7ymVJe0B1EnyVesB4bqQdjI458kz OgiDanIzHN8YDipF9zqEzUSVde+q+BHiyRaWMnH88an2D6yl96E= X-Google-Smtp-Source: AGHT+IFH8yB0eV1v8+1OUMuYvujN1R2j3/TK3hMBlDxjSoz4L3WWBZbfjt7mLRv4fOgfk1LfJV4VlQ== X-Received: by 2002:a17:90a:bcf:b0:28b:cbfb:63af with SMTP id x15-20020a17090a0bcf00b0028bcbfb63afmr787402pjd.86.1704388699280; Thu, 04 Jan 2024 09:18:19 -0800 (PST) Received: from google.com (77.62.105.34.bc.googleusercontent.com. [34.105.62.77]) by smtp.gmail.com with ESMTPSA id nh5-20020a17090b364500b0028bdc7e5a15sm4011773pjb.53.2024.01.04.09.18.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 09:18:18 -0800 (PST) Date: Thu, 4 Jan 2024 17:18:14 +0000 From: Carlos Llamas To: Christophe JAILLET Cc: Tanzir Hasan , Greg Kroah-Hartman , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Suren Baghdasaryan , linux-kernel@vger.kernel.org, Nick Desaulniers , Al Viro Subject: Re: [PATCH] android: removed asm-generic/errno-base.h Message-ID: References: <20231226-binderfs-v1-1-66829e92b523@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Jan 04, 2024 at 04:36:00PM +0100, Christophe JAILLET wrote: > Le 26/12/2023 à 18:09, Tanzir Hasan a écrit : > > asm-generic/errno-base.h can be replaced by linux/errno.h and the file > > will still build correctly. It is an asm-generic file which should be > > avoided if possible. > > > > Suggested-by: Al Viro > > Signed-off-by: Tanzir Hasan > > --- > > drivers/android/binderfs.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c > > index 1224ab7aa070..d04ff6029480 100644 > > --- a/drivers/android/binderfs.c > > +++ b/drivers/android/binderfs.c > > @@ -29,7 +29,7 @@ > > #include > > #include > > #include > > -#include > > +#include > > linux/errno.h is already included a few lines above. > > CJ > Good catch! Then we should just drop the errno-base.h include. -- Carlos Llamas